client: check return of dup(2)

If dup(2) fails, we can't pass it to fdopen.

Fixes: b4f5e72f1383 ("client: parse env variables before sending job-file contents to server")
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/client.c b/client.c
index 60f7c6ab82767cab31cf30443e07affa15c32b51..611ee2f5a3f929d9d7ae7c7d14c229196bdfedbb 100644 (file)
--- a/client.c
+++ b/client.c
@@ -123,8 +123,13 @@ static int read_ini_data(int fd, void *data, size_t size)
        char *p = data;
        int ret = 0;
        FILE *fp;
        char *p = data;
        int ret = 0;
        FILE *fp;

+       int dupfd;

 
 

-       fp = fdopen(dup(fd), "r");
+       dupfd = dup(fd);
+       if (dupfd < 0)
+               return errno;
+
+       fp = fdopen(dupfd, "r");

        if (!fp)
                return errno;
 
        if (!fp)
                return errno;