log: fix bad < 0 check for unsigned
authorJens Axboe <axboe@kernel.dk>
Fri, 29 Dec 2017 15:45:22 +0000 (08:45 -0700)
committerJens Axboe <axboe@kernel.dk>
Fri, 29 Dec 2017 15:45:22 +0000 (08:45 -0700)
Fixes: e5f9a813 ("debug: make debug=io readable with multiple threads")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
log.c

diff --git a/log.c b/log.c
index 291ff24a3ff134e754044f0173b00e4aec2c9943..a327f6aa4c0e68f9e822e349984f31c3d509d9e2 100644 (file)
--- a/log.c
+++ b/log.c
@@ -98,7 +98,7 @@ void log_prevalist(int type, const char *fmt, va_list args)
        char pre[32];
        char *buffer;
        size_t len;
        char pre[32];
        char *buffer;
        size_t len;
-       size_t prelen;
+       int prelen;
        pid_t pid;
 
        pid = gettid();
        pid_t pid;
 
        pid = gettid();
@@ -107,14 +107,11 @@ void log_prevalist(int type, const char *fmt, va_list args)
                return;
 
        prelen = snprintf(pre, sizeof pre, "%-8s %-5u ", debug_levels[type].name, (int) pid);
                return;
 
        prelen = snprintf(pre, sizeof pre, "%-8s %-5u ", debug_levels[type].name, (int) pid);
-       if (prelen < 0)
-               return;
-
-       len = prevalist_to_buf(&buffer, pre, prelen, fmt, args);
-       len = log_info_buf(buffer, len);
-       free(buffer);
-
-       return;
+       if (prelen > 0) {
+               len = prevalist_to_buf(&buffer, pre, prelen, fmt, args);
+               len = log_info_buf(buffer, len);
+               free(buffer);
+       }
 }
 
 size_t log_info(const char *format, ...)
 }
 
 size_t log_info(const char *format, ...)