helper_thread: Initialize all helper_data members before using it
authorBart Van Assche <bart.vanassche@wdc.com>
Sat, 10 Mar 2018 00:46:22 +0000 (16:46 -0800)
committerJens Axboe <axboe@kernel.dk>
Sat, 10 Mar 2018 04:34:16 +0000 (21:34 -0700)
This patch avoids that Valgrind reports the following:

==10492== Thread 2:
==10492== Conditional jump or move depends on uninitialised value(s)
==10492==    at 0x480295: helper_thread_main (helper_thread.c:89)
==10492==    by 0x57B961A: start_thread (pthread_create.c:465)
==10492==    by 0x5CEC98E: clone (clone.S:95)

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
helper_thread.c

index 64e5a3c9d79277fe160065b9cab8f42a27ab78c6..b05f8212a6210e4cd9f00f6147759e3e5418249a 100644 (file)
@@ -156,7 +156,7 @@ int helper_thread_create(struct fio_mutex *startup_mutex, struct sk_out *sk_out)
        struct helper_data *hd;
        int ret;
 
-       hd = smalloc(sizeof(*hd));
+       hd = scalloc(1, sizeof(*hd));
 
        setup_disk_util();
        steadystate_setup();