Revert "Always set ->real_file_size to -1 when failed to get file size"
authorJens Axboe <axboe@fb.com>
Fri, 17 Feb 2017 20:30:43 +0000 (13:30 -0700)
committerJens Axboe <axboe@fb.com>
Fri, 17 Feb 2017 20:30:43 +0000 (13:30 -0700)
This reverts commit 34c9f82301a584899a9e65e4b9f56d98c38a52e7.

It breaks a very basic use case, ala:

./fio --ioengine=libaio --rw=randread --numjobs=1 --iodepth=256 --bs=1M --size=10G --direct=1 --filename=/tmp/test100 --name=test

if /tmp/test100 doesn't already exist.

filesetup.c

index e9976eb17a879ee3c98f51f45dc3b0746f23f3f5..e2585ee92203858310391944a0df5fd942cd494c 100644 (file)
@@ -375,12 +375,10 @@ static int get_file_size(struct thread_data *td, struct fio_file *f)
        else if (f->filetype == FIO_TYPE_CHAR)
                ret = char_size(td, f);
        else
-               f->real_file_size = -1ULL;
+               f->real_file_size = -1;
 
-       if (ret) {
-               f->real_file_size = -1ULL;
+       if (ret)
                return ret;
-       }
 
        if (f->file_offset > f->real_file_size) {
                log_err("%s: offset extends end (%llu > %llu)\n", td->o.name,