Return EILSEQ on verify errors instead of EIO

Suggested by Randy Dunlap <randy.dunlap@oracle.com>

This makes it easier to differentiate between an error to read/write
from disk versus getting the wrong data back.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>

diff --git a/verify.c b/verify.c
index 2aa5ab40e5674c4bb1f10f07697adaa05492ff56..3f27e5ac0775f8e645b7e85574371e013e90595f 100644 (file)
--- a/verify.c
+++ b/verify.c
@@ -185,7 +185,7 @@ static int verify_io_u_meta(struct verify_header *hdr, struct thread_data *td,
        if (vh->offset != io_u->offset + header_num * td->o.verify_interval) {
                log_err("meta: verify failed at %llu/%u\n",
                                io_u->offset + header_num * hdr->len, hdr->len);
        if (vh->offset != io_u->offset + header_num * td->o.verify_interval) {
                log_err("meta: verify failed at %llu/%u\n",
                                io_u->offset + header_num * hdr->len, hdr->len);

-               return EIO;
+               return EILSEQ;

        }
 
        return 0;
        }
 
        return 0;


@@ -211,7 +211,7 @@ static int verify_io_u_sha512(struct verify_header *hdr, struct io_u *io_u,
                                io_u->offset + header_num * hdr->len, hdr->len);
                hexdump(vh->sha512, sizeof(vh->sha512));
                hexdump(sha512_ctx.buf, sizeof(sha512));
                                io_u->offset + header_num * hdr->len, hdr->len);
                hexdump(vh->sha512, sizeof(vh->sha512));
                hexdump(sha512_ctx.buf, sizeof(sha512));

-               return EIO;
+               return EILSEQ;

        }
 
        return 0;
        }
 
        return 0;


@@ -237,7 +237,7 @@ static int verify_io_u_sha256(struct verify_header *hdr, struct io_u *io_u,
                                io_u->offset + header_num * hdr->len, hdr->len);
                hexdump(vh->sha256, sizeof(vh->sha256));
                hexdump(sha256_ctx.buf, sizeof(sha256));
                                io_u->offset + header_num * hdr->len, hdr->len);
                hexdump(vh->sha256, sizeof(vh->sha256));
                hexdump(sha256_ctx.buf, sizeof(sha256));

-               return EIO;
+               return EILSEQ;

        }
 
        return 0;
        }
 
        return 0;


@@ -258,7 +258,7 @@ static int verify_io_u_crc7(struct verify_header *hdr, struct io_u *io_u,
                log_err("crc7: verify failed at %llu/%u\n",
                                io_u->offset + header_num * hdr->len, hdr->len);
                log_err("crc7: wanted %x, got %x\n", vh->crc7, c);
                log_err("crc7: verify failed at %llu/%u\n",
                                io_u->offset + header_num * hdr->len, hdr->len);
                log_err("crc7: wanted %x, got %x\n", vh->crc7, c);

-               return EIO;
+               return EILSEQ;

        }
 
        return 0;
        }
 
        return 0;


@@ -279,7 +279,7 @@ static int verify_io_u_crc16(struct verify_header *hdr, struct io_u *io_u,
                log_err("crc16: verify failed at %llu/%u\n",
                                io_u->offset + header_num * hdr->len, hdr->len);
                log_err("crc16: wanted %x, got %x\n", vh->crc16, c);
                log_err("crc16: verify failed at %llu/%u\n",
                                io_u->offset + header_num * hdr->len, hdr->len);
                log_err("crc16: wanted %x, got %x\n", vh->crc16, c);

-               return EIO;
+               return EILSEQ;

        }
 
        return 0;
        }
 
        return 0;


@@ -302,7 +302,7 @@ static int verify_io_u_crc64(struct verify_header *hdr, struct io_u *io_u,
                                hdr->len);
                log_err("crc64: wanted %llx, got %llx\n",
                                        (unsigned long long) vh->crc64, c);
                                hdr->len);
                log_err("crc64: wanted %llx, got %llx\n",
                                        (unsigned long long) vh->crc64, c);

-               return EIO;
+               return EILSEQ;

        }
 
        return 0;
        }
 
        return 0;


@@ -323,7 +323,7 @@ static int verify_io_u_crc32(struct verify_header *hdr, struct io_u *io_u,
                log_err("crc32: verify failed at %llu/%u\n",
                                io_u->offset + header_num * hdr->len, hdr->len);
                log_err("crc32: wanted %x, got %x\n", vh->crc32, c);
                log_err("crc32: verify failed at %llu/%u\n",
                                io_u->offset + header_num * hdr->len, hdr->len);
                log_err("crc32: wanted %x, got %x\n", vh->crc32, c);

-               return EIO;
+               return EILSEQ;

        }
 
        return 0;
        }
 
        return 0;


@@ -347,7 +347,7 @@ static int verify_io_u_crc32c(struct verify_header *hdr, struct io_u *io_u,
                log_err("crc32c: verify failed at %llu/%u\n",
                                io_u->offset + header_num * hdr->len, hdr->len);
                log_err("crc32c: wanted %x, got %x\n", vh->crc32, c);
                log_err("crc32c: verify failed at %llu/%u\n",
                                io_u->offset + header_num * hdr->len, hdr->len);
                log_err("crc32c: wanted %x, got %x\n", vh->crc32, c);

-               return EIO;
+               return EILSEQ;

        }
 
        return 0;
        }
 
        return 0;


@@ -373,7 +373,7 @@ static int verify_io_u_md5(struct verify_header *hdr, struct io_u *io_u,
                                io_u->offset + header_num * hdr->len, hdr->len);
                hexdump(vh->md5_digest, sizeof(vh->md5_digest));
                hexdump(md5_ctx.hash, sizeof(hash));
                                io_u->offset + header_num * hdr->len, hdr->len);
                hexdump(vh->md5_digest, sizeof(vh->md5_digest));
                hexdump(md5_ctx.hash, sizeof(hash));

-               return EIO;
+               return EILSEQ;

        }
 
        return 0;
        }
 
        return 0;


@@ -406,7 +406,7 @@ int verify_io_u_pattern(unsigned long pattern, unsigned long pattern_size,
                        log_err("fio: got pattern %x, wanted %x. Bad bits %d\n",
                                buf[i], split_pattern[mod], bits);
                        log_err("fio: bad pattern block offset %u\n", i);
                        log_err("fio: got pattern %x, wanted %x. Bad bits %d\n",
                                buf[i], split_pattern[mod], bits);
                        log_err("fio: bad pattern block offset %u\n", i);

-                       return EIO;
+                       return EILSEQ;

                }
                mod++;
                if (mod == pattern_size)
                }
                mod++;
                if (mod == pattern_size)


@@ -444,7 +444,7 @@ int verify_io_u(struct thread_data *td, struct io_u *io_u)
 
                if (hdr->fio_magic != FIO_HDR_MAGIC) {
                        log_err("Bad verify header %x\n", hdr->fio_magic);
 
                if (hdr->fio_magic != FIO_HDR_MAGIC) {
                        log_err("Bad verify header %x\n", hdr->fio_magic);

-                       return EIO;
+                       return EILSEQ;

                }
 
                if (td->o.verify_pattern_bytes) {
                }
 
                if (td->o.verify_pattern_bytes) {