iolog: fix leak for unsupported iolog version

Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/iolog.c b/iolog.c
index 2f062892863cb9aa586baa9875fa06dfe30ba0cb..b72dcf9791cfa242ceace8b4080a03934e9fa554 100644 (file)
--- a/iolog.c
+++ b/iolog.c
@@ -634,18 +634,18 @@ static bool init_iolog_read(struct thread_data *td)
                return false;
        }
 
                return false;
        }
 

-       td->io_log_rfile = f;
-

        /*
         * version 2 of the iolog stores a specific string as the
         * first line, check for that
         */
        if (!strncmp(iolog_ver2, buffer, strlen(iolog_ver2))) {
                free_release_files(td);
        /*
         * version 2 of the iolog stores a specific string as the
         * first line, check for that
         */
        if (!strncmp(iolog_ver2, buffer, strlen(iolog_ver2))) {
                free_release_files(td);

+               td->io_log_rfile = f;

                return read_iolog2(td);
        }
 
        log_err("fio: iolog version 1 is no longer supported\n");
                return read_iolog2(td);
        }
 
        log_err("fio: iolog version 1 is no longer supported\n");

+       fclose(f);

        return false;
 }
 
        return false;
 }