backend: revert bad memory leak fix
authorJens Axboe <axboe@kernel.dk>
Tue, 30 Aug 2022 16:48:18 +0000 (10:48 -0600)
committerJens Axboe <axboe@kernel.dk>
Tue, 30 Aug 2022 16:49:50 +0000 (10:49 -0600)
This essentially reverts the commit mentioned in the fixes line, as it
causes crashes with using a trigger timeout + command.

Fixes: 807473c36e10 ("fixed memory leak detected by ASAN")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
backend.c

index 375a23e420a23b403b457bba084407f50be23641..fe614f6e1cf025aaf1e24f5b25118d4b1f8ab862 100644 (file)
--- a/backend.c
+++ b/backend.c
@@ -2451,10 +2451,8 @@ reap:
                                                        strerror(ret));
                        } else {
                                pid_t pid;
-                               struct fio_file **files;
                                void *eo;
                                dprint(FD_PROCESS, "will fork\n");
-                               files = td->files;
                                eo = td->eo;
                                read_barrier();
                                pid = fork();
@@ -2465,9 +2463,6 @@ reap:
                                        _exit(ret);
                                } else if (i == fio_debug_jobno)
                                        *fio_debug_jobp = pid;
-                               // freeing previously allocated memory for files
-                               // this memory freed MUST NOT be shared between processes, only the pointer itself may be shared within TD
-                               free(files);
                                free(eo);
                                free(fd);
                                fd = NULL;