gfio: don't have multiple versions of main_ui
authorJens Axboe <axboe@kernel.dk>
Tue, 2 Jun 2020 14:20:03 +0000 (08:20 -0600)
committerJens Axboe <axboe@kernel.dk>
Tue, 2 Jun 2020 14:20:03 +0000 (08:20 -0600)
Also comment a fall-through case appropriately, so newer GCC
don't warn.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
gfio.c
gfio.h

diff --git a/gfio.c b/gfio.c
index 2805396..734651b 100644 (file)
--- a/gfio.c
+++ b/gfio.c
@@ -38,6 +38,8 @@
 #include "gclient.h"
 #include "graph.h"
 
+struct gui main_ui;
+
 static bool gfio_server_running;
 static unsigned int gfio_graph_limit = 100;
 
@@ -223,7 +225,7 @@ static void update_button_states(struct gui *ui, struct gui_entry *ge)
        switch (ge->state) {
        default:
                gfio_report_error(ge, "Bad client state: %u\n", ge->state);
-               /* fall through to new state */
+               /* fall-through */
        case GE_STATE_NEW:
                connect_state = 1;
                edit_state = 1;
diff --git a/gfio.h b/gfio.h
index aa14e3c..2bf0ea2 100644 (file)
--- a/gfio.h
+++ b/gfio.h
@@ -78,7 +78,9 @@ struct gui {
        int handler_running;
 
        GHashTable *ge_hash;
-} main_ui;
+};
+
+extern struct gui main_ui;
 
 enum {
        GE_STATE_NEW = 1,