net engine: fix potential buffer overrun in socket path

Signed-off-by: Jens Axboe <axboe@fb.com>

diff --git a/engines/net.c b/engines/net.c
index d036a581811ac5b945ae074169b90f66f090142f..3e26131be9a9913b853080b8ab85695aff60fb98 100644 (file)
--- a/engines/net.c
+++ b/engines/net.c
@@ -945,7 +945,8 @@ static int fio_netio_setup_connect_unix(struct thread_data *td,
        struct sockaddr_un *soun = &nd->addr_un;
 
        soun->sun_family = AF_UNIX;
        struct sockaddr_un *soun = &nd->addr_un;
 
        soun->sun_family = AF_UNIX;

-       strcpy(soun->sun_path, path);
+       memset(soun->sun_path, 0, sizeof(soun->sun_path));
+       strncpy(soun->sun_path, path, sizeof(soun->sun_path) - 1);

        return 0;
 }
 
        return 0;
 }
 


@@ -976,7 +977,7 @@ static int fio_netio_setup_listen_unix(struct thread_data *td, const char *path)
 
        memset(addr, 0, sizeof(*addr));
        addr->sun_family = AF_UNIX;
 
        memset(addr, 0, sizeof(*addr));
        addr->sun_family = AF_UNIX;

-       strcpy(addr->sun_path, path);
+       strncpy(addr->sun_path, path, sizeof(addr->sun_path) - 1);

        unlink(path);
 
        len = sizeof(addr->sun_family) + strlen(path) + 1;
        unlink(path);
 
        len = sizeof(addr->sun_family) + strlen(path) + 1;