zbd: simplify zoneskip= validness check
authorAlexey Dobriyan <adobriyan@gmail.com>
Mon, 22 Feb 2021 13:21:22 +0000 (16:21 +0300)
committerJens Axboe <axboe@kernel.dk>
Mon, 22 Feb 2021 14:35:34 +0000 (07:35 -0700)
Simply check the remainder:

(zoneskip % zone_size) > 0

It will do the right thing for all zoneskip= values, and
zone size being positive is checked earlier.

Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Signed-off-by: Alexey Dobriyan (SK hynix) <adobriyan@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
zbd.c

diff --git a/zbd.c b/zbd.c
index 6a26fe108a68acf55c7ad2b7e59e8fccb97f0dc8..a93a977eb05da78fabf5624e40ce47f137aeb0f8 100644 (file)
--- a/zbd.c
+++ b/zbd.c
@@ -285,9 +285,7 @@ static bool zbd_verify_sizes(void)
                                return false;
                        }
 
-                       if (td->o.zone_skip &&
-                           (td->o.zone_skip < td->o.zone_size ||
-                            td->o.zone_skip % td->o.zone_size)) {
+                       if (td->o.zone_skip % td->o.zone_size) {
                                log_err("%s: zoneskip %llu is not a multiple of the device zone size %llu.\n",
                                        f->file_name, (unsigned long long) td->o.zone_skip,
                                        (unsigned long long) td->o.zone_size);