don't access dlclose'd dynamic ioengine object after close
authorEric Sandeen <esandeen@redhat.com>
Fri, 7 May 2021 21:13:05 +0000 (16:13 -0500)
committerJens Axboe <axboe@kernel.dk>
Sun, 9 May 2021 04:13:16 +0000 (22:13 -0600)
commit79f488cbd95ca6989031a7ace5ec382313d31b3c
tree32b689c50def3b70a08355951a7651dde4dd42f3
parentcffe80a41cbf9b26446c803177a27f7695f94a31
don't access dlclose'd dynamic ioengine object after close

Alexey reported this bug when using dynamically loaded IO engines;
a segfault on the line where we set the dlhandle to NULL after
the dlclose.

I think this is because ops points to the thing we obtained from dlsym:

ops = dlsym(dlhandle, engine_lib);

and after the final dlclose, the object no longer exists and efforts
to set the handle within it will fail for obvious reasons.
I'm not sure why I hadn't seen this before.

Fixes-RH-Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1956963
Reported-by: Alexey Dobriyan <adobriyan@gmail.com>
Fixes: f6931a1 ("fio: move dynamic library handle to io_ops structure")
Tested-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
ioengines.c