X-Git-Url: https://git.kernel.dk/?p=fio.git;a=blobdiff_plain;f=stat.c;h=e7ffd8ccf1f7bc6de8241a2e26b25035d0a8169d;hp=6e55925b1cf288ebadc565a4d4c506248ed22b9e;hb=6104ddb6b14be6f3d97bf0faa5b7e06dea22f5f4;hpb=e6d276f2c07cc35f3d57210713e8288bb44daf97

diff --git a/stat.c b/stat.c
index 6e55925b..e7ffd8cc 100644
--- a/stat.c
+++ b/stat.c
@@ -94,14 +94,26 @@ static int disk_util_exists(dev_t dev)
 
 static void disk_util_add(dev_t dev, char *path)
 {
-	struct disk_util *du = malloc(sizeof(*du));
+	struct disk_util *du, *__du;
+	struct list_head *entry;
 
+	du = malloc(sizeof(*du));
 	memset(du, 0, sizeof(*du));
 	INIT_LIST_HEAD(&du->list);
 	sprintf(du->path, "%s/stat", path);
 	du->name = strdup(basename(path));
 	du->dev = dev;
 
+	list_for_each(entry, &disk_list) {
+		__du = list_entry(entry, struct disk_util, list);
+
+		if (!strcmp(du->name, __du->name)) {
+			free(du->name);
+			free(du);
+			return;
+		}
+	}
+
 	fio_gettime(&du->time, NULL);
 	get_io_ticks(du, &du->last_dus);
 
@@ -263,7 +275,6 @@ void update_rusage_stat(struct thread_data *td)
 	td->usr_time += mtime_since(&td->ru_start.ru_utime, &td->ru_end.ru_utime);
 	td->sys_time += mtime_since(&td->ru_start.ru_stime, &td->ru_end.ru_stime);
 	td->ctx += td->ru_end.ru_nvcsw + td->ru_end.ru_nivcsw - (td->ru_start.ru_nvcsw + td->ru_start.ru_nivcsw);
-
 	
 	memcpy(&td->ru_start, &td->ru_end, sizeof(td->ru_end));
 }
@@ -271,7 +282,7 @@ void update_rusage_stat(struct thread_data *td)
 static int calc_lat(struct io_stat *is, unsigned long *min, unsigned long *max,
 		    double *mean, double *dev)
 {
-	double n;
+	double n = is->samples;
 
 	if (is->samples == 0)
 		return 0;
@@ -280,13 +291,13 @@ static int calc_lat(struct io_stat *is, unsigned long *min, unsigned long *max,
 	*max = is->max_val;
 
 	n = (double) is->samples;
-	*mean = (double) is->val / n;
-	*dev = 0;
+	*mean = is->mean;
 
-	if (n <= 1)
-		return 1;
+	if (n > 1.0)
+		*dev = sqrt(is->S / (n - 1.0));
+	else
+		*dev = -1.0;
 
-	*dev = sqrt(((double) is->val_sq - (*mean * *mean) / n) / (n - 1));
 	return 1;
 }
 
@@ -346,16 +357,16 @@ static void show_ddir_status(struct thread_data *td, struct group_run_stats *rs,
 	fprintf(f_out, "  %s: io=%6lluMiB, bw=%6lluKiB/s, runt=%6lumsec\n", ddir_str[ddir], td->io_bytes[ddir] >> 20, bw, td->runtime[ddir]);
 
 	if (calc_lat(&td->slat_stat[ddir], &min, &max, &mean, &dev))
-		fprintf(f_out, "    slat (msec): min=%5lu, max=%5lu, avg=%5.02f, dev=%5.02f\n", min, max, mean, dev);
+		fprintf(f_out, "    slat (msec): min=%5lu, max=%5lu, avg=%5.02f, stdev=%5.02f\n", min, max, mean, dev);
 
 	if (calc_lat(&td->clat_stat[ddir], &min, &max, &mean, &dev))
-		fprintf(f_out, "    clat (msec): min=%5lu, max=%5lu, avg=%5.02f, dev=%5.02f\n", min, max, mean, dev);
+		fprintf(f_out, "    clat (msec): min=%5lu, max=%5lu, avg=%5.02f, stdev=%5.02f\n", min, max, mean, dev);
 
 	if (calc_lat(&td->bw_stat[ddir], &min, &max, &mean, &dev)) {
 		double p_of_agg;
 
 		p_of_agg = mean * 100 / (double) rs->agg[ddir];
-		fprintf(f_out, "    bw (KiB/s) : min=%5lu, max=%5lu, per=%3.2f%%, avg=%5.02f, dev=%5.02f\n", min, max, p_of_agg, mean, dev);
+		fprintf(f_out, "    bw (KiB/s) : min=%5lu, max=%5lu, per=%3.2f%%, avg=%5.02f, stdev=%5.02f\n", min, max, p_of_agg, mean, dev);
 	}
 }
 
@@ -533,15 +544,21 @@ void show_run_stats(void)
 	free(runstats);
 }
 
-static inline void add_stat_sample(struct io_stat *is, unsigned long val)
+static inline void add_stat_sample(struct io_stat *is, unsigned long data)
 {
-	if (val > is->max_val)
-		is->max_val = val;
-	if (val < is->min_val)
-		is->min_val = val;
+	double val = data;
+	double delta, n;
+
+	if (data > is->max_val)
+		is->max_val = data;
+	if (data < is->min_val)
+		is->min_val = data;
+
+	delta = val - is->mean;
+	n = is->samples + 1.0;
+	is->mean += delta / n;
+	is->S += delta * (val - is->mean);
 
-	is->val += val;
-	is->val_sq += val * val;
 	is->samples++;
 }