X-Git-Url: https://git.kernel.dk/?p=fio.git;a=blobdiff_plain;f=server.c;h=116b3d605d8da1aac6c9b39ee0469cad9db51817;hp=339bb66a6f3b980e6a031434e23a5344f544b9c5;hb=731e30a2551315c609c23ac107377b63c02d51fa;hpb=89c1707cb512e562b55b56c268f7fad612be6f04 diff --git a/server.c b/server.c index 339bb66a..116b3d60 100644 --- a/server.c +++ b/server.c @@ -16,15 +16,16 @@ #include #include #include +#include #include "fio.h" #include "server.h" #include "crc/crc16.h" -#include "ieee754.h" +#include "lib/ieee754.h" #include "fio_version.h" -int fio_net_port = 8765; +int fio_net_port = FIO_NET_PORT; int exit_backend = 0; @@ -32,6 +33,9 @@ static int server_fd = -1; static char *fio_server_arg; static char *bind_sock; static struct sockaddr_in saddr_in; +static struct sockaddr_in6 saddr_in6; +static int first_cmd_check; +static int use_ipv6; static const char *fio_server_ops[FIO_NET_CMD_NR] = { "", @@ -46,7 +50,11 @@ static const char *fio_server_ops[FIO_NET_CMD_NR] = { "ETA", "PROBE", "START", - "STOP" + "STOP", + "DISK_UTIL", + "SERVER_START", + "ADD_JOB", + "CMD_RUN" }; const char *fio_server_op(unsigned int op) @@ -62,7 +70,7 @@ const char *fio_server_op(unsigned int op) int fio_send_data(int sk, const void *p, unsigned int len) { - assert(len <= sizeof(struct fio_net_cmd) + FIO_SERVER_MAX_PDU); + assert(len <= sizeof(struct fio_net_cmd) + FIO_SERVER_MAX_FRAGMENT_PDU); do { int ret = send(sk, p, len, 0); @@ -77,11 +85,16 @@ int fio_send_data(int sk, const void *p, unsigned int len) break; else if (errno == EAGAIN || errno == EINTR) continue; + else + break; } while (!exit_backend); if (!len) return 0; + if (errno) + return -errno; + return 1; } @@ -100,6 +113,8 @@ int fio_recv_data(int sk, void *p, unsigned int len) break; else if (errno == EAGAIN || errno == EINTR) continue; + else + break; } while (!exit_backend); if (!len) @@ -115,7 +130,7 @@ static int verify_convert_cmd(struct fio_net_cmd *cmd) cmd->cmd_crc16 = le16_to_cpu(cmd->cmd_crc16); cmd->pdu_crc16 = le16_to_cpu(cmd->pdu_crc16); - crc = crc16(cmd, FIO_NET_CMD_CRC_SZ); + crc = fio_crc16(cmd, FIO_NET_CMD_CRC_SZ); if (crc != cmd->cmd_crc16) { log_err("fio: server bad crc on command (got %x, wanted %x)\n", cmd->cmd_crc16, crc); @@ -136,7 +151,7 @@ static int verify_convert_cmd(struct fio_net_cmd *cmd) return 1; } - if (cmd->pdu_len > FIO_SERVER_MAX_PDU) { + if (cmd->pdu_len > FIO_SERVER_MAX_FRAGMENT_PDU) { log_err("fio: command payload too large: %u\n", cmd->pdu_len); return 1; } @@ -176,8 +191,12 @@ struct fio_net_cmd *fio_net_recv_cmd(int sk) if (first) memcpy(cmdret, &cmd, sizeof(cmd)); - else - assert(cmdret->opcode == cmd.opcode); + else if (cmdret->opcode != cmd.opcode) { + log_err("fio: fragment opcode mismatch (%d != %d)\n", + cmdret->opcode, cmd.opcode); + ret = 1; + break; + } if (!cmd.pdu_len) break; @@ -189,7 +208,7 @@ struct fio_net_cmd *fio_net_recv_cmd(int sk) break; /* Verify payload crc */ - crc = crc16(pdu, cmd.pdu_len); + crc = fio_crc16(pdu, cmd.pdu_len); if (crc != cmd.pdu_crc16) { log_err("fio: server bad crc on payload "); log_err("(got %x, wanted %x)\n", cmd.pdu_crc16, crc); @@ -208,12 +227,21 @@ struct fio_net_cmd *fio_net_recv_cmd(int sk) cmdret = NULL; } else if (cmdret) { /* zero-terminate text input */ - if (cmdret->pdu_len && (cmdret->opcode == FIO_NET_CMD_TEXT || - cmdret->opcode == FIO_NET_CMD_JOB)) { - char *buf = (char *) cmdret->payload; - - buf[cmdret->pdu_len ] = '\0'; + if (cmdret->pdu_len) { + if (cmdret->opcode == FIO_NET_CMD_TEXT) { + struct cmd_text_pdu *pdu = (struct cmd_text_pdu *) cmdret->payload; + char *buf = (char *) pdu->buf; + + buf[pdu->buf_len ] = '\0'; + } else if (cmdret->opcode == FIO_NET_CMD_JOB) { + struct cmd_job_pdu *pdu = (struct cmd_job_pdu *) cmdret->payload; + char *buf = (char *) pdu->buf; + int len = le32_to_cpu(pdu->buf_len); + + buf[len] = '\0'; + } } + /* frag flag is internal */ cmdret->flags &= ~FIO_NET_CMD_F_MORE; } @@ -221,15 +249,19 @@ struct fio_net_cmd *fio_net_recv_cmd(int sk) return cmdret; } -void fio_net_cmd_crc(struct fio_net_cmd *cmd) +void fio_net_cmd_crc_pdu(struct fio_net_cmd *cmd, void *pdu) { uint32_t pdu_len; - cmd->cmd_crc16 = __cpu_to_le16(crc16(cmd, FIO_NET_CMD_CRC_SZ)); + cmd->cmd_crc16 = __cpu_to_le16(fio_crc16(cmd, FIO_NET_CMD_CRC_SZ)); pdu_len = le32_to_cpu(cmd->pdu_len); - if (pdu_len) - cmd->pdu_crc16 = __cpu_to_le16(crc16(cmd->payload, pdu_len)); + cmd->pdu_crc16 = __cpu_to_le16(fio_crc16(pdu, pdu_len)); +} + +void fio_net_cmd_crc(struct fio_net_cmd *cmd) +{ + fio_net_cmd_crc_pdu(cmd, cmd->payload); } int fio_net_send_cmd(int fd, uint16_t opcode, const void *buf, off_t size, @@ -241,8 +273,8 @@ int fio_net_send_cmd(int fd, uint16_t opcode, const void *buf, off_t size, do { this_len = size; - if (this_len > FIO_SERVER_MAX_PDU) - this_len = FIO_SERVER_MAX_PDU; + if (this_len > FIO_SERVER_MAX_FRAGMENT_PDU) + this_len = FIO_SERVER_MAX_FRAGMENT_PDU; if (!cmd || cur_len < sizeof(*cmd) + this_len) { if (cmd) @@ -295,7 +327,7 @@ int fio_net_send_simple_cmd(int sk, uint16_t opcode, uint64_t tag, cmd = malloc(sizeof(*cmd)); - fio_init_net_cmd(&cmd->cmd, opcode, NULL, 0, (uint64_t) cmd); + fio_init_net_cmd(&cmd->cmd, opcode, NULL, 0, (uintptr_t) cmd); fio_net_cmd_crc(&cmd->cmd); INIT_FLIST_HEAD(&cmd->list); @@ -318,35 +350,54 @@ static int fio_server_send_quit_cmd(void) return fio_net_send_simple_cmd(server_fd, FIO_NET_CMD_QUIT, 0, NULL); } -static int handle_job_cmd(struct fio_net_cmd *cmd) +static int handle_run_cmd(struct fio_net_cmd *cmd) { - char *buf = (char *) cmd->payload; + struct cmd_end_pdu epdu; int ret; - if (parse_jobs_ini(buf, 1, 0)) { - fio_server_send_quit_cmd(); - return -1; - } + ret = fio_backend(); - fio_net_send_simple_cmd(server_fd, FIO_NET_CMD_START, 0, NULL); + epdu.error = ret; + fio_net_send_cmd(server_fd, FIO_NET_CMD_STOP, &epdu, sizeof(epdu), 0); - ret = exec_run(); fio_server_send_quit_cmd(); reset_fio_state(); + first_cmd_check = 0; return ret; } +static int handle_job_cmd(struct fio_net_cmd *cmd) +{ + struct cmd_job_pdu *pdu = (struct cmd_job_pdu *) cmd->payload; + void *buf = pdu->buf; + struct cmd_start_pdu spdu; + + pdu->buf_len = le32_to_cpu(pdu->buf_len); + pdu->client_type = le32_to_cpu(pdu->client_type); + + if (parse_jobs_ini(buf, 1, 0, pdu->client_type)) { + fio_server_send_quit_cmd(); + return -1; + } + + spdu.jobs = cpu_to_le32(thread_number); + fio_net_send_cmd(server_fd, FIO_NET_CMD_START, &spdu, sizeof(spdu), 0); + return 0; +} + static int handle_jobline_cmd(struct fio_net_cmd *cmd) { void *pdu = cmd->payload; struct cmd_single_line_pdu *cslp; struct cmd_line_pdu *clp; unsigned long offset; + struct cmd_start_pdu spdu; char **argv; - int ret, i; + int i; clp = pdu; clp->lines = le16_to_cpu(clp->lines); + clp->client_type = le16_to_cpu(clp->client_type); argv = malloc(clp->lines * sizeof(char *)); offset = sizeof(*clp); @@ -360,7 +411,7 @@ static int handle_jobline_cmd(struct fio_net_cmd *cmd) dprint(FD_NET, "server: %d: %s\n", i, argv[i]); } - if (parse_cmd_line(clp->lines, argv)) { + if (parse_cmd_line(clp->lines, argv, clp->client_type)) { fio_server_send_quit_cmd(); free(argv); return -1; @@ -368,12 +419,9 @@ static int handle_jobline_cmd(struct fio_net_cmd *cmd) free(argv); - fio_net_send_simple_cmd(server_fd, FIO_NET_CMD_START, 0, NULL); - - ret = exec_run(); - fio_server_send_quit_cmd(); - reset_fio_state(); - return ret; + spdu.jobs = cpu_to_le32(thread_number); + fio_net_send_cmd(server_fd, FIO_NET_CMD_START, &spdu, sizeof(spdu), 0); + return 0; } static int handle_probe_cmd(struct fio_net_cmd *cmd) @@ -394,6 +442,8 @@ static int handle_probe_cmd(struct fio_net_cmd *cmd) probe.os = FIO_OS; probe.arch = FIO_ARCH; + probe.bpp = sizeof(void *); + return fio_net_send_cmd(server_fd, FIO_NET_CMD_PROBE, &probe, sizeof(probe), cmd->tag); } @@ -403,7 +453,10 @@ static int handle_send_eta_cmd(struct fio_net_cmd *cmd) size_t size; int i; - size = sizeof(*je) + thread_number * sizeof(char); + if (!thread_number) + return 0; + + size = sizeof(*je) + thread_number * sizeof(char) + 1; je = malloc(size); memset(je, 0, size); @@ -418,18 +471,19 @@ static int handle_send_eta_cmd(struct fio_net_cmd *cmd) je->nr_ramp = cpu_to_le32(je->nr_ramp); je->nr_pending = cpu_to_le32(je->nr_pending); je->files_open = cpu_to_le32(je->files_open); - je->m_rate = cpu_to_le32(je->m_rate); - je->t_rate = cpu_to_le32(je->t_rate); - je->m_iops = cpu_to_le32(je->m_iops); - je->t_iops = cpu_to_le32(je->t_iops); for (i = 0; i < 2; i++) { + je->m_rate[i] = cpu_to_le32(je->m_rate[i]); + je->t_rate[i] = cpu_to_le32(je->t_rate[i]); + je->m_iops[i] = cpu_to_le32(je->m_iops[i]); + je->t_iops[i] = cpu_to_le32(je->t_iops[i]); je->rate[i] = cpu_to_le32(je->rate[i]); je->iops[i] = cpu_to_le32(je->iops[i]); } - je->elapsed_sec = cpu_to_le32(je->nr_running); + je->elapsed_sec = cpu_to_le64(je->elapsed_sec); je->eta_sec = cpu_to_le64(je->eta_sec); + je->nr_threads = cpu_to_le32(je->nr_threads); fio_net_send_cmd(server_fd, FIO_NET_CMD_ETA, je, size, cmd->tag); free(je); @@ -462,6 +516,9 @@ static int handle_command(struct fio_net_cmd *cmd) case FIO_NET_CMD_SEND_ETA: ret = handle_send_eta_cmd(cmd); break; + case FIO_NET_CMD_RUN: + ret = handle_run_cmd(cmd); + break; default: log_err("fio: unknown opcode: %s\n",fio_server_op(cmd->opcode)); ret = 1; @@ -529,6 +586,10 @@ static int handle_connection(int sk, int block) void fio_server_idle_loop(void) { + if (!first_cmd_check) { + fio_net_send_simple_cmd(server_fd, FIO_NET_CMD_SERVER_START, 0, NULL); + first_cmd_check = 1; + } if (server_fd != -1) handle_connection(server_fd, 0); } @@ -587,12 +648,30 @@ out: return exitval; } -int fio_server_text_output(const char *buf, size_t len) +int fio_server_text_output(int level, const char *buf, size_t len) { - if (server_fd != -1) - return fio_net_send_cmd(server_fd, FIO_NET_CMD_TEXT, buf, len, 0); + struct cmd_text_pdu *pdu; + unsigned int tlen; + struct timeval tv; + + if (server_fd == -1) + return log_local_buf(buf, len); + + tlen = sizeof(*pdu) + len; + pdu = malloc(tlen); + + pdu->level = __cpu_to_le32(level); + pdu->buf_len = __cpu_to_le32(len); + + gettimeofday(&tv, NULL); + pdu->log_sec = __cpu_to_le64(tv.tv_sec); + pdu->log_usec = __cpu_to_le64(tv.tv_usec); + + memcpy(pdu->buf, buf, len); - return log_local_buf(buf, len); + fio_net_send_cmd(server_fd, FIO_NET_CMD_TEXT, pdu, tlen, 0); + free(pdu); + return len; } static void convert_io_stat(struct io_stat *dst, struct io_stat *src) @@ -662,9 +741,10 @@ void fio_server_send_ts(struct thread_stat *ts, struct group_run_stats *rs) p.ts.clat_percentiles = cpu_to_le64(ts->clat_percentiles); for (i = 0; i < FIO_IO_U_LIST_MAX_LEN; i++) { - fio_fp64_t *fp = &p.ts.percentile_list[i]; + fio_fp64_t *src = &ts->percentile_list[i]; + fio_fp64_t *dst = &p.ts.percentile_list[i]; - fp->u.i = __cpu_to_le64(fio_double_to_uint64(fp->u.f)); + dst->u.i = __cpu_to_le64(fio_double_to_uint64(src->u.f)); } for (i = 0; i < FIO_IO_U_MAP_NR; i++) { @@ -716,26 +796,156 @@ void fio_server_send_gs(struct group_run_stats *rs) fio_net_send_cmd(server_fd, FIO_NET_CMD_GS, &gs, sizeof(gs), 0); } -int fio_server_log(const char *format, ...) +static void convert_agg(struct disk_util_agg *dst, struct disk_util_agg *src) +{ + int i; + + for (i = 0; i < 2; i++) { + dst->ios[i] = cpu_to_le32(src->ios[i]); + dst->merges[i] = cpu_to_le32(src->merges[i]); + dst->sectors[i] = cpu_to_le64(src->sectors[i]); + dst->ticks[i] = cpu_to_le32(src->ticks[i]); + } + + dst->io_ticks = cpu_to_le32(src->io_ticks); + dst->time_in_queue = cpu_to_le32(src->time_in_queue); + dst->slavecount = cpu_to_le32(src->slavecount); + dst->max_util.u.i = __cpu_to_le64(fio_double_to_uint64(src->max_util.u.f)); +} + +static void convert_dus(struct disk_util_stat *dst, struct disk_util_stat *src) +{ + int i; + + strcpy((char *) dst->name, (char *) src->name); + + for (i = 0; i < 2; i++) { + dst->ios[i] = cpu_to_le32(src->ios[i]); + dst->merges[i] = cpu_to_le32(src->merges[i]); + dst->sectors[i] = cpu_to_le64(src->sectors[i]); + dst->ticks[i] = cpu_to_le32(src->ticks[i]); + } + + dst->io_ticks = cpu_to_le32(src->io_ticks); + dst->time_in_queue = cpu_to_le32(src->time_in_queue); + dst->msec = cpu_to_le64(src->msec); +} + +void fio_server_send_du(void) +{ + struct disk_util *du; + struct flist_head *entry; + struct cmd_du_pdu pdu; + + dprint(FD_NET, "server: sending disk_util %d\n", !flist_empty(&disk_list)); + + memset(&pdu, 0, sizeof(pdu)); + + flist_for_each(entry, &disk_list) { + du = flist_entry(entry, struct disk_util, list); + + convert_dus(&pdu.dus, &du->dus); + convert_agg(&pdu.agg, &du->agg); + + fio_net_send_cmd(server_fd, FIO_NET_CMD_DU, &pdu, sizeof(pdu), 0); + } +} + +int fio_send_iolog(struct thread_data *td, struct io_log *log, const char *name) { - char buffer[1024]; - va_list args; - size_t len; + struct cmd_iolog_pdu pdu; + struct fio_net_cmd cmd; + z_stream stream; + void *out_pdu; + int i; + + pdu.nr_samples = __cpu_to_le32(log->nr_samples); + pdu.log_type = cpu_to_le32(log->log_type); + strcpy((char *) pdu.name, name); + + for (i = 0; i < log->nr_samples; i++) { + struct io_sample *s = &log->log[i]; + + s->time = cpu_to_le64(s->time); + s->val = cpu_to_le64(s->val); + s->ddir = cpu_to_le32(s->ddir); + s->bs = cpu_to_le32(s->bs); + } + + /* + * Dirty - since the log is potentially huge, compress it into + * FIO_SERVER_MAX_FRAGMENT_PDU chunks and let the receiving + * side defragment it. + */ + out_pdu = malloc(FIO_SERVER_MAX_FRAGMENT_PDU); + + stream.zalloc = Z_NULL; + stream.zfree = Z_NULL; + stream.opaque = Z_NULL; - dprint(FD_NET, "server log\n"); + if (deflateInit(&stream, Z_DEFAULT_COMPRESSION) != Z_OK) { + free(out_pdu); + return 1; + } + + /* + * Send header first, it's not compressed. + */ + __fio_init_net_cmd(&cmd, FIO_NET_CMD_IOLOG, sizeof(pdu), 0); + cmd.flags = __cpu_to_le32(FIO_NET_CMD_F_MORE); + fio_net_cmd_crc_pdu(&cmd, &pdu); + fio_send_data(server_fd, &cmd, sizeof(cmd)); + fio_send_data(server_fd, &pdu, sizeof(pdu)); + + stream.next_in = (void *) log->log; + stream.avail_in = log->nr_samples * sizeof(struct io_sample); + + do { + unsigned int this_len; + + stream.avail_out = FIO_SERVER_MAX_FRAGMENT_PDU; + stream.next_out = out_pdu; + assert(deflate(&stream, Z_FINISH) == Z_OK); + + this_len = FIO_SERVER_MAX_FRAGMENT_PDU - stream.avail_out; + + __fio_init_net_cmd(&cmd, FIO_NET_CMD_IOLOG, this_len, 0); - va_start(args, format); - len = vsnprintf(buffer, sizeof(buffer), format, args); - va_end(args); + if (stream.avail_in) + cmd.flags = __cpu_to_le32(FIO_NET_CMD_F_MORE); - return fio_server_text_output(buffer, len); + fio_net_cmd_crc_pdu(&cmd, out_pdu); + + fio_send_data(server_fd, &cmd, sizeof(cmd)); + fio_send_data(server_fd, out_pdu, this_len); + } while (stream.avail_in); + + free(out_pdu); + deflateEnd(&stream); + return 0; +} + +void fio_server_send_add_job(struct thread_options *o, const char *ioengine) +{ + struct cmd_add_job_pdu pdu; + + memset(&pdu, 0, sizeof(pdu)); + convert_thread_options_to_net(&pdu.top, o); + + fio_net_send_cmd(server_fd, FIO_NET_CMD_ADD_JOB, &pdu, sizeof(pdu), 0); } static int fio_init_server_ip(void) { + struct sockaddr *addr; + fio_socklen_t socklen; int sk, opt; - sk = socket(AF_INET, SOCK_STREAM, 0); + if (use_ipv6) + sk = socket(AF_INET6, SOCK_STREAM, 0); + else + sk = socket(AF_INET, SOCK_STREAM, 0); + if (sk < 0) { log_err("fio: socket: %s\n", strerror(errno)); return -1; @@ -755,9 +965,17 @@ static int fio_init_server_ip(void) } #endif - saddr_in.sin_family = AF_INET; + if (use_ipv6) { + addr = (struct sockaddr *) &saddr_in6; + socklen = sizeof(saddr_in6); + saddr_in6.sin6_family = AF_INET6; + } else { + addr = (struct sockaddr *) &saddr_in; + socklen = sizeof(saddr_in); + saddr_in.sin_family = AF_INET; + } - if (bind(sk, (struct sockaddr *) &saddr_in, sizeof(saddr_in)) < 0) { + if (bind(sk, addr, socklen) < 0) { log_err("fio: bind: %s\n", strerror(errno)); close(sk); return -1; @@ -813,9 +1031,27 @@ static int fio_init_server_connection(void) if (sk < 0) return sk; - if (!bind_sock) - sprintf(bind_str, "%s:%u", inet_ntoa(saddr_in.sin_addr), fio_net_port); - else + if (!bind_sock) { + char *p, port[16]; + const void *src; + int af; + + if (use_ipv6) { + af = AF_INET6; + src = &saddr_in6.sin6_addr; + } else { + af = AF_INET; + src = &saddr_in.sin_addr; + } + + p = (char *) inet_ntop(af, src, bind_str, sizeof(bind_str)); + + sprintf(port, ",%u", fio_net_port); + if (p) + strcat(p, port); + else + strcpy(bind_str, port); + } else strcpy(bind_str, bind_sock); log_info("fio: server listening on %s\n", bind_str); @@ -828,72 +1064,129 @@ static int fio_init_server_connection(void) return sk; } +int fio_server_parse_host(const char *host, int *ipv6, struct in_addr *inp, + struct in6_addr *inp6) + +{ + int ret = 0; + + if (*ipv6) + ret = inet_pton(AF_INET6, host, inp6); + else + ret = inet_pton(AF_INET, host, inp); + + if (ret != 1) { + struct hostent *hent; + + hent = gethostbyname(host); + if (!hent) { + log_err("fio: failed to resolve <%s>\n", host); + return 0; + } + + if (*ipv6) { + if (hent->h_addrtype != AF_INET6) { + log_info("fio: falling back to IPv4\n"); + *ipv6 = 0; + } else + memcpy(inp6, hent->h_addr_list[0], 16); + } + if (!*ipv6) { + if (hent->h_addrtype != AF_INET) { + log_err("fio: lookup type mismatch\n"); + return 0; + } + memcpy(inp, hent->h_addr_list[0], 4); + } + ret = 1; + } + + return !(ret == 1); +} + +/* + * Parse a host/ip/port string. Reads from 'str'. + * + * Outputs: + * + * For IPv4: + * *ptr is the host, *port is the port, inp is the destination. + * For IPv6: + * *ptr is the host, *port is the port, inp6 is the dest, and *ipv6 is 1. + * For local domain sockets: + * *ptr is the filename, *is_sock is 1. + */ int fio_server_parse_string(const char *str, char **ptr, int *is_sock, - int *port, struct in_addr *inp) + int *port, struct in_addr *inp, + struct in6_addr *inp6, int *ipv6) { + const char *host = str; + char *portp; + int lport = 0; + *ptr = NULL; *is_sock = 0; *port = fio_net_port; + *ipv6 = 0; if (!strncmp(str, "sock:", 5)) { *ptr = strdup(str + 5); *is_sock = 1; - } else { - const char *host = str; - char *portp; - int lport = 0; - - /* - * Is it ip::port - */ - if (!strncmp(host, "ip:", 3)) - host += 3; - else if (host[0] == ':') { - /* String is :port */ - host++; - lport = atoi(host); + + return 0; + } + + /* + * Is it ip::port + */ + if (!strncmp(host, "ip:", 3)) + host += 3; + else if (!strncmp(host, "ip4:", 4)) + host += 4; + else if (!strncmp(host, "ip6:", 4)) { + host += 4; + *ipv6 = 1; + } else if (host[0] == ':') { + /* String is :port */ + host++; + lport = atoi(host); + if (!lport || lport > 65535) { + log_err("fio: bad server port %u\n", port); + return 1; + } + /* no hostname given, we are done */ + *port = lport; + return 0; + } + + /* + * If no port seen yet, check if there's a last ':' at the end + */ + if (!lport) { + portp = strchr(host, ','); + if (portp) { + *portp = '\0'; + portp++; + lport = atoi(portp); if (!lport || lport > 65535) { log_err("fio: bad server port %u\n", port); return 1; } - /* no hostname given, we are done */ - *port = lport; - return 0; - } - - /* - * If no port seen yet, check if there's a last ':' at the end - */ - if (!lport) { - portp = strchr(host, ':'); - if (portp) { - *portp = '\0'; - portp++; - lport = atoi(portp); - if (!lport || lport > 65535) { - log_err("fio: bad server port %u\n", port); - return 1; - } - } } + } - if (lport) - *port = lport; - - *ptr = strdup(host); + if (lport) + *port = lport; - if (inet_aton(host, inp) != 1) { - struct hostent *hent; + if (!strlen(host)) + return 0; - hent = gethostbyname(host); - if (!hent) { - free(*ptr); - *ptr = NULL; - return 1; - } + *ptr = strdup(host); - memcpy(inp, hent->h_addr, 4); - } + if (fio_server_parse_host(*ptr, ipv6, inp, inp6)) { + free(*ptr); + *ptr = NULL; + return 1; } if (*port == 0) @@ -925,7 +1218,8 @@ static int fio_handle_server_arg(void) goto out; ret = fio_server_parse_string(fio_server_arg, &bind_sock, &is_sock, - &port, &saddr_in.sin_addr); + &port, &saddr_in.sin_addr, + &saddr_in6.sin6_addr, &use_ipv6); if (!is_sock && bind_sock) { free(bind_sock); @@ -935,6 +1229,7 @@ static int fio_handle_server_arg(void) out: fio_net_port = port; saddr_in.sin_port = htons(port); + saddr_in6.sin6_port = htons(port); return ret; } @@ -965,25 +1260,14 @@ static int fio_server(void) return ret; } -static void sig_int(int sig) +void fio_server_got_signal(int signal) { - fio_terminate_threads(TERMINATE_ALL); - exit_backend = 1; -} - -static void server_signal_handler(void) -{ - struct sigaction act; - - memset(&act, 0, sizeof(act)); - act.sa_handler = sig_int; - act.sa_flags = SA_RESTART; - sigaction(SIGINT, &act, NULL); - - memset(&act, 0, sizeof(act)); - act.sa_handler = sig_int; - act.sa_flags = SA_RESTART; - sigaction(SIGTERM, &act, NULL); + if (signal == SIGPIPE) + server_fd = -1; + else { + log_info("\nfio: terminating on signal %d\n", signal); + exit_backend = 1; + } } static int check_existing_pidfile(const char *pidfile) @@ -1008,7 +1292,7 @@ static int check_existing_pidfile(const char *pidfile) pid = atoi(buf); if (kill(pid, SIGCONT) < 0) - return 0; + return errno != ESRCH; return 1; } @@ -1036,7 +1320,10 @@ int fio_start_server(char *pidfile) pid_t pid; int ret; - server_signal_handler(); +#if defined(WIN32) + WSADATA wsd; + WSAStartup(MAKEWORD(2,2), &wsd); +#endif if (!pidfile) return fio_server();