X-Git-Url: https://git.kernel.dk/?p=fio.git;a=blobdiff_plain;f=memory.c;h=d9cfe9bae2c0b35f24ec3e301ef74d459b4d8407;hp=909baf7d51f19b15f1553679eeb5c7d5f9535e7a;hb=c3852ae26bbe6072b2905938bb4fb0f511977cba;hpb=d2324417d8a06b0d0b7c331a0d004155f3a7bd48 diff --git a/memory.c b/memory.c index 909baf7d..d9cfe9ba 100644 --- a/memory.c +++ b/memory.c @@ -69,14 +69,14 @@ int allocate_io_mem(struct thread_data *td) td->shm_id = shmget(IPC_PRIVATE, td->orig_buffer_size, flags); if (td->shm_id < 0) { - td_verror(td, errno); + td_verror(td, errno, "shmget"); perror("shmget"); return 1; } td->orig_buffer = shmat(td->shm_id, NULL, 0); if (td->orig_buffer == (void *) -1) { - td_verror(td, errno); + td_verror(td, errno, "shmat"); perror("shmat"); td->orig_buffer = NULL; return 1; @@ -84,27 +84,29 @@ int allocate_io_mem(struct thread_data *td) } else if (td->mem_type == MEM_MMAP || td->mem_type == MEM_MMAPHUGE) { int flags = MAP_PRIVATE; - td->hugefd = 0; + td->mmapfd = 0; - if (td->mem_type == MEM_MMAPHUGE) { - td->hugefd = open(td->hugefile, O_RDWR|O_CREAT, 0644); + if (td->mmapfile) { + td->mmapfd = open(td->mmapfile, O_RDWR|O_CREAT, 0644); - if (td->hugefd < 0) { - td_verror(td, errno); - perror("open huge file"); + if (td->mmapfd < 0) { + td_verror(td, errno, "open"); + perror("open mmap file"); td->orig_buffer = NULL; return 1; } } else flags |= OS_MAP_ANON; - td->orig_buffer = mmap(NULL, td->orig_buffer_size, PROT_READ | PROT_WRITE, flags, td->hugefd, 0); + td->orig_buffer = mmap(NULL, td->orig_buffer_size, PROT_READ | PROT_WRITE, flags, td->mmapfd, 0); if (td->orig_buffer == MAP_FAILED) { - td_verror(td, errno); + td_verror(td, errno, "mmap"); perror("mmap"); td->orig_buffer = NULL; - if (td->hugefd) - close(td->hugefd); + if (td->mmapfd) { + close(td->mmapfd); + unlink(td->mmapfile); + } return 1; } @@ -124,10 +126,10 @@ void free_io_mem(struct thread_data *td) shmctl(td->shm_id, IPC_RMID, &sbuf); } else if (td->mem_type == MEM_MMAP || td->mem_type == MEM_MMAPHUGE) { munmap(td->orig_buffer, td->orig_buffer_size); - if (td->mem_type == MEM_MMAPHUGE) { - close(td->hugefd); - unlink(td->hugefile); - free(td->hugefile); + if (td->mmapfile) { + close(td->mmapfd); + unlink(td->mmapfile); + free(td->mmapfile); } } else log_err("Bad memory type %u\n", td->mem_type);