X-Git-Url: https://git.kernel.dk/?p=fio.git;a=blobdiff_plain;f=log.c;h=c0e9d4ae61dc8b6b5f7d1890991745979872a7f0;hp=6c7c4d6b2680546663eeac7d179b2e11917b7997;hb=36361ebb75a8f543aa49ff4f3ee49274261da074;hpb=8de8f047bd025f12d23cfc3fc1793434c6d8ff94

diff --git a/log.c b/log.c
index 6c7c4d6b..c0e9d4ae 100644
--- a/log.c
+++ b/log.c
@@ -19,6 +19,11 @@ int read_iolog_get(struct thread_data *td, struct io_u *io_u)
 		io_u->buflen = ipo->len;
 		io_u->ddir = ipo->ddir;
 		io_u->file = ipo->file;
+		/*
+		 * work around, this needs a format change to work for > 1 file
+		 */
+		if (!io_u->file)
+			io_u->file = &td->files[0];
 		free(ipo);
 		return 0;
 	}
@@ -60,7 +65,8 @@ void log_io_piece(struct thread_data *td, struct io_u *io_u)
 	 * For both these cases, just reading back data in the order we
 	 * wrote it out is the fastest.
 	 */
-	if (!td_random(td) || !td->o.overwrite) {
+	if (!td_random(td) || !td->o.overwrite ||
+	     (io_u->file->flags & FIO_FILE_NOSORT)) {
 		INIT_LIST_HEAD(&ipo->list);
 		list_add_tail(&ipo->list, &td->io_hist_list);
 		return;
@@ -134,6 +140,7 @@ static int init_iolog_read(struct thread_data *td)
 		}
 
 		ipo = malloc(sizeof(*ipo));
+		memset(ipo, 0, sizeof(*ipo));
 		INIT_LIST_HEAD(&ipo->list);
 		ipo->offset = offset;
 		ipo->len = bytes;
@@ -151,7 +158,7 @@ static int init_iolog_read(struct thread_data *td)
 	else if (reads && !writes)
 		td->o.td_ddir = TD_DDIR_READ;
 	else if (!reads && writes)
-		td->o.td_ddir = TD_DDIR_READ;
+		td->o.td_ddir = TD_DDIR_WRITE;
 	else
 		td->o.td_ddir = TD_DDIR_RW;
 
@@ -165,6 +172,11 @@ static int init_iolog_write(struct thread_data *td)
 {
 	FILE *f;
 
+	if (td->o.nr_files > 1) {
+		log_err("fio: write_iolog only works with 1 file currently\n");
+		return 1;
+	}
+
 	f = fopen(td->o.write_iolog_file, "w+");
 	if (!f) {
 		perror("fopen write iolog");
@@ -187,9 +199,16 @@ int init_iolog(struct thread_data *td)
 	if (td->io_ops->flags & FIO_DISKLESSIO)
 		return 0;
 
-	if (td->o.read_iolog_file)
-		ret = init_iolog_read(td);
-	else if (td->o.write_iolog_file)
+	if (td->o.read_iolog_file) {
+		/*
+		 * Check if it's a blktrace file and load that if possible.
+		 * Otherwise assume it's a normal log file and load that.
+		 */
+		if (is_blktrace(td->o.read_iolog_file))
+			ret = load_blktrace(td, td->o.read_iolog_file);
+		else
+			ret = init_iolog_read(td);
+	} else if (td->o.write_iolog_file)
 		ret = init_iolog_write(td);
 
 	return ret;