X-Git-Url: https://git.kernel.dk/?p=fio.git;a=blobdiff_plain;f=iolog.c;h=4a7d939af251c77ae2de82d2ad57b15a9f04d4b4;hp=f9265b56dfa3cf83847d108fe0de60d89d5fb9d1;hb=0fc2e103bc78e99f96b88d5aa1f45e0ca704a049;hpb=97eabb2a4edcc237d5203db419728a1c598f061a

diff --git a/iolog.c b/iolog.c
index f9265b56..4a7d939a 100644
--- a/iolog.c
+++ b/iolog.c
@@ -28,19 +28,14 @@ void queue_io_piece(struct thread_data *td, struct io_piece *ipo)
 	td->total_io_size += ipo->len;
 }
 
-void log_io_u(struct thread_data *td, struct io_u *io_u)
+void log_io_u(const struct thread_data *td, const struct io_u *io_u)
 {
-	const char *act[] = { "read", "write", "sync", "datasync",
-				"sync_file_range", "wait", "trim" };
-
-	assert(io_u->ddir <= 6);
-
 	if (!td->o.write_iolog_file)
 		return;
 
 	fprintf(td->iolog_f, "%s %s %llu %lu\n", io_u->file->file_name,
-						act[io_u->ddir], io_u->offset,
-						io_u->buflen);
+						io_ddir_name(io_u->ddir),
+						io_u->offset, io_u->buflen);
 }
 
 void log_file(struct thread_data *td, struct fio_file *f,
@@ -73,12 +68,6 @@ static void iolog_delay(struct thread_data *td, unsigned long delay)
 
 	delay -= usec;
 
-	/*
-	 * less than 100 usec delay, just regard it as noise
-	 */
-	if (delay < 100)
-		return;
-
 	while (delay && !td->terminate) {
 		this_delay = delay;
 		if (this_delay > 500000)
@@ -113,7 +102,7 @@ static int ipo_special(struct thread_data *td, struct io_piece *ipo)
 		td_io_close_file(td, f);
 		break;
 	case FIO_LOG_UNLINK_FILE:
-		unlink(f->file_name);
+		td_io_unlink_file(td, f);
 		break;
 	default:
 		log_err("fio: bad file action %d\n", ipo->file_action);
@@ -131,7 +120,7 @@ int read_iolog_get(struct thread_data *td, struct io_u *io_u)
 	while (!flist_empty(&td->io_log_list)) {
 		int ret;
 
-		ipo = flist_entry(td->io_log_list.next, struct io_piece, list);
+		ipo = flist_first_entry(&td->io_log_list, struct io_piece, list);
 		flist_del(&ipo->list);
 		remove_trim_entry(td, ipo);
 
@@ -184,7 +173,7 @@ void prune_io_piece_log(struct thread_data *td)
 	}
 
 	while (!flist_empty(&td->io_hist_list)) {
-		ipo = flist_entry(td->io_hist_list.next, struct io_piece, list);
+		ipo = flist_entry(&td->io_hist_list, struct io_piece, list);
 		flist_del(&ipo->list);
 		remove_trim_entry(td, ipo);
 		td->io_hist_len--;
@@ -293,7 +282,7 @@ void unlog_io_piece(struct thread_data *td, struct io_u *io_u)
 	td->io_hist_len--;
 }
 
-void trim_io_piece(struct thread_data *td, struct io_u *io_u)
+void trim_io_piece(struct thread_data *td, const struct io_u *io_u)
 {
 	struct io_piece *ipo = io_u->ipo;
 
@@ -550,9 +539,9 @@ int init_iolog(struct thread_data *td)
 void setup_log(struct io_log **log, struct log_params *p,
 	       const char *filename)
 {
-	struct io_log *l = malloc(sizeof(*l));
+	struct io_log *l;
 
-	memset(l, 0, sizeof(*l));
+	l = calloc(1, sizeof(*l));
 	l->nr_samples = 0;
 	l->max_samples = 1024;
 	l->log_type = p->log_type;
@@ -565,7 +554,7 @@ void setup_log(struct io_log **log, struct log_params *p,
 	l->td = p->td;
 
 	if (l->log_offset)
-		l->log_ddir_mask = 0x80000000;
+		l->log_ddir_mask = LOG_OFFSET_SAMPLE_BIT;
 
 	INIT_FLIST_HEAD(&l->chunk_list);
 
@@ -622,10 +611,7 @@ static void flush_samples(FILE *f, void *samples, uint64_t sample_size)
 		return;
 
 	s = __get_sample(samples, 0, 0);
-	if (s->__ddir & 0x80000000)
-		log_offset = 1;
-	else
-		log_offset = 0;
+	log_offset = (s->__ddir & LOG_OFFSET_SAMPLE_BIT) != 0;
 
 	nr_samples = sample_size / __log_entry_sz(log_offset);
 
@@ -663,7 +649,6 @@ struct iolog_compress {
 	void *buf;
 	size_t len;
 	unsigned int seq;
-	int nofree;
 };
 
 #define GZ_CHUNK	131072
@@ -677,16 +662,13 @@ static struct iolog_compress *get_new_chunk(unsigned int seq)
 	c->buf = malloc(GZ_CHUNK);
 	c->len = 0;
 	c->seq = seq;
-	c->nofree = 0;
 	return c;
 }
 
 static void free_chunk(struct iolog_compress *ic)
 {
-	if (!ic->nofree) {
-		free(ic->buf);
-		free(ic);
-	}
+	free(ic->buf);
+	free(ic);
 }
 
 static int z_stream_init(z_stream *stream, int gz_hdr)
@@ -698,6 +680,10 @@ static int z_stream_init(z_stream *stream, int gz_hdr)
 	stream->opaque = Z_NULL;
 	stream->next_in = Z_NULL;
 
+	/*
+	 * zlib magic - add 32 for auto-detection of gz header or not,
+	 * if we decide to store files in a gzip friendly format.
+	 */
 	if (gz_hdr)
 		wbits += 32;
 
@@ -707,8 +693,9 @@ static int z_stream_init(z_stream *stream, int gz_hdr)
 	return 0;
 }
 
-struct flush_chunk_iter {
+struct inflate_chunk_iter {
 	unsigned int seq;
+	int err;
 	void *buf;
 	size_t buf_size;
 	size_t buf_used;
@@ -716,7 +703,7 @@ struct flush_chunk_iter {
 };
 
 static void finish_chunk(z_stream *stream, FILE *f,
-			 struct flush_chunk_iter *iter)
+			 struct inflate_chunk_iter *iter)
 {
 	int ret;
 
@@ -730,9 +717,18 @@ static void finish_chunk(z_stream *stream, FILE *f,
 	iter->buf_size = iter->buf_used = 0;
 }
 
-static int flush_chunk(struct iolog_compress *ic, int gz_hdr, FILE *f,
-		       z_stream *stream, struct flush_chunk_iter *iter)
+/*
+ * Iterative chunk inflation. Handles cases where we cross into a new
+ * sequence, doing flush finish of previous chunk if needed.
+ */
+static size_t inflate_chunk(struct iolog_compress *ic, int gz_hdr, FILE *f,
+			    z_stream *stream, struct inflate_chunk_iter *iter)
 {
+	size_t ret;
+
+	dprint(FD_COMPRESS, "inflate chunk size=%lu, seq=%u",
+				(unsigned long) ic->len, ic->seq);
+
 	if (ic->seq != iter->seq) {
 		if (iter->seq)
 			finish_chunk(stream, f, iter);
@@ -759,6 +755,7 @@ static int flush_chunk(struct iolog_compress *ic, int gz_hdr, FILE *f,
 		err = inflate(stream, Z_NO_FLUSH);
 		if (err < 0) {
 			log_err("fio: failed inflating log: %d\n", err);
+			iter->err = err;
 			break;
 		}
 
@@ -774,43 +771,67 @@ static int flush_chunk(struct iolog_compress *ic, int gz_hdr, FILE *f,
 			break;
 	}
 
-	free_chunk(ic);
-	return 0;
+	ret = (void *) stream->next_in - ic->buf;
+
+	dprint(FD_COMPRESS, "inflated to size=%lu\n", (unsigned long) ret);
+
+	return ret;
 }
 
-static void flush_gz_chunks(struct io_log *log, FILE *f)
+/*
+ * Inflate stored compressed chunks, or write them directly to the log
+ * file if so instructed.
+ */
+static int inflate_gz_chunks(struct io_log *log, FILE *f)
 {
-	struct flush_chunk_iter iter = { .chunk_sz = log->log_gz, };
-	struct flist_head *node;
+	struct inflate_chunk_iter iter = { .chunk_sz = log->log_gz, };
 	z_stream stream;
 
 	while (!flist_empty(&log->chunk_list)) {
 		struct iolog_compress *ic;
 
-		node = log->chunk_list.next;
-		ic = flist_entry(node, struct iolog_compress, list);
+		ic = flist_first_entry(&log->chunk_list, struct iolog_compress, list);
 		flist_del(&ic->list);
 
 		if (log->log_gz_store) {
-			fwrite(ic->buf, ic->len, 1, f);
-			free_chunk(ic);
+			size_t ret;
+
+			dprint(FD_COMPRESS, "log write chunk size=%lu, "
+				"seq=%u\n", (unsigned long) ic->len, ic->seq);
+
+			ret = fwrite(ic->buf, ic->len, 1, f);
+			if (ret != 1 || ferror(f)) {
+				iter.err = errno;
+				log_err("fio: error writing compressed log\n");
+			}
 		} else
-			flush_chunk(ic, log->log_gz_store, f, &stream, &iter);
+			inflate_chunk(ic, log->log_gz_store, f, &stream, &iter);
+
+		free_chunk(ic);
 	}
 
 	if (iter.seq) {
 		finish_chunk(&stream, f, &iter);
 		free(iter.buf);
 	}
+
+	return iter.err;
 }
 
+/*
+ * Open compressed log file and decompress the stored chunks and
+ * write them to stdout. The chunks are stored sequentially in the
+ * file, so we iterate over them and do them one-by-one.
+ */
 int iolog_file_inflate(const char *file)
 {
-	struct flush_chunk_iter iter = { .chunk_sz = 64 * 1024 * 1024, };
+	struct inflate_chunk_iter iter = { .chunk_sz = 64 * 1024 * 1024, };
 	struct iolog_compress ic;
 	z_stream stream;
 	struct stat sb;
 	ssize_t ret;
+	size_t total;
+	void *buf;
 	FILE *f;
 
 	f = fopen(file, "r");
@@ -825,9 +846,8 @@ int iolog_file_inflate(const char *file)
 		return 1;
 	}
 
-	ic.buf = malloc(sb.st_size);
+	ic.buf = buf = malloc(sb.st_size);
 	ic.len = sb.st_size;
-	ic.nofree = 1;
 	ic.seq = 1;
 
 	ret = fread(ic.buf, ic.len, 1, f);
@@ -843,21 +863,48 @@ int iolog_file_inflate(const char *file)
 
 	fclose(f);
 
-	flush_chunk(&ic,  1, stdout, &stream, &iter);
+	/*
+	 * Each chunk will return Z_STREAM_END. We don't know how many
+	 * chunks are in the file, so we just keep looping and incrementing
+	 * the sequence number until we have consumed the whole compressed
+	 * file.
+	 */
+	total = ic.len;
+	do {
+		size_t ret;
+
+		ret = inflate_chunk(&ic,  1, stdout, &stream, &iter);
+		total -= ret;
+		if (!total)
+			break;
+		if (iter.err)
+			break;
+
+		ic.seq++;
+		ic.len -= ret;
+		ic.buf += ret;
+	} while (1);
 
 	if (iter.seq) {
 		finish_chunk(&stream, stdout, &iter);
 		free(iter.buf);
 	}
 
-	free(ic.buf);
-	return 0;
+	free(buf);
+	return iter.err;
 }
 
 #else
 
-static void flush_gz_chunks(struct io_log *log, FILE *f)
+static int inflate_gz_chunks(struct io_log *log, FILE *f)
+{
+	return 0;
+}
+
+int iolog_file_inflate(const char *file)
 {
+	log_err("fio: log inflation not possible without zlib\n");
+	return 1;
 }
 
 #endif
@@ -875,7 +922,7 @@ void flush_log(struct io_log *log)
 
 	buf = set_file_buffer(f);
 
-	flush_gz_chunks(log, f);
+	inflate_gz_chunks(log, f);
 
 	flush_samples(f, log->log, log->nr_samples * log_entry_sz(log));
 
@@ -906,6 +953,11 @@ static int finish_log(struct thread_data *td, struct io_log *log, int trylock)
 
 #ifdef CONFIG_ZLIB
 
+/*
+ * Invoked from our compress helper thread, when logging would have exceeded
+ * the specified memory limitation. Compresses the previously stored
+ * entries.
+ */
 static int gz_work(struct tp_work *work)
 {
 	struct iolog_flush_data *data;
@@ -935,6 +987,8 @@ static int gz_work(struct tp_work *work)
 	stream.next_in = (void *) data->samples;
 	stream.avail_in = data->nr_samples * log_entry_sz(data->log);
 
+	dprint(FD_COMPRESS, "deflate input size=%lu, seq=%u\n",
+				(unsigned long) stream.avail_in, seq);
 	do {
 		c = get_new_chunk(seq);
 		stream.avail_out = GZ_CHUNK;
@@ -942,7 +996,8 @@ static int gz_work(struct tp_work *work)
 		ret = deflate(&stream, Z_NO_FLUSH);
 		if (ret < 0) {
 			log_err("fio: deflate log (%d)\n", ret);
-			break;
+			free_chunk(c);
+			goto err;
 		}
 
 		c->len = GZ_CHUNK - stream.avail_out;
@@ -963,10 +1018,13 @@ static int gz_work(struct tp_work *work)
 			stream.next_out = c->buf;
 			ret = deflate(&stream, Z_FINISH);
 			c->len = GZ_CHUNK - stream.avail_out;
+			total += c->len;
 			flist_add_tail(&c->list, &list);
 		} while (ret != Z_STREAM_END);
 	}
 
+	dprint(FD_COMPRESS, "deflated to size=%lu\n", (unsigned long) total);
+
 	ret = deflateEnd(&stream);
 	if (ret != Z_OK)
 		log_err("fio: deflateEnd %d\n", ret);
@@ -979,15 +1037,31 @@ static int gz_work(struct tp_work *work)
 		pthread_mutex_unlock(&data->log->chunk_lock);
 	}
 
+	ret = 0;
+done:
 	if (work->wait) {
 		work->done = 1;
 		pthread_cond_signal(&work->cv);
 	} else
 		free(data);
 
-	return 0;
+	return ret;
+err:
+	while (!flist_empty(&list)) {
+		c = flist_first_entry(list.next, struct iolog_compress, list);
+		flist_del(&c->list);
+		free_chunk(c);
+	}
+	ret = 1;
+	goto done;
 }
 
+/*
+ * Queue work item to compress the existing log entries. We copy the
+ * samples, and reset the log sample count to 0 (so the logging will
+ * continue to use the memory associated with the log). If called with
+ * wait == 1, will not return until the log compression has completed.
+ */
 int iolog_flush(struct io_log *log, int wait)
 {
 	struct tp_data *tdat = log->td->tp_data;
@@ -1019,6 +1093,7 @@ int iolog_flush(struct io_log *log, int wait)
 	} else
 		data->work.wait = 0;
 
+	data->work.prio = 1;
 	tp_queue_work(tdat, &data->work);
 
 	if (wait) {