X-Git-Url: https://git.kernel.dk/?p=fio.git;a=blobdiff_plain;f=io_u.c;h=c78865636b1f52f159bf8ef7d6846deb5fec5ef1;hp=6df4b5eee80190187aa0015b11aca7da73e714b4;hb=b486f76ad31b593caded74f42468ea9adbdc21a7;hpb=7c83c089a9b8bd742f788157ac47a5af363adb19

diff --git a/io_u.c b/io_u.c
index 6df4b5ee..c7886563 100644
--- a/io_u.c
+++ b/io_u.c
@@ -111,7 +111,10 @@ static int get_next_offset(struct thread_data *td, struct io_u *io_u)
 
 		do {
 			r = os_random_long(&td->random_state);
-			b = ((max_blocks - 1) * r / (unsigned long long) (RAND_MAX+1.0));
+			if (!max_blocks)
+				b = 0;
+			else
+				b = ((max_blocks - 1) * r / (unsigned long long) (RAND_MAX+1.0));
 			if (td->norandommap)
 				break;
 			rb = b + (f->file_offset / td->min_bs[ddir]);
@@ -151,8 +154,14 @@ static unsigned int get_next_buflen(struct thread_data *td, struct io_u *io_u)
 	}
 
 	while (buflen + io_u->offset > f->real_file_size) {
-		if (buflen == td->min_bs[ddir])
+		if (buflen == td->min_bs[ddir]) {
+			if (!td->odirect) {
+				assert(io_u->offset <= f->real_file_size);
+				buflen = f->real_file_size - io_u->offset;
+				return buflen;
+			}
 			return 0;
+		}
 
 		buflen = td->min_bs[ddir];
 	}
@@ -265,10 +274,13 @@ static int fill_io_u(struct thread_data *td, struct io_u *io_u)
 	return 0;
 }
 
-static void io_u_mark_depth(struct thread_data *td)
+void io_u_mark_depth(struct thread_data *td, struct io_u *io_u)
 {
 	int index = 0;
 
+	if (io_u->ddir == DDIR_SYNC)
+		return;
+
 	switch (td->cur_depth) {
 	default:
 		index++;
@@ -286,8 +298,8 @@ static void io_u_mark_depth(struct thread_data *td)
 		break;
 	}
 
-	td->io_u_map[index]++;
-	td->total_io_u++;
+	td->ts.io_u_map[index]++;
+	td->ts.total_io_u[io_u->ddir]++;
 }
 
 static void io_u_mark_latency(struct thread_data *td, unsigned long msec)
@@ -321,23 +333,25 @@ static void io_u_mark_latency(struct thread_data *td, unsigned long msec)
 		break;
 	}
 
-	td->io_u_lat[index]++;
+	td->ts.io_u_lat[index]++;
 }
 
 /*
  * Get next file to service by choosing one at random
  */
-static struct fio_file *get_next_file_rand(struct thread_data *td)
+static struct fio_file *get_next_file_rand(struct thread_data *td, int goodf,
+					   int badf)
 {
-	unsigned int fileno;
 	struct fio_file *f;
+	int fno;
 
 	do {
 		long r = os_random_long(&td->next_file_state);
 
-		fileno = (unsigned int) ((double) (td->nr_files - 1) * r / (RAND_MAX + 1.0));
-		f = &td->files[fileno];
-		if (f->fd != -1)
+		fno = (unsigned int) ((double) td->nr_files * (r / (RAND_MAX + 1.0)));
+		f = &td->files[fno];
+
+		if ((!goodf || (f->flags & goodf)) && !(f->flags & badf))
 			return f;
 	} while (1);
 }
@@ -345,7 +359,8 @@ static struct fio_file *get_next_file_rand(struct thread_data *td)
 /*
  * Get next file to service by doing round robin between all available ones
  */
-static struct fio_file *get_next_file_rr(struct thread_data *td)
+static struct fio_file *get_next_file_rr(struct thread_data *td, int goodf,
+					 int badf)
 {
 	unsigned int old_next_file = td->next_file;
 	struct fio_file *f;
@@ -357,7 +372,7 @@ static struct fio_file *get_next_file_rr(struct thread_data *td)
 		if (td->next_file >= td->nr_files)
 			td->next_file = 0;
 
-		if (f->fd != -1)
+		if ((!goodf || (f->flags & goodf)) && !(f->flags & badf))
 			break;
 
 		f = NULL;
@@ -368,13 +383,37 @@ static struct fio_file *get_next_file_rr(struct thread_data *td)
 
 static struct fio_file *get_next_file(struct thread_data *td)
 {
+	struct fio_file *f;
+
+	assert(td->nr_files <= td->files_index);
+
 	if (!td->nr_open_files)
 		return NULL;
 
+	f = td->file_service_file;
+	if (f && (f->flags & FIO_FILE_OPEN) && td->file_service_left--)
+		return f;
+
 	if (td->file_service_type == FIO_FSERVICE_RR)
-		return get_next_file_rr(td);
+		f = get_next_file_rr(td, FIO_FILE_OPEN, FIO_FILE_CLOSING);
 	else
-		return get_next_file_rand(td);
+		f = get_next_file_rand(td, FIO_FILE_OPEN, FIO_FILE_CLOSING);
+
+	td->file_service_file = f;
+	td->file_service_left = td->file_service_nr - 1;
+	return f;
+}
+
+static struct fio_file *find_next_new_file(struct thread_data *td)
+{
+	struct fio_file *f;
+
+	if (td->file_service_type == FIO_FSERVICE_RR)
+		f = get_next_file_rr(td, 0, FIO_FILE_OPEN);
+	else
+		f = get_next_file_rand(td, 0, FIO_FILE_OPEN);
+
+	return f;
 }
 
 struct io_u *__get_io_u(struct thread_data *td)
@@ -400,7 +439,6 @@ struct io_u *__get_io_u(struct thread_data *td)
 		list_del(&io_u->list);
 		list_add(&io_u->list, &td->io_u_busylist);
 		td->cur_depth++;
-		io_u_mark_depth(td);
 	}
 
 	return io_u;
@@ -414,6 +452,7 @@ struct io_u *get_io_u(struct thread_data *td)
 {
 	struct fio_file *f;
 	struct io_u *io_u;
+	int ret;
 
 	io_u = __get_io_u(td);
 	if (!io_u)
@@ -432,6 +471,7 @@ struct io_u *get_io_u(struct thread_data *td)
 			return NULL;
 		}
 
+set_file:
 		io_u->file = f;
 
 		if (!fill_io_u(td, io_u))
@@ -441,7 +481,22 @@ struct io_u *get_io_u(struct thread_data *td)
 		 * No more to do for this file, close it
 		 */
 		io_u->file = NULL;
-		close_file(td, f);
+		td_io_close_file(td, f);
+
+		/*
+		 * probably not the right place to do this, but see
+		 * if we need to open a new file
+		 */
+		if (td->nr_open_files < td->open_files &&
+		    td->open_files != td->nr_files) {
+			f = find_next_new_file(td);
+
+			if (!f || (ret = td_io_open_file(td, f))) {
+				put_io_u(td, io_u);
+				return NULL;
+			}
+			goto set_file;
+		}
 	} while (1);
 
 	if (td->zone_bytes >= td->zone_size) {
@@ -486,6 +541,23 @@ out:
 	return io_u;
 }
 
+void io_u_log_error(struct thread_data *td, struct io_u *io_u)
+{
+	const char *msg[] = { "read", "write", "sync" };
+
+	log_err("fio: io_u error");
+
+	if (io_u->file)
+		log_err(" on file %s", io_u->file->file_name);
+
+	log_err(": %s\n", strerror(io_u->error));
+
+	log_err("     %s offset=%llu, buflen=%lu\n", msg[io_u->ddir], io_u->offset, io_u->xfer_buflen);
+
+	if (!td->error)
+		td_verror(td, io_u->error, "io_u error");
+}
+
 static void io_completed(struct thread_data *td, struct io_u *io_u,
 			 struct io_completion_data *icd)
 {
@@ -494,6 +566,8 @@ static void io_completed(struct thread_data *td, struct io_u *io_u,
 	assert(io_u->flags & IO_U_F_FLIGHT);
 	io_u->flags &= ~IO_U_F_FLIGHT;
 
+	put_file(td, io_u->file);
+
 	if (io_u->ddir == DDIR_SYNC) {
 		td->last_was_sync = 1;
 		return;
@@ -529,8 +603,10 @@ static void io_completed(struct thread_data *td, struct io_u *io_u,
 			if (ret && !icd->error)
 				icd->error = ret;
 		}
-	} else
+	} else {
 		icd->error = io_u->error;
+		io_u_log_error(td, io_u);
+	}
 }
 
 static void init_icd(struct io_completion_data *icd, int nr)
@@ -571,6 +647,7 @@ long io_u_sync_complete(struct thread_data *td, struct io_u *io_u)
 	if (!icd.error)
 		return icd.bytes_done[0] + icd.bytes_done[1];
 
+	td_verror(td, icd.error, "io_u_sync_complete");
 	return -1;
 }
 
@@ -601,6 +678,7 @@ long io_u_queued_complete(struct thread_data *td, int min_events)
 	if (!icd.error)
 		return icd.bytes_done[0] + icd.bytes_done[1];
 
+	td_verror(td, icd.error, "io_u_queued_complete");
 	return -1;
 }