X-Git-Url: https://git.kernel.dk/?p=fio.git;a=blobdiff_plain;f=fio.c;h=cc65e3d0cf197ec46b978283b4c754d4cdf5f396;hp=43cc6af14e8ab632f731ae4106fce2b4e27ce5e7;hb=cf3d609747c3e070001173b17ea95e9d6f46b15c;hpb=b5af82930ccfd7dda6a1b11794efb452eb76d8dc

diff --git a/fio.c b/fio.c
index 43cc6af1..cc65e3d0 100644
--- a/fio.c
+++ b/fio.c
@@ -46,7 +46,7 @@ int thread_number = 0;
 int shm_id = 0;
 int temp_stall_ts;
 
-static volatile int startup_sem;
+static struct fio_sem *startup_sem;
 static volatile int fio_abort;
 static int exit_value;
 
@@ -361,31 +361,6 @@ static void do_verify(struct thread_data *td)
 	td_set_runstate(td, TD_RUNNING);
 }
 
-/*
- * Not really an io thread, all it does is burn CPU cycles in the specified
- * manner.
- */
-static void do_cpuio(struct thread_data *td)
-{
-	struct timeval e;
-	int split = 100 / td->cpuload;
-	int i = 0;
-
-	while (!td->terminate) {
-		fio_gettime(&e, NULL);
-
-		if (runtime_exceeded(td, &e))
-			break;
-
-		if (!(i % split))
-			__usec_sleep(10000);
-		else
-			usec_sleep(td, 10000);
-
-		i++;
-	}
-}
-
 /*
  * Main IO worker function. It retrieves io_u's to process and queues
  * and reaps them, checking for rate and errors along the way.
@@ -566,9 +541,6 @@ static int init_io_u(struct thread_data *td)
 	int i, max_units;
 	char *p;
 
-	if (td->io_ops->flags & FIO_CPUIO)
-		return 0;
-
 	if (td->io_ops->flags & FIO_SYNCIO)
 		max_units = 1;
 	else
@@ -611,7 +583,7 @@ static int switch_ioscheduler(struct thread_data *td)
 	FILE *f;
 	int ret;
 
-	if (td->io_ops->flags & FIO_CPUIO)
+	if (td->io_ops->flags & FIO_DISKLESSIO)
 		return 0;
 
 	sprintf(tmp, "%s/queue/scheduler", td->sysfs_root);
@@ -656,27 +628,29 @@ static int switch_ioscheduler(struct thread_data *td)
 	return 0;
 }
 
-static void clear_io_state(struct thread_data *td)
+static int clear_io_state(struct thread_data *td)
 {
 	struct fio_file *f;
-	int i;
+	int i, ret;
 
 	td->ts.stat_io_bytes[0] = td->ts.stat_io_bytes[1] = 0;
 	td->this_io_bytes[0] = td->this_io_bytes[1] = 0;
 	td->zone_bytes = 0;
+	td->rate_bytes = 0;
 
 	td->last_was_sync = 0;
 
-	for_each_file(td, f, i) {
-		f->last_completed_pos = 0;
-
-		f->last_pos = 0;
-		if (td->io_ops->flags & FIO_SYNCIO)
-			lseek(f->fd, SEEK_SET, 0);
+	for_each_file(td, f, i)
+		td_io_close_file(td, f);
 
-		if (f->file_map)
-			memset(f->file_map, 0, f->num_maps * sizeof(long));
+	ret = 0;
+	for_each_file(td, f, i) {
+		ret = td_io_open_file(td, f);
+		if (ret)
+			break;
 	}
+
+	return ret;
 }
 
 /*
@@ -687,6 +661,7 @@ static void *thread_main(void *data)
 {
 	unsigned long long runtime[2];
 	struct thread_data *td = data;
+	int clear_state;
 
 	if (!td->use_thread)
 		setsid();
@@ -729,8 +704,14 @@ static void *thread_main(void *data)
 		goto err;
 
 	td_set_runstate(td, TD_INITIALIZED);
-	fio_sem_up(&startup_sem);
-	fio_sem_down(&td->mutex);
+	fio_sem_up(startup_sem);
+	fio_sem_down(td->mutex);
+
+	/*
+	 * the ->mutex semaphore is now no longer used, close it to avoid
+	 * eating a file descriptor
+	 */
+	fio_sem_remove(td->mutex);
 
 	if (!td->create_serialize && setup_files(td))
 		goto err;
@@ -751,6 +732,7 @@ static void *thread_main(void *data)
 	getrusage(RUSAGE_SELF, &td->ts.ru_start);
 
 	runtime[0] = runtime[1] = 0;
+	clear_state = 0;
 	while (td->loops--) {
 		fio_gettime(&td->start, NULL);
 		memcpy(&td->ts.stat_sample_time, &td->start, sizeof(td->start));
@@ -758,13 +740,14 @@ static void *thread_main(void *data)
 		if (td->ratemin)
 			memcpy(&td->lastrate, &td->ts.stat_sample_time, sizeof(td->lastrate));
 
-		clear_io_state(td);
+		if (clear_state && clear_io_state(td))
+			break;
+
 		prune_io_piece_log(td);
 
-		if (td->io_ops->flags & FIO_CPUIO)
-			do_cpuio(td);
-		else
-			do_io(td);
+		do_io(td);
+
+		clear_state = 1;
 
 		if (td_read(td) && td->io_bytes[DDIR_READ])
 			runtime[DDIR_READ] += utime_since_now(&td->start);
@@ -777,7 +760,9 @@ static void *thread_main(void *data)
 		if (td->verify == VERIFY_NONE)
 			continue;
 
-		clear_io_state(td);
+		if (clear_io_state(td))
+			break;
+
 		fio_gettime(&td->start, NULL);
 
 		do_verify(td);
@@ -863,7 +848,7 @@ static void reap_threads(int *nr_running, int *t_rate, int *m_rate)
 		 * ->io_ops is NULL for a thread that has closed its
 		 * io engine
 		 */
-		if (td->io_ops && td->io_ops->flags & FIO_CPUIO)
+		if (td->io_ops && !strcmp(td->io_ops->name, "cpuio"))
 			cputhreads++;
 
 		if (!td->pid || td->runstate == TD_REAPED)
@@ -1021,7 +1006,6 @@ static void run_threads(void)
 			 */
 			td_set_runstate(td, TD_CREATED);
 			map[this_jobs++] = td;
-			fio_sem_init(&startup_sem, 1);
 			nr_started++;
 
 			if (td->use_thread) {
@@ -1030,14 +1014,13 @@ static void run_threads(void)
 					nr_started--;
 				}
 			} else {
-				if (fork())
-					fio_sem_down(&startup_sem);
-				else {
+				if (!fork()) {
 					int ret = fork_main(shm_id, i);
 
 					exit(ret);
 				}
 			}
+			fio_sem_down(startup_sem);
 		}
 
 		/*
@@ -1092,7 +1075,7 @@ static void run_threads(void)
 			m_rate += td->ratemin;
 			t_rate += td->rate;
 			todo--;
-			fio_sem_up(&td->mutex);
+			fio_sem_up(td->mutex);
 		}
 
 		reap_threads(&nr_running, &t_rate, &m_rate);
@@ -1142,6 +1125,8 @@ int main(int argc, char *argv[])
 		setup_log(&agg_io_log[DDIR_WRITE]);
 	}
 
+	startup_sem = fio_sem_init(0);
+
 	set_genesis_time();
 
 	disk_util_timer_arm();
@@ -1156,5 +1141,6 @@ int main(int argc, char *argv[])
 		}
 	}
 
+	fio_sem_remove(startup_sem);
 	return exit_value;
 }