X-Git-Url: https://git.kernel.dk/?p=fio.git;a=blobdiff_plain;f=filesetup.c;h=9d3e06268fffc35786749ea0eb482d0f9bb7ce11;hp=e7f5f1f39847f3865caa3599dea6c98b02a74ffd;hb=b0ff22d7b23118b6c7dc56f2256ce6dde634422a;hpb=8055e41d0ecc54770a2653427532b3e2c5fabdad diff --git a/filesetup.c b/filesetup.c index e7f5f1f3..9d3e0626 100644 --- a/filesetup.c +++ b/filesetup.c @@ -13,7 +13,7 @@ #include "filehash.h" #include "os/os.h" #include "hash.h" -#include "lib/bitmap.h" +#include "lib/axmap.h" #ifdef FIO_HAVE_LINUX_FALLOCATE #include @@ -434,6 +434,12 @@ int generic_close_file(struct thread_data fio_unused *td, struct fio_file *f) ret = errno; f->fd = -1; + + if (f->shadow_fd != -1) { + close(f->shadow_fd); + f->shadow_fd = -1; + } + return ret; } @@ -462,6 +468,24 @@ int file_lookup_open(struct fio_file *f, int flags) return from_hash; } +static int file_close_shadow_fds(struct thread_data *td) +{ + struct fio_file *f; + int num_closed = 0; + unsigned int i; + + for_each_file(td, f, i) { + if (f->shadow_fd == -1) + continue; + + close(f->shadow_fd); + f->shadow_fd = -1; + num_closed++; + } + + return num_closed; +} + int generic_open_file(struct thread_data *td, struct fio_file *f) { int is_std = 0; @@ -536,6 +560,8 @@ open_again: flags &= ~FIO_O_NOATIME; goto open_again; } + if (__e == EMFILE && file_close_shadow_fds(td)) + goto open_again; snprintf(buf, sizeof(buf) - 1, "open(%s)", f->file_name); @@ -552,9 +578,22 @@ open_again: int fio_unused ret; /* - * OK to ignore, we haven't done anything with it + * Stash away descriptor for later close. This is to + * work-around a "feature" on Linux, where a close of + * an fd that has been opened for write will trigger + * udev to call blkid to check partitions, fs id, etc. + * That polutes the device cache, which can slow down + * unbuffered accesses. */ - ret = generic_close_file(td, f); + if (f->shadow_fd == -1) + f->shadow_fd = f->fd; + else { + /* + * OK to ignore, we haven't done anything + * with it + */ + ret = generic_close_file(td, f); + } goto open_again; } } @@ -911,20 +950,25 @@ int init_random_map(struct thread_data *td) if (init_rand_distribution(td)) return 0; - if (td->o.norandommap || !td_random(td)) + if (!td_random(td)) return 0; for_each_file(td, f, i) { blocks = (f->real_file_size + td->o.rw_min_bs - 1) / (unsigned long long) td->o.rw_min_bs; if (td->o.random_generator == FIO_RAND_GEN_LFSR) { - if (!lfsr_init(&f->lfsr, blocks)) + unsigned long seed; + + seed = td->rand_seeds[FIO_RAND_BLOCK_OFF]; + + if (!lfsr_init(&f->lfsr, blocks, seed)) continue; - } else { - f->io_bitmap = bitmap_new(blocks); - if (f->io_bitmap) + } else if (!td->o.norandommap) { + f->io_axmap = axmap_new(blocks); + if (f->io_axmap) continue; - } + } else if (td->o.norandommap) + continue; if (!td->o.softrandommap) { log_err("fio: failed allocating random map. If running" @@ -972,8 +1016,8 @@ void close_and_free_files(struct thread_data *td) sfree(f->file_name); f->file_name = NULL; - bitmap_free(f->io_bitmap); - f->io_bitmap = NULL; + axmap_free(f->io_axmap); + f->io_axmap = NULL; sfree(f); } @@ -1024,6 +1068,7 @@ int add_file(struct thread_data *td, const char *fname) } f->fd = -1; + f->shadow_fd = -1; fio_file_reset(f); if (td->files_size <= td->files_index) {