X-Git-Url: https://git.kernel.dk/?p=fio.git;a=blobdiff_plain;f=eta.c;h=e458457a902f4df3fc3e6642c402abf6148c7016;hp=850a78477771e515600da94a7b0e4872bcc5c88c;hb=60f840a8426f8a9c72063929035e8f15100c54cd;hpb=595d9e77cdbf24fa5252e7723da66f4a2cd65916 diff --git a/eta.c b/eta.c index 850a7847..e458457a 100644 --- a/eta.c +++ b/eta.c @@ -6,19 +6,20 @@ #include #include "fio.h" +#include "lib/pow2.h" static char __run_str[REAL_MAX_JOBS + 1]; static char run_str[__THREAD_RUNSTR_SZ(REAL_MAX_JOBS)]; -static void update_condensed_str(char *run_str, char *run_str_condensed) +static void update_condensed_str(char *rstr, char *run_str_condensed) { - if (*run_str) { - while (*run_str) { + if (*rstr) { + while (*rstr) { int nr = 1; - *run_str_condensed++ = *run_str++; - while (*(run_str - 1) == *run_str) { - run_str++; + *run_str_condensed++ = *rstr++; + while (*(rstr - 1) == *rstr) { + rstr++; nr++; } run_str_condensed += sprintf(run_str_condensed, "(%u),", nr); @@ -234,11 +235,11 @@ static int thread_eta(struct thread_data *td) * if given, otherwise assume it'll run at the specified rate. */ if (td->o.timeout) { - uint64_t timeout = td->o.timeout; + uint64_t __timeout = td->o.timeout; uint64_t start_delay = td->o.start_delay; uint64_t ramp_time = td->o.ramp_time; - t_eta = timeout + start_delay + ramp_time; + t_eta = __timeout + start_delay + ramp_time; t_eta /= 1000000ULL; if (in_ramp_time(td)) { @@ -392,10 +393,9 @@ int calc_thread_status(struct jobs_eta *je, int force) } else if (td->runstate == TD_RAMP) { je->nr_running++; je->nr_ramp++; - } else if (td->runstate == TD_SETTING_UP) { - je->nr_running++; + } else if (td->runstate == TD_SETTING_UP) je->nr_setting_up++; - } else if (td->runstate < TD_RUNNING) + else if (td->runstate < TD_RUNNING) je->nr_pending++; if (je->elapsed_sec >= 3) @@ -556,8 +556,7 @@ void display_thread_status(struct jobs_eta *je) if (!eta_new_line_init) { fio_gettime(&disp_eta_new_line, NULL); eta_new_line_init = 1; - } else if (eta_new_line && - mtime_since_now(&disp_eta_new_line) > eta_new_line * 1000) { + } else if (eta_new_line && mtime_since_now(&disp_eta_new_line) > eta_new_line) { fio_gettime(&disp_eta_new_line, NULL); eta_new_line_pending = 1; } @@ -574,13 +573,16 @@ struct jobs_eta *get_jobs_eta(int force, size_t *size) *size = sizeof(*je) + THREAD_RUNSTR_SZ; je = malloc(*size); + if (!je) + return NULL; memset(je, 0, *size); - if (!calc_thread_status(je, 0)) { + if (!calc_thread_status(je, force)) { free(je); return NULL; } + *size = sizeof(*je) + strlen((char *) je->run_str) + 1; return je; }