X-Git-Url: https://git.kernel.dk/?p=fio.git;a=blobdiff_plain;f=engines%2Fposixaio.c;h=4ac019578a7f8114a254ce425e8a4e76b74211cd;hp=1858e5202457eecd4c707cff7fd78f35bf1dfc34;hb=02ae7bd8339435c982f134ca63ee9062c1d92b8e;hpb=f832642400a7d0f19f21b744d1b1c7dad452408a diff --git a/engines/posixaio.c b/engines/posixaio.c index 1858e520..4ac01957 100644 --- a/engines/posixaio.c +++ b/engines/posixaio.c @@ -91,15 +91,16 @@ static int fio_posixaio_prep(struct thread_data fio_unused *td, #define SUSPEND_ENTRIES 8 static int fio_posixaio_getevents(struct thread_data *td, unsigned int min, - unsigned int max, struct timespec *t) + unsigned int max, const struct timespec *t) { - struct posixaio_data *pd = td->io_ops->data; + struct posixaio_data *pd = td->io_ops_data; os_aiocb_t *suspend_list[SUSPEND_ENTRIES]; - struct flist_head *entry; struct timespec start; int have_timeout = 0; int suspend_entries; + struct io_u *io_u; unsigned int r; + int i; if (t && !fill_timespec(&start)) have_timeout = 1; @@ -108,13 +109,12 @@ static int fio_posixaio_getevents(struct thread_data *td, unsigned int min, r = 0; restart: - memset(suspend_list, 0, sizeof(*suspend_list)); + memset(suspend_list, 0, sizeof(suspend_list)); suspend_entries = 0; - flist_for_each(entry, &td->io_u_busylist) { - struct io_u *io_u = flist_entry(entry, struct io_u, list); + io_u_qiter(&td->io_u_all, io_u, i) { int err; - if (io_u->seen) + if (io_u->seen || !(io_u->flags & IO_U_F_FLIGHT)) continue; err = aio_error(&io_u->aiocb); @@ -161,15 +161,15 @@ restart: static struct io_u *fio_posixaio_event(struct thread_data *td, int event) { - struct posixaio_data *pd = td->io_ops->data; + struct posixaio_data *pd = td->io_ops_data; return pd->aio_events[event]; } -static int fio_posixaio_queue(struct thread_data *td, - struct io_u *io_u) +static enum fio_q_status fio_posixaio_queue(struct thread_data *td, + struct io_u *io_u) { - struct posixaio_data *pd = td->io_ops->data; + struct posixaio_data *pd = td->io_ops_data; os_aiocb_t *aiocb = &io_u->aiocb; int ret; @@ -196,18 +196,20 @@ static int fio_posixaio_queue(struct thread_data *td, return FIO_Q_COMPLETED; #endif } - + if (ret) { + int aio_err = errno; + /* * At least OSX has a very low limit on the number of pending * IOs, so if it returns EAGAIN, we are out of resources * to queue more. Just return FIO_Q_BUSY to naturally * drop off at this depth. */ - if (errno == EAGAIN) + if (aio_err == EAGAIN) return FIO_Q_BUSY; - io_u->error = errno; + io_u->error = aio_err; td_verror(td, io_u->error, "xfer"); return FIO_Q_COMPLETED; } @@ -218,7 +220,7 @@ static int fio_posixaio_queue(struct thread_data *td, static void fio_posixaio_cleanup(struct thread_data *td) { - struct posixaio_data *pd = td->io_ops->data; + struct posixaio_data *pd = td->io_ops_data; if (pd) { free(pd->aio_events); @@ -234,7 +236,7 @@ static int fio_posixaio_init(struct thread_data *td) pd->aio_events = malloc(td->o.iodepth * sizeof(struct io_u *)); memset(pd->aio_events, 0, td->o.iodepth * sizeof(struct io_u *)); - td->io_ops->data = pd; + td->io_ops_data = pd; return 0; }