X-Git-Url: https://git.kernel.dk/?p=fio.git;a=blobdiff_plain;f=client.c;h=f2c157ae7525a030f6b23c7e9ad15b4032ad5c8d;hp=7f035c7d7804e764e1557c1fee1af1641d971038;hb=85dd01e7d7fa9989bf55002bc416c4d8118fdf5f;hpb=38fdef226f1a1fa053ab53005abbc184143bff65 diff --git a/client.c b/client.c index 7f035c7d..f2c157ae 100644 --- a/client.c +++ b/client.c @@ -16,59 +16,42 @@ #include #include "fio.h" +#include "client.h" #include "server.h" #include "flist.h" #include "hash.h" -struct client_eta { - struct jobs_eta eta; - unsigned int pending; -}; - -struct fio_client { - struct flist_head list; - struct flist_head hash_list; - struct flist_head arg_list; - struct sockaddr_in addr; - struct sockaddr_un addr_un; - char *hostname; - int port; - int fd; - - char *name; - - int state; - - int skip_newline; - int is_sock; - - struct flist_head eta_list; - struct client_eta *eta_in_flight; - - struct flist_head cmd_list; - - uint16_t argc; - char **argv; +static void handle_du(struct fio_client *client, struct fio_net_cmd *cmd); +static void handle_ts(struct fio_client *client, struct fio_net_cmd *cmd); +static void handle_gs(struct fio_client *client, struct fio_net_cmd *cmd); +static void handle_probe(struct fio_client *client, struct fio_net_cmd *cmd); +static void handle_text(struct fio_client *client, struct fio_net_cmd *cmd); +static void handle_stop(struct fio_client *client, struct fio_net_cmd *cmd); +static void handle_start(struct fio_client *client, struct fio_net_cmd *cmd); + +struct client_ops fio_client_ops = { + .text_op = handle_text, + .disk_util = handle_du, + .thread_status = handle_ts, + .group_stats = handle_gs, + .stop = handle_stop, + .start = handle_start, + .eta = display_thread_status, + .probe = handle_probe, + .eta_msec = FIO_CLIENT_DEF_ETA_MSEC, }; static struct timeval eta_tv; -enum { - Client_created = 0, - Client_connected = 1, - Client_started = 2, - Client_stopped = 3, - Client_exited = 4, -}; - static FLIST_HEAD(client_list); static FLIST_HEAD(eta_list); static FLIST_HEAD(arg_list); -static struct thread_stat client_ts; -static struct group_run_stats client_gs; -static int sum_stat_clients; +struct thread_stat client_ts; +struct group_run_stats client_gs; +int sum_stat_clients; + static int sum_stat_nr; #define FIO_CLIENT_HASH_BITS 7 @@ -76,9 +59,6 @@ static int sum_stat_nr; #define FIO_CLIENT_HASH_MASK (FIO_CLIENT_HASH_SZ - 1) static struct flist_head client_hash[FIO_CLIENT_HASH_SZ]; -static int handle_client(struct fio_client *client); -static void dec_jobs_eta(struct client_eta *eta); - static void fio_client_add_hash(struct fio_client *client) { int bucket = hash_long(client->fd, FIO_CLIENT_HASH_BITS); @@ -111,7 +91,7 @@ static struct fio_client *find_client_by_fd(int fd) client = flist_entry(entry, struct fio_client, hash_list); if (client->fd == fd) - return client; + return fio_get_client(client); } return NULL; @@ -119,6 +99,11 @@ static struct fio_client *find_client_by_fd(int fd) static void remove_client(struct fio_client *client) { + assert(client->refs); + + if (--client->refs) + return; + dprint(FD_NET, "client: removed <%s>\n", client->hostname); flist_del(&client->list); @@ -126,7 +111,7 @@ static void remove_client(struct fio_client *client) if (!flist_empty(&client->eta_list)) { flist_del_init(&client->eta_list); - dec_jobs_eta(client->eta_in_flight); + fio_client_dec_jobs_eta(client->eta_in_flight, client->ops->eta); } free(client->hostname); @@ -140,6 +125,17 @@ static void remove_client(struct fio_client *client) sum_stat_clients--; } +void fio_put_client(struct fio_client *client) +{ + remove_client(client); +} + +struct fio_client *fio_get_client(struct fio_client *client) +{ + client->refs++; + return client; +} + static void __fio_client_add_cmd_option(struct fio_client *client, const char *opt) { @@ -171,7 +167,53 @@ void fio_client_add_cmd_option(void *cookie, const char *opt) } } -int fio_client_add(const char *hostname, void **cookie) +struct fio_client *fio_client_add_explicit(struct client_ops *ops, + const char *hostname, int type, + int port) +{ + struct fio_client *client; + + client = malloc(sizeof(*client)); + memset(client, 0, sizeof(*client)); + + INIT_FLIST_HEAD(&client->list); + INIT_FLIST_HEAD(&client->hash_list); + INIT_FLIST_HEAD(&client->arg_list); + INIT_FLIST_HEAD(&client->eta_list); + INIT_FLIST_HEAD(&client->cmd_list); + + client->hostname = strdup(hostname); + + if (type == Fio_client_socket) + client->is_sock = 1; + else { + int ipv6; + + ipv6 = type == Fio_client_ipv6; + if (fio_server_parse_host(hostname, &ipv6, + &client->addr.sin_addr, + &client->addr6.sin6_addr)) + goto err; + + client->port = port; + } + + client->fd = -1; + client->ops = ops; + client->refs = 1; + + __fio_client_add_cmd_option(client, "fio"); + + flist_add(&client->list, &client_list); + nr_clients++; + dprint(FD_NET, "client: added <%s>\n", client->hostname); + return client; +err: + free(client); + return NULL; +} + +int fio_client_add(struct client_ops *ops, const char *hostname, void **cookie) { struct fio_client *existing = *cookie; struct fio_client *client; @@ -200,10 +242,14 @@ int fio_client_add(const char *hostname, void **cookie) if (fio_server_parse_string(hostname, &client->hostname, &client->is_sock, &client->port, - &client->addr.sin_addr)) + &client->addr.sin_addr, + &client->addr6.sin6_addr, + &client->ipv6)) return -1; client->fd = -1; + client->ops = ops; + client->refs = 1; __fio_client_add_cmd_option(client, "fio"); @@ -214,25 +260,49 @@ int fio_client_add(const char *hostname, void **cookie) return 0; } -static int fio_client_connect_ip(struct fio_client *client) +static void probe_client(struct fio_client *client) { - int fd; + dprint(FD_NET, "client: send probe\n"); + + fio_net_send_simple_cmd(client->fd, FIO_NET_CMD_PROBE, 0, &client->cmd_list); +} - client->addr.sin_family = AF_INET; - client->addr.sin_port = htons(client->port); +static int fio_client_connect_ip(struct fio_client *client) +{ + struct sockaddr *addr; + fio_socklen_t socklen; + int fd, domain; + + if (client->ipv6) { + client->addr6.sin6_family = AF_INET6; + client->addr6.sin6_port = htons(client->port); + domain = AF_INET6; + addr = (struct sockaddr *) &client->addr6; + socklen = sizeof(client->addr6); + } else { + client->addr.sin_family = AF_INET; + client->addr.sin_port = htons(client->port); + domain = AF_INET; + addr = (struct sockaddr *) &client->addr; + socklen = sizeof(client->addr); + } - fd = socket(AF_INET, SOCK_STREAM, 0); + fd = socket(domain, SOCK_STREAM, 0); if (fd < 0) { + int ret = -errno; + log_err("fio: socket: %s\n", strerror(errno)); - return -1; + return ret; } - if (connect(fd, (struct sockaddr *) &client->addr, sizeof(client->addr)) < 0) { + if (connect(fd, addr, socklen) < 0) { + int ret = -errno; + log_err("fio: connect: %s\n", strerror(errno)); log_err("fio: failed to connect to %s:%u\n", client->hostname, client->port); close(fd); - return -1; + return ret; } return fd; @@ -250,21 +320,25 @@ static int fio_client_connect_sock(struct fio_client *client) fd = socket(AF_UNIX, SOCK_STREAM, 0); if (fd < 0) { + int ret = -errno; + log_err("fio: socket: %s\n", strerror(errno)); - return -1; + return ret; } len = sizeof(addr->sun_family) + strlen(addr->sun_path) + 1; if (connect(fd, (struct sockaddr *) addr, len) < 0) { + int ret = -errno; + log_err("fio: connect; %s\n", strerror(errno)); close(fd); - return -1; + return ret; } return fd; } -static int fio_client_connect(struct fio_client *client) +int fio_client_connect(struct fio_client *client) { int fd; @@ -278,14 +352,21 @@ static int fio_client_connect(struct fio_client *client) dprint(FD_NET, "client: %s connected %d\n", client->hostname, fd); if (fd < 0) - return 1; + return fd; client->fd = fd; fio_client_add_hash(client); client->state = Client_connected; + + probe_client(client); return 0; } +void fio_client_terminate(struct fio_client *client) +{ + fio_net_send_simple_cmd(client->fd, FIO_NET_CMD_QUIT, 0, NULL); +} + void fio_clients_terminate(void) { struct flist_head *entry; @@ -295,8 +376,7 @@ void fio_clients_terminate(void) flist_for_each(entry, &client_list) { client = flist_entry(entry, struct fio_client, list); - - fio_net_send_simple_cmd(client->fd, FIO_NET_CMD_QUIT, 0, NULL); + fio_client_terminate(client); } } @@ -321,13 +401,6 @@ static void client_signal_handler(void) sigaction(SIGTERM, &act, NULL); } -static void probe_client(struct fio_client *client) -{ - dprint(FD_NET, "client: send probe\n"); - - fio_net_send_simple_cmd(client->fd, FIO_NET_CMD_PROBE, 0, &client->cmd_list); -} - static int send_client_cmd_line(struct fio_client *client) { struct cmd_single_line_pdu *cslp; @@ -381,6 +454,11 @@ int fio_clients_connect(void) struct flist_head *entry, *tmp; int ret; +#ifdef WIN32 + WSADATA wsd; + WSAStartup(MAKEWORD(2,2), &wsd); +#endif + dprint(FD_NET, "client: connect all\n"); client_signal_handler(); @@ -394,8 +472,6 @@ int fio_clients_connect(void) continue; } - probe_client(client); - if (client->argc > 1) send_client_cmd_line(client); } @@ -403,11 +479,38 @@ int fio_clients_connect(void) return !nr_clients; } +int fio_start_client(struct fio_client *client) +{ + dprint(FD_NET, "client: start %s\n", client->hostname); + return fio_net_send_simple_cmd(client->fd, FIO_NET_CMD_RUN, 0, NULL); +} + +int fio_start_all_clients(void) +{ + struct fio_client *client; + struct flist_head *entry, *tmp; + int ret; + + dprint(FD_NET, "client: start all\n"); + + flist_for_each_safe(entry, tmp, &client_list) { + client = flist_entry(entry, struct fio_client, list); + + ret = fio_start_client(client); + if (ret) { + remove_client(client); + continue; + } + } + + return flist_empty(&client_list); +} + /* * Send file contents to server backend. We could use sendfile(), but to remain * more portable lets just read/write the darn thing. */ -static int fio_client_send_ini(struct fio_client *client, const char *filename) +static int __fio_client_send_ini(struct fio_client *client, const char *filename) { struct stat sb; char *p, *buf; @@ -418,14 +521,18 @@ static int fio_client_send_ini(struct fio_client *client, const char *filename) fd = open(filename, O_RDONLY); if (fd < 0) { + int ret = -errno; + log_err("fio: job file <%s> open: %s\n", filename, strerror(errno)); - return 1; + return ret; } if (fstat(fd, &sb) < 0) { + int ret = -errno; + log_err("fio: job file stat: %s\n", strerror(errno)); close(fd); - return 1; + return ret; } buf = malloc(sb.st_size); @@ -453,12 +560,27 @@ static int fio_client_send_ini(struct fio_client *client, const char *filename) return 1; } + client->sent_job = 1; ret = fio_net_send_cmd(client->fd, FIO_NET_CMD_JOB, buf, sb.st_size, 0); free(buf); close(fd); return ret; } +int fio_client_send_ini(struct fio_client *client, const char *filename) +{ + int ret; + + ret = __fio_client_send_ini(client, filename); + if (ret) { + remove_client(client); + return ret; + } + + client->sent_job = 1; + return ret; +} + int fio_clients_send_ini(const char *filename) { struct fio_client *client; @@ -467,8 +589,7 @@ int fio_clients_send_ini(const char *filename) flist_for_each_safe(entry, tmp, &client_list) { client = flist_entry(entry, struct fio_client, list); - if (fio_client_send_ini(client, filename)) - remove_client(client); + fio_client_send_ini(client, filename); } return !nr_clients; @@ -569,13 +690,10 @@ static void convert_gs(struct group_run_stats *dst, struct group_run_stats *src) dst->groupid = le32_to_cpu(src->groupid); } -static void handle_ts(struct fio_net_cmd *cmd) +static void handle_ts(struct fio_client *client, struct fio_net_cmd *cmd) { struct cmd_ts_pdu *p = (struct cmd_ts_pdu *) cmd->payload; - convert_ts(&p->ts, &p->ts); - convert_gs(&p->rs, &p->rs); - show_thread_status(&p->ts, &p->rs); if (sum_stat_clients == 1) @@ -593,14 +711,74 @@ static void handle_ts(struct fio_net_cmd *cmd) } } -static void handle_gs(struct fio_net_cmd *cmd) +static void handle_gs(struct fio_client *client, struct fio_net_cmd *cmd) { struct group_run_stats *gs = (struct group_run_stats *) cmd->payload; - convert_gs(gs, gs); show_group_stats(gs); } +static void handle_text(struct fio_client *client, struct fio_net_cmd *cmd) +{ + struct cmd_text_pdu *pdu = (struct cmd_text_pdu *) cmd->payload; + const char *buf = (const char *) pdu->buf; + const char *name; + int fio_unused ret; + + name = client->name ? client->name : client->hostname; + + if (!client->skip_newline) + fprintf(f_out, "<%s> ", name); + ret = fwrite(buf, pdu->buf_len, 1, f_out); + fflush(f_out); + client->skip_newline = strchr(buf, '\n') == NULL; +} + +static void convert_agg(struct disk_util_agg *agg) +{ + int i; + + for (i = 0; i < 2; i++) { + agg->ios[i] = le32_to_cpu(agg->ios[i]); + agg->merges[i] = le32_to_cpu(agg->merges[i]); + agg->sectors[i] = le64_to_cpu(agg->sectors[i]); + agg->ticks[i] = le32_to_cpu(agg->ticks[i]); + } + + agg->io_ticks = le32_to_cpu(agg->io_ticks); + agg->time_in_queue = le32_to_cpu(agg->time_in_queue); + agg->slavecount = le32_to_cpu(agg->slavecount); + agg->max_util.u.f = fio_uint64_to_double(__le64_to_cpu(agg->max_util.u.i)); +} + +static void convert_dus(struct disk_util_stat *dus) +{ + int i; + + for (i = 0; i < 2; i++) { + dus->ios[i] = le32_to_cpu(dus->ios[i]); + dus->merges[i] = le32_to_cpu(dus->merges[i]); + dus->sectors[i] = le64_to_cpu(dus->sectors[i]); + dus->ticks[i] = le32_to_cpu(dus->ticks[i]); + } + + dus->io_ticks = le32_to_cpu(dus->io_ticks); + dus->time_in_queue = le32_to_cpu(dus->time_in_queue); + dus->msec = le64_to_cpu(dus->msec); +} + +static void handle_du(struct fio_client *client, struct fio_net_cmd *cmd) +{ + struct cmd_du_pdu *du = (struct cmd_du_pdu *) cmd->payload; + + if (!client->disk_stats_shown) { + client->disk_stats_shown = 1; + log_info("\nDisk stats (read/write):\n"); + } + + print_disk_util(&du->dus, &du->agg, terse_output); +} + static void convert_jobs_eta(struct jobs_eta *je) { int i; @@ -609,21 +787,22 @@ static void convert_jobs_eta(struct jobs_eta *je) je->nr_ramp = le32_to_cpu(je->nr_ramp); je->nr_pending = le32_to_cpu(je->nr_pending); je->files_open = le32_to_cpu(je->files_open); - je->m_rate = le32_to_cpu(je->m_rate); - je->t_rate = le32_to_cpu(je->t_rate); - je->m_iops = le32_to_cpu(je->m_iops); - je->t_iops = le32_to_cpu(je->t_iops); for (i = 0; i < 2; i++) { + je->m_rate[i] = le32_to_cpu(je->m_rate[i]); + je->t_rate[i] = le32_to_cpu(je->t_rate[i]); + je->m_iops[i] = le32_to_cpu(je->m_iops[i]); + je->t_iops[i] = le32_to_cpu(je->t_iops[i]); je->rate[i] = le32_to_cpu(je->rate[i]); je->iops[i] = le32_to_cpu(je->iops[i]); } je->elapsed_sec = le64_to_cpu(je->elapsed_sec); je->eta_sec = le64_to_cpu(je->eta_sec); + je->nr_threads = le32_to_cpu(je->nr_threads); } -static void sum_jobs_eta(struct jobs_eta *dst, struct jobs_eta *je) +void fio_client_sum_jobs_eta(struct jobs_eta *dst, struct jobs_eta *je) { int i; @@ -631,12 +810,12 @@ static void sum_jobs_eta(struct jobs_eta *dst, struct jobs_eta *je) dst->nr_ramp += je->nr_ramp; dst->nr_pending += je->nr_pending; dst->files_open += je->files_open; - dst->m_rate += je->m_rate; - dst->t_rate += je->t_rate; - dst->m_iops += je->m_iops; - dst->t_iops += je->t_iops; for (i = 0; i < 2; i++) { + dst->m_rate[i] += je->m_rate[i]; + dst->t_rate[i] += je->t_rate[i]; + dst->m_iops[i] += je->m_iops[i]; + dst->t_iops[i] += je->t_iops[i]; dst->rate[i] += je->rate[i]; dst->iops[i] += je->iops[i]; } @@ -645,12 +824,15 @@ static void sum_jobs_eta(struct jobs_eta *dst, struct jobs_eta *je) if (je->eta_sec > dst->eta_sec) dst->eta_sec = je->eta_sec; + + dst->nr_threads += je->nr_threads; + /* we need to handle je->run_str too ... */ } -static void dec_jobs_eta(struct client_eta *eta) +void fio_client_dec_jobs_eta(struct client_eta *eta, client_eta_op eta_fn) { if (!--eta->pending) { - display_thread_status(&eta->eta); + eta_fn(&eta->eta); free(eta); } } @@ -691,15 +873,18 @@ static void handle_eta(struct fio_client *client, struct fio_net_cmd *cmd) client->eta_in_flight = NULL; flist_del_init(&client->eta_list); - convert_jobs_eta(je); - sum_jobs_eta(&eta->eta, je); - dec_jobs_eta(eta); + if (client->ops->jobs_eta) + client->ops->jobs_eta(client, je); + + fio_client_sum_jobs_eta(&eta->eta, je); + fio_client_dec_jobs_eta(eta, client->ops->eta); } static void handle_probe(struct fio_client *client, struct fio_net_cmd *cmd) { struct cmd_probe_pdu *probe = (struct cmd_probe_pdu *) cmd->payload; - const char *os, *arch, *bit; + const char *os, *arch; + char bit[16]; os = fio_get_os_string(probe->os); if (!os) @@ -709,14 +894,7 @@ static void handle_probe(struct fio_client *client, struct fio_net_cmd *cmd) if (!arch) os = "unknown"; - if (probe->bpp == 2) - bit = "16-bit"; - else if (probe->bpp == 4) - bit = "32-bit"; - else if (probe->bpp == 8) - bit = "64-bit"; - else - bit = "unknown"; + sprintf(bit, "%d-bit", probe->bpp * 8); log_info("hostname=%s, be=%u, %s, os=%s, arch=%s, fio=%u.%u.%u\n", probe->hostname, probe->bigendian, bit, os, arch, @@ -726,8 +904,40 @@ static void handle_probe(struct fio_client *client, struct fio_net_cmd *cmd) client->name = strdup((char *) probe->hostname); } -static int handle_client(struct fio_client *client) +static void handle_start(struct fio_client *client, struct fio_net_cmd *cmd) { + struct cmd_start_pdu *pdu = (struct cmd_start_pdu *) cmd->payload; + + client->state = Client_started; + client->jobs = pdu->jobs; +} + +static void handle_stop(struct fio_client *client, struct fio_net_cmd *cmd) +{ + if (client->error) + log_info("client <%s>: exited with error %d\n", client->hostname, client->error); +} + +static void convert_stop(struct fio_net_cmd *cmd) +{ + struct cmd_end_pdu *pdu = (struct cmd_end_pdu *) cmd->payload; + + pdu->error = le32_to_cpu(pdu->error); +} + +static void convert_text(struct fio_net_cmd *cmd) +{ + struct cmd_text_pdu *pdu = (struct cmd_text_pdu *) cmd->payload; + + pdu->level = le32_to_cpu(pdu->level); + pdu->buf_len = le32_to_cpu(pdu->buf_len); + pdu->log_sec = le64_to_cpu(pdu->log_sec); + pdu->log_usec = le64_to_cpu(pdu->log_usec); +} + +int fio_handle_client(struct fio_client *client) +{ + struct client_ops *ops = client->ops; struct fio_net_cmd *cmd; dprint(FD_NET, "client: handle %s\n", client->hostname); @@ -736,53 +946,91 @@ static int handle_client(struct fio_client *client) if (!cmd) return 0; - dprint(FD_NET, "client: got cmd op %s from %s\n", - fio_server_op(cmd->opcode), client->hostname); + dprint(FD_NET, "client: got cmd op %s from %s (pdu=%u)\n", + fio_server_op(cmd->opcode), client->hostname, cmd->pdu_len); switch (cmd->opcode) { case FIO_NET_CMD_QUIT: + if (ops->quit) + ops->quit(client); remove_client(client); free(cmd); break; - case FIO_NET_CMD_TEXT: { - const char *buf = (const char *) cmd->payload; - const char *name; - int fio_unused ret; - - name = client->name ? client->name : client->hostname; - - if (!client->skip_newline) - fprintf(f_out, "<%s> ", name); - ret = fwrite(buf, cmd->pdu_len, 1, f_out); - fflush(f_out); - client->skip_newline = strchr(buf, '\n') == NULL; + case FIO_NET_CMD_TEXT: + convert_text(cmd); + ops->text_op(client, cmd); + free(cmd); + break; + case FIO_NET_CMD_DU: { + struct cmd_du_pdu *du = (struct cmd_du_pdu *) cmd->payload; + + convert_dus(&du->dus); + convert_agg(&du->agg); + + ops->disk_util(client, cmd); free(cmd); break; } - case FIO_NET_CMD_TS: - handle_ts(cmd); + case FIO_NET_CMD_TS: { + struct cmd_ts_pdu *p = (struct cmd_ts_pdu *) cmd->payload; + + convert_ts(&p->ts, &p->ts); + convert_gs(&p->rs, &p->rs); + + ops->thread_status(client, cmd); free(cmd); break; - case FIO_NET_CMD_GS: - handle_gs(cmd); + } + case FIO_NET_CMD_GS: { + struct group_run_stats *gs = (struct group_run_stats *) cmd->payload; + + convert_gs(gs, gs); + + ops->group_stats(client, cmd); free(cmd); break; - case FIO_NET_CMD_ETA: + } + case FIO_NET_CMD_ETA: { + struct jobs_eta *je = (struct jobs_eta *) cmd->payload; + remove_reply_cmd(client, cmd); + convert_jobs_eta(je); handle_eta(client, cmd); free(cmd); break; + } case FIO_NET_CMD_PROBE: remove_reply_cmd(client, cmd); - handle_probe(client, cmd); + ops->probe(client, cmd); free(cmd); break; - case FIO_NET_CMD_START: - client->state = Client_started; + case FIO_NET_CMD_SERVER_START: + client->state = Client_running; + if (ops->job_start) + ops->job_start(client, cmd); + free(cmd); + break; + case FIO_NET_CMD_START: { + struct cmd_start_pdu *pdu = (struct cmd_start_pdu *) cmd->payload; + + pdu->jobs = le32_to_cpu(pdu->jobs); + ops->start(client, cmd); free(cmd); break; - case FIO_NET_CMD_STOP: + } + case FIO_NET_CMD_STOP: { + struct cmd_end_pdu *pdu = (struct cmd_end_pdu *) cmd->payload; + + convert_stop(cmd); client->state = Client_stopped; + client->error = pdu->error; + ops->stop(client, cmd); + free(cmd); + break; + } + case FIO_NET_CMD_ADD_JOB: + if (ops->add_job) + ops->add_job(client, cmd); free(cmd); break; default: @@ -794,7 +1042,7 @@ static int handle_client(struct fio_client *client) return 1; } -static void request_client_etas(void) +static void request_client_etas(struct client_ops *ops) { struct fio_client *client; struct flist_head *entry; @@ -814,6 +1062,8 @@ static void request_client_etas(void) skipped++; continue; } + if (client->state != Client_running) + continue; assert(!client->eta_in_flight); flist_add_tail(&client->eta_list, &eta_list); @@ -823,7 +1073,7 @@ static void request_client_etas(void) } while (skipped--) - dec_jobs_eta(eta); + fio_client_dec_jobs_eta(eta, ops->eta); dprint(FD_NET, "client: requested eta tag %p\n", eta); } @@ -851,7 +1101,7 @@ static int client_check_cmd_timeout(struct fio_client *client, return flist_empty(&client->cmd_list) && ret; } -static int fio_client_timed_out(void) +static int fio_check_clients_timed_out(void) { struct fio_client *client; struct flist_head *entry, *tmp; @@ -869,7 +1119,11 @@ static int fio_client_timed_out(void) if (!client_check_cmd_timeout(client, &tv)) continue; - log_err("fio: client %s timed out\n", client->hostname); + if (client->ops->timed_out) + client->ops->timed_out(client); + else + log_err("fio: client %s timed out\n", client->hostname); + remove_client(client); ret = 1; } @@ -877,12 +1131,10 @@ static int fio_client_timed_out(void) return ret; } -int fio_handle_clients(void) +int fio_handle_clients(struct client_ops *ops) { - struct fio_client *client; - struct flist_head *entry; struct pollfd *pfds; - int i, ret = 0; + int i, ret = 0, retval = 0; gettimeofday(&eta_tv, NULL); @@ -893,26 +1145,38 @@ int fio_handle_clients(void) init_group_run_stat(&client_gs); while (!exit_backend && nr_clients) { + struct flist_head *entry, *tmp; + struct fio_client *client; + i = 0; - flist_for_each(entry, &client_list) { + flist_for_each_safe(entry, tmp, &client_list) { client = flist_entry(entry, struct fio_client, list); + if (!client->sent_job && !client->ops->stay_connected && + flist_empty(&client->cmd_list)) { + remove_client(client); + continue; + } + pfds[i].fd = client->fd; pfds[i].events = POLLIN; i++; } + if (!nr_clients) + break; + assert(i == nr_clients); do { struct timeval tv; gettimeofday(&tv, NULL); - if (mtime_since(&eta_tv, &tv) >= 900) { - request_client_etas(); + if (mtime_since(&eta_tv, &tv) >= ops->eta_msec) { + request_client_etas(ops); memcpy(&eta_tv, &tv, sizeof(tv)); - if (fio_client_timed_out()) + if (fio_check_clients_timed_out()) break; } @@ -935,14 +1199,17 @@ int fio_handle_clients(void) log_err("fio: unknown client fd %d\n", pfds[i].fd); continue; } - if (!handle_client(client)) { + if (!fio_handle_client(client)) { log_info("client: host=%s disconnected\n", client->hostname); remove_client(client); - } + retval = 1; + } else if (client->error) + retval = 1; + fio_put_client(client); } } free(pfds); - return 0; + return retval; }