steadystate: get rid of ->ss_pct and encode this information in ->state via __FIO_SS_PCT

[fio.git] / stat.c

diff --git a/stat.c b/stat.c
index 68a4a27609c5fcbec66b0fe55dda7c28f95120a0..a42ee9b857f1d1745b9425749c6360f60e25a1e1 100644 (file)
--- a/stat.c
+++ b/stat.c
@@ -1262,23 +1262,24 @@ static struct json_object *show_thread_status_json(struct thread_stat *ts,
                struct steadystate_data *ss = ts->ss;
                unsigned long long sum_iops, sum_bw;
                double mean_iops, mean_bw;
-               int i, x;
+               int i, j, k;
                char ss_buf[64];
 
                snprintf(ss_buf, sizeof(ss_buf), "%s%s:%f%s",
-                       ss->check_iops ? "iops" : "bw",
-                       ss->check_slope ? "_slope" : "",
+                       ss->state & __FIO_SS_IOPS ? "iops" : "bw",
+                       ss->state & __FIO_SS_SLOPE ? "_slope" : "",
                        (float) ss->limit,
-                       ss->pct ? "%" : "");
+                       ss->state & __FIO_SS_PCT ? "%" : "");
 
                tmp = json_create_object();
                json_object_add_value_object(root, "steadystate", tmp);
                json_object_add_value_string(tmp, "ss", ss_buf);
                json_object_add_value_int(tmp, "duration", (int)ss->dur);
                json_object_add_value_int(tmp, "steadystate_ramptime", ss->ramp_time / 1000000L);
-               json_object_add_value_int(tmp, "attained", ss->attained);
+               json_object_add_value_int(tmp, "attained", (ss->state & __FIO_SS_ATTAINED) > 0);
 
-               snprintf(ss_buf, sizeof(ss_buf), "%f%s", (float) ss->criterion, ss->pct ? "%" : "");
+               snprintf(ss_buf, sizeof(ss_buf), "%f%s", (float) ss->criterion,
+                       ss->state & __FIO_SS_PCT ? "%" : "");
                json_object_add_value_string(tmp, "criterion", ss_buf);
                json_object_add_value_float(tmp, "max_deviation", ss->deviation);
                json_object_add_value_float(tmp, "slope", ss->slope);
@@ -1287,12 +1288,23 @@ static struct json_object *show_thread_status_json(struct thread_stat *ts,
                json_object_add_value_object(tmp, "data", data);
                bw = json_create_array();
                iops = json_create_array();
+
+               /*
+               ** if ss was attained or the buffer is not full,
+               ** ss->head points to the first element in the list.
+               ** otherwise it actually points to the second element
+               ** in the list
+               */
+               if ((ss->state & __FIO_SS_ATTAINED) || ss->sum_y == 0)
+                       j = ss->head;
+               else
+                       j = ss->head == 0 ? ss->dur - 1 : ss->head - 1;
                for (i = 0, sum_iops = 0, sum_bw = 0; i < ss->dur; i++) {
-                       x = (ss->head + i) % ss->dur;
-                       sum_bw += ss->bw_data[x];
-                       sum_iops += ss->iops_data[x];
-                       json_array_add_value_int(bw, ss->bw_data[x]);
-                       json_array_add_value_int(iops, ss->iops_data[x]);
+                       k = (j + i) % ss->dur;
+                       sum_bw += ss->bw_data[k];
+                       sum_iops += ss->iops_data[k];
+                       json_array_add_value_int(bw, ss->bw_data[k]);
+                       json_array_add_value_int(iops, ss->iops_data[k]);
                }
                mean_bw = (double) sum_bw / ss->dur;
                mean_iops = (double) sum_iops / ss->dur;