Remove debug/broken assert() in the IOPS logging code
[fio.git] / stat.c
diff --git a/stat.c b/stat.c
index d54aa85d82d4fbcfd2053539582293e71877b44d..851cc2c0ccf7188da3755e80deeaf8b95e34d83d 100644 (file)
--- a/stat.c
+++ b/stat.c
@@ -628,11 +628,6 @@ static void show_ddir_status_terse(struct thread_stat *ts,
        else
                log_info(";%lu;%lu;%f;%f", 0UL, 0UL, 0.0, 0.0);
 
-       if (calc_lat(&ts->lat_stat[ddir], &min, &max, &mean, &dev))
-               log_info(";%lu;%lu;%f;%f", min, max, mean, dev);
-       else
-               log_info(";%lu;%lu;%f;%f", 0UL, 0UL, 0.0, 0.0);
-
        if (ts->clat_percentiles) {
                len = calc_clat_percentiles(ts->io_u_plat[ddir],
                                        ts->clat_stat[ddir].samples,
@@ -648,6 +643,12 @@ static void show_ddir_status_terse(struct thread_stat *ts,
                }
                log_info(";%2.2f%%=%u", ts->percentile_list[i].u.f, ovals[i]);
        }
+
+       if (calc_lat(&ts->lat_stat[ddir], &min, &max, &mean, &dev))
+               log_info(";%lu;%lu;%f;%f", min, max, mean, dev);
+       else
+               log_info(";%lu;%lu;%f;%f", 0UL, 0UL, 0.0, 0.0);
+
        if (ovals)
                free(ovals);
 
@@ -660,10 +661,68 @@ static void show_ddir_status_terse(struct thread_stat *ts,
                log_info(";%lu;%lu;%f%%;%f;%f", 0UL, 0UL, 0.0, 0.0, 0.0);
 }
 
+static void show_thread_status_terse_v2(struct thread_stat *ts,
+                                       struct group_run_stats *rs)
+{
+       double io_u_dist[FIO_IO_U_MAP_NR];
+       double io_u_lat_u[FIO_IO_U_LAT_U_NR];
+       double io_u_lat_m[FIO_IO_U_LAT_M_NR];
+       double usr_cpu, sys_cpu;
+       int i;
+
+       /* General Info */
+       log_info("2;%s;%d;%d", ts->name, ts->groupid, ts->error);
+       /* Log Read Status */
+       show_ddir_status_terse(ts, rs, 0);
+       /* Log Write Status */
+       show_ddir_status_terse(ts, rs, 1);
+
+       /* CPU Usage */
+       if (ts->total_run_time) {
+               double runt = (double) ts->total_run_time;
+
+               usr_cpu = (double) ts->usr_time * 100 / runt;
+               sys_cpu = (double) ts->sys_time * 100 / runt;
+       } else {
+               usr_cpu = 0;
+               sys_cpu = 0;
+       }
+
+       log_info(";%f%%;%f%%;%lu;%lu;%lu", usr_cpu, sys_cpu, ts->ctx, ts->majf,
+                                                               ts->minf);
+
+       /* Calc % distribution of IO depths, usecond, msecond latency */
+       stat_calc_dist(ts->io_u_map, ts_total_io_u(ts), io_u_dist);
+       stat_calc_lat_u(ts, io_u_lat_u);
+       stat_calc_lat_m(ts, io_u_lat_m);
+
+       /* Only show fixed 7 I/O depth levels*/
+       log_info(";%3.1f%%;%3.1f%%;%3.1f%%;%3.1f%%;%3.1f%%;%3.1f%%;%3.1f%%",
+                       io_u_dist[0], io_u_dist[1], io_u_dist[2], io_u_dist[3],
+                       io_u_dist[4], io_u_dist[5], io_u_dist[6]);
+
+       /* Microsecond latency */
+       for (i = 0; i < FIO_IO_U_LAT_U_NR; i++)
+               log_info(";%3.2f%%", io_u_lat_u[i]);
+       /* Millisecond latency */
+       for (i = 0; i < FIO_IO_U_LAT_M_NR; i++)
+               log_info(";%3.2f%%", io_u_lat_m[i]);
+       /* Additional output if continue_on_error set - default off*/
+       if (ts->continue_on_error)
+               log_info(";%lu;%d", ts->total_err_count, ts->first_error);
+       log_info("\n");
+
+       /* Additional output if description is set */
+       if (ts->description)
+               log_info(";%s", ts->description);
+
+       log_info("\n");
+}
+
 #define FIO_TERSE_VERSION      "3"
 
-static void show_thread_status_terse(struct thread_stat *ts,
-                                    struct group_run_stats *rs)
+static void show_thread_status_terse_v3(struct thread_stat *ts,
+                                       struct group_run_stats *rs)
 {
        double io_u_dist[FIO_IO_U_MAP_NR];
        double io_u_lat_u[FIO_IO_U_LAT_U_NR];
@@ -723,6 +782,17 @@ static void show_thread_status_terse(struct thread_stat *ts,
                log_info(";%s", ts->description);
 }
 
+static void show_thread_status_terse(struct thread_stat *ts,
+                                    struct group_run_stats *rs)
+{
+       if (terse_version == 2)
+               show_thread_status_terse_v2(ts, rs);
+       else if (terse_version == 3)
+               show_thread_status_terse_v3(ts, rs);
+       else
+               log_err("fio: bad terse version!? %d\n", terse_version);
+}
+
 static void sum_stat(struct io_stat *dst, struct io_stat *src, int nr)
 {
        double mean, S;
@@ -1012,25 +1082,23 @@ void show_run_stats(void)
                        show_thread_status(ts, rs);
        }
 
-       if (!terse_output) {
-               for (i = 0; i < groupid + 1; i++) {
-                       rs = &runstats[i];
-
-                       rs->groupid = i;
-                       if (is_backend)
-                               fio_server_send_gs(rs);
-                       else
-                               show_group_stats(rs);
-               }
+       for (i = 0; i < groupid + 1; i++) {
+               rs = &runstats[i];
 
+               rs->groupid = i;
                if (is_backend)
-                       fio_server_send_du();
-               else
-                       show_disk_util(0);
-
-               free_disk_util();
+                       fio_server_send_gs(rs);
+               else if (!terse_output)
+                       show_group_stats(rs);
        }
 
+       if (is_backend)
+               fio_server_send_du();
+       else if (!terse_output)
+               show_disk_util(0);
+
+       free_disk_util();
+
        free(runstats);
        free(threadstats);
 }
@@ -1060,6 +1128,9 @@ static void __add_log_sample(struct io_log *iolog, unsigned long val,
 {
        const int nr_samples = iolog->nr_samples;
 
+       if (!iolog->nr_samples)
+               iolog->avg_last = t;
+
        if (iolog->nr_samples == iolog->max_samples) {
                int new_size = sizeof(struct io_sample) * iolog->max_samples*2;
 
@@ -1074,14 +1145,66 @@ static void __add_log_sample(struct io_log *iolog, unsigned long val,
        iolog->nr_samples++;
 }
 
+static inline void reset_io_stat(struct io_stat *ios)
+{
+       ios->max_val = ios->min_val = ios->samples = 0;
+       ios->mean.u.f = ios->S.u.f = 0;
+}
+
 static void add_log_sample(struct thread_data *td, struct io_log *iolog,
                           unsigned long val, enum fio_ddir ddir,
                           unsigned int bs)
 {
+       unsigned long elapsed, this_window;
+
        if (!ddir_rw(ddir))
                return;
 
-       __add_log_sample(iolog, val, ddir, bs, mtime_since_now(&td->epoch));
+       elapsed = mtime_since_now(&td->epoch);
+
+       /*
+        * If no time averaging, just add the log sample.
+        */
+       if (!iolog->avg_msec) {
+               __add_log_sample(iolog, val, ddir, bs, elapsed);
+               return;
+       }
+
+       /*
+        * Add the sample. If the time period has passed, then
+        * add that entry to the log and clear.
+        */
+       add_stat_sample(&iolog->avg_window[ddir], val);
+
+       /*
+        * If period hasn't passed, adding the above sample is all we
+        * need to do.
+        */
+       this_window = elapsed - iolog->avg_last;
+       if (this_window < iolog->avg_msec)
+               return;
+
+       /*
+        * Note an entry in the log. Use the mean from the logged samples,
+        * making sure to properly round up. Only write a log entry if we
+        * had actual samples done.
+        */
+       if (iolog->avg_window[DDIR_READ].samples) {
+               unsigned long mr;
+
+               mr = iolog->avg_window[DDIR_READ].mean.u.f + 0.50;
+               __add_log_sample(iolog, mr, DDIR_READ, 0, elapsed);
+       }
+       if (iolog->avg_window[DDIR_WRITE].samples) {
+               unsigned long mw;
+
+               mw = iolog->avg_window[DDIR_WRITE].mean.u.f + 0.50;
+               __add_log_sample(iolog, mw, DDIR_WRITE, 0, elapsed);
+       }
+
+       reset_io_stat(&iolog->avg_window[DDIR_READ]);
+       reset_io_stat(&iolog->avg_window[DDIR_WRITE]);
+       iolog->avg_last = elapsed;
 }
 
 void add_agg_sample(unsigned long val, enum fio_ddir ddir, unsigned int bs)
@@ -1190,10 +1313,8 @@ void add_iops_sample(struct thread_data *td, enum fio_ddir ddir,
 
        add_stat_sample(&ts->iops_stat[ddir], iops);
 
-       if (td->iops_log) {
-               assert(iops);
+       if (td->iops_log)
                add_log_sample(td, td->iops_log, iops, ddir, 0);
-       }
 
        fio_gettime(&td->iops_sample_time, NULL);
        td->stat_io_blocks[ddir] = td->this_io_blocks[ddir];