stat: don't add duplicate clat entries for json
[fio.git] / stat.c
diff --git a/stat.c b/stat.c
index 09afa5bdd8f5bb0fb3c771d01bae2fa1f491dc1e..80f804a19e0bd52ab2e790e07b8041938a50fa22 100644 (file)
--- a/stat.c
+++ b/stat.c
@@ -135,11 +135,11 @@ static int double_cmp(const void *a, const void *b)
        return cmp;
 }
 
-unsigned int calc_clat_percentiles(unsigned int *io_u_plat, unsigned long nr,
+unsigned int calc_clat_percentiles(unsigned int *io_u_plat, unsigned long long nr,
                                   fio_fp64_t *plist, unsigned long long **output,
                                   unsigned long long *maxv, unsigned long long *minv)
 {
-       unsigned long sum = 0;
+       unsigned long long sum = 0;
        unsigned int len, i, j = 0;
        unsigned int oval_len = 0;
        unsigned long long *ovals = NULL;
@@ -198,7 +198,7 @@ unsigned int calc_clat_percentiles(unsigned int *io_u_plat, unsigned long nr,
 /*
  * Find and display the p-th percentile of clat
  */
-static void show_clat_percentiles(unsigned int *io_u_plat, unsigned long nr,
+static void show_clat_percentiles(unsigned int *io_u_plat, unsigned long long nr,
                                  fio_fp64_t *plist, unsigned int precision,
                                  bool is_clat, struct buf_output *out)
 {
@@ -299,14 +299,14 @@ void show_group_stats(struct group_run_stats *rs, struct buf_output *out)
                if (!rs->max_run[i])
                        continue;
 
-               io = num2str(rs->iobytes[i], 4, 1, i2p, N2S_BYTE);
-               ioalt = num2str(rs->iobytes[i], 4, 1, !i2p, N2S_BYTE);
-               agg = num2str(rs->agg[i], 4, 1, i2p, rs->unit_base);
-               aggalt = num2str(rs->agg[i], 4, 1, !i2p, rs->unit_base);
-               min = num2str(rs->min_bw[i], 4, 1, i2p, rs->unit_base);
-               minalt = num2str(rs->min_bw[i], 4, 1, !i2p, rs->unit_base);
-               max = num2str(rs->max_bw[i], 4, 1, i2p, rs->unit_base);
-               maxalt = num2str(rs->max_bw[i], 4, 1, !i2p, rs->unit_base);
+               io = num2str(rs->iobytes[i], rs->sig_figs, 1, i2p, N2S_BYTE);
+               ioalt = num2str(rs->iobytes[i], rs->sig_figs, 1, !i2p, N2S_BYTE);
+               agg = num2str(rs->agg[i], rs->sig_figs, 1, i2p, rs->unit_base);
+               aggalt = num2str(rs->agg[i], rs->sig_figs, 1, !i2p, rs->unit_base);
+               min = num2str(rs->min_bw[i], rs->sig_figs, 1, i2p, rs->unit_base);
+               minalt = num2str(rs->min_bw[i], rs->sig_figs, 1, !i2p, rs->unit_base);
+               max = num2str(rs->max_bw[i], rs->sig_figs, 1, i2p, rs->unit_base);
+               maxalt = num2str(rs->max_bw[i], rs->sig_figs, 1, !i2p, rs->unit_base);
                log_buf(out, "%s: bw=%s (%s), %s-%s (%s-%s), io=%s (%s), run=%llu-%llumsec\n",
                                rs->unified_rw_rep ? "  MIXED" : str[i],
                                agg, aggalt, min, max, minalt, maxalt, io, ioalt,
@@ -435,12 +435,12 @@ static void show_ddir_status(struct group_run_stats *rs, struct thread_stat *ts,
        runt = ts->runtime[ddir];
 
        bw = (1000 * ts->io_bytes[ddir]) / runt;
-       io_p = num2str(ts->io_bytes[ddir], 4, 1, i2p, N2S_BYTE);
-       bw_p = num2str(bw, 4, 1, i2p, ts->unit_base);
-       bw_p_alt = num2str(bw, 4, 1, !i2p, ts->unit_base);
+       io_p = num2str(ts->io_bytes[ddir], ts->sig_figs, 1, i2p, N2S_BYTE);
+       bw_p = num2str(bw, ts->sig_figs, 1, i2p, ts->unit_base);
+       bw_p_alt = num2str(bw, ts->sig_figs, 1, !i2p, ts->unit_base);
 
        iops = (1000 * (uint64_t)ts->total_io_u[ddir]) / runt;
-       iops_p = num2str(iops, 4, 1, 0, N2S_NONE);
+       iops_p = num2str(iops, ts->sig_figs, 1, 0, N2S_NONE);
 
        log_buf(out, "  %s: IOPS=%s, BW=%s (%s)(%s/%llumsec)\n",
                        rs->unified_rw_rep ? "mixed" : str[ddir],
@@ -460,8 +460,15 @@ static void show_ddir_status(struct group_run_stats *rs, struct thread_stat *ts,
                display_lat(" lat", min, max, mean, dev, out);
 
        if (ts->clat_percentiles || ts->lat_percentiles) {
+               uint64_t samples;
+
+               if (ts->clat_percentiles)
+                       samples = ts->clat_stat[ddir].samples;
+               else
+                       samples = ts->lat_stat[ddir].samples;
+
                show_clat_percentiles(ts->io_u_plat[ddir],
-                                       ts->clat_stat[ddir].samples,
+                                       samples,
                                        ts->percentile_list,
                                        ts->percentile_precision,
                                        ts->clat_percentiles, out);
@@ -738,17 +745,17 @@ static void show_ss_normal(struct thread_stat *ts, struct buf_output *out)
        bw_mean = steadystate_bw_mean(ts);
        iops_mean = steadystate_iops_mean(ts);
 
-       p1 = num2str(bw_mean / ts->kb_base, 4, ts->kb_base, i2p, ts->unit_base);
-       p1alt = num2str(bw_mean / ts->kb_base, 4, ts->kb_base, !i2p, ts->unit_base);
-       p2 = num2str(iops_mean, 4, 1, 0, N2S_NONE);
+       p1 = num2str(bw_mean / ts->kb_base, ts->sig_figs, ts->kb_base, i2p, ts->unit_base);
+       p1alt = num2str(bw_mean / ts->kb_base, ts->sig_figs, ts->kb_base, !i2p, ts->unit_base);
+       p2 = num2str(iops_mean, ts->sig_figs, 1, 0, N2S_NONE);
 
        log_buf(out, "  steadystate  : attained=%s, bw=%s (%s), iops=%s, %s%s=%.3f%s\n",
-               ts->ss_state & __FIO_SS_ATTAINED ? "yes" : "no",
+               ts->ss_state & FIO_SS_ATTAINED ? "yes" : "no",
                p1, p1alt, p2,
-               ts->ss_state & __FIO_SS_IOPS ? "iops" : "bw",
-               ts->ss_state & __FIO_SS_SLOPE ? " slope": " mean dev",
+               ts->ss_state & FIO_SS_IOPS ? "iops" : "bw",
+               ts->ss_state & FIO_SS_SLOPE ? " slope": " mean dev",
                ts->ss_criterion.u.f,
-               ts->ss_state & __FIO_SS_PCT ? "%" : "");
+               ts->ss_state & FIO_SS_PCT ? "%" : "");
 
        free(p1);
        free(p1alt);
@@ -956,13 +963,13 @@ static void add_ddir_status_json(struct thread_stat *ts,
                struct group_run_stats *rs, int ddir, struct json_object *parent)
 {
        unsigned long long min, max, minv, maxv;
-       unsigned long long bw;
+       unsigned long long bw_bytes, bw;
        unsigned long long *ovals = NULL;
        double mean, dev, iops;
        unsigned int len;
        int i;
        const char *ddirname[] = {"read", "write", "trim"};
-       struct json_object *dir_object, *tmp_object, *percentile_object, *clat_bins_object;
+       struct json_object *dir_object, *tmp_object, *percentile_object, *clat_bins_object = NULL;
        char buf[120];
        double p_of_agg = 100.0;
 
@@ -975,17 +982,20 @@ static void add_ddir_status_json(struct thread_stat *ts,
        json_object_add_value_object(parent,
                ts->unified_rw_rep ? "mixed" : ddirname[ddir], dir_object);
 
+       bw_bytes = 0;
        bw = 0;
        iops = 0.0;
        if (ts->runtime[ddir]) {
                uint64_t runt = ts->runtime[ddir];
 
-               bw = ((1000 * ts->io_bytes[ddir]) / runt) / 1024; /* KiB/s */
+               bw_bytes = ((1000 * ts->io_bytes[ddir]) / runt); /* Bytes/s */
+               bw = bw_bytes / 1024; /* KiB/s */
                iops = (1000.0 * (uint64_t) ts->total_io_u[ddir]) / runt;
        }
 
        json_object_add_value_int(dir_object, "io_bytes", ts->io_bytes[ddir]);
        json_object_add_value_int(dir_object, "io_kbytes", ts->io_bytes[ddir] >> 10);
+       json_object_add_value_int(dir_object, "bw_bytes", bw_bytes);
        json_object_add_value_int(dir_object, "bw", bw);
        json_object_add_value_float(dir_object, "iops", iops);
        json_object_add_value_int(dir_object, "runtime", ts->runtime[ddir]);
@@ -1020,23 +1030,23 @@ static void add_ddir_status_json(struct thread_stat *ts,
                                        ts->clat_stat[ddir].samples,
                                        ts->percentile_list, &ovals, &maxv,
                                        &minv);
+               if (len > FIO_IO_U_LIST_MAX_LEN)
+                       len = FIO_IO_U_LIST_MAX_LEN;
        } else
                len = 0;
 
        percentile_object = json_create_object();
        json_object_add_value_object(tmp_object, "percentile", percentile_object);
-       for (i = 0; i < FIO_IO_U_LIST_MAX_LEN; i++) {
-               if (i >= len) {
-                       json_object_add_value_int(percentile_object, "0.00", 0);
-                       continue;
-               }
+       for (i = 0; i < len; i++) {
                snprintf(buf, sizeof(buf), "%f", ts->percentile_list[i].u.f);
                json_object_add_value_int(percentile_object, (const char *)buf, ovals[i]);
        }
 
        if (output_format & FIO_OUTPUT_JSON_PLUS) {
                clat_bins_object = json_create_object();
-               json_object_add_value_object(tmp_object, "bins", clat_bins_object);
+               if (ts->clat_percentiles)
+                       json_object_add_value_object(tmp_object, "bins", clat_bins_object);
+
                for(i = 0; i < FIO_IO_U_PLAT_NR; i++) {
                        if (ts->io_u_plat[ddir][i]) {
                                snprintf(buf, sizeof(buf), "%llu", plat_idx_to_val(i));
@@ -1055,6 +1065,9 @@ static void add_ddir_status_json(struct thread_stat *ts,
        json_object_add_value_int(tmp_object, "max", max);
        json_object_add_value_float(tmp_object, "mean", mean);
        json_object_add_value_float(tmp_object, "stddev", dev);
+       if (output_format & FIO_OUTPUT_JSON_PLUS && ts->lat_percentiles)
+               json_object_add_value_object(tmp_object, "bins", clat_bins_object);
+
        if (ovals)
                free(ovals);
 
@@ -1345,19 +1358,19 @@ static struct json_object *show_thread_status_json(struct thread_stat *ts,
                char ss_buf[64];
 
                snprintf(ss_buf, sizeof(ss_buf), "%s%s:%f%s",
-                       ts->ss_state & __FIO_SS_IOPS ? "iops" : "bw",
-                       ts->ss_state & __FIO_SS_SLOPE ? "_slope" : "",
+                       ts->ss_state & FIO_SS_IOPS ? "iops" : "bw",
+                       ts->ss_state & FIO_SS_SLOPE ? "_slope" : "",
                        (float) ts->ss_limit.u.f,
-                       ts->ss_state & __FIO_SS_PCT ? "%" : "");
+                       ts->ss_state & FIO_SS_PCT ? "%" : "");
 
                tmp = json_create_object();
                json_object_add_value_object(root, "steadystate", tmp);
                json_object_add_value_string(tmp, "ss", ss_buf);
                json_object_add_value_int(tmp, "duration", (int)ts->ss_dur);
-               json_object_add_value_int(tmp, "attained", (ts->ss_state & __FIO_SS_ATTAINED) > 0);
+               json_object_add_value_int(tmp, "attained", (ts->ss_state & FIO_SS_ATTAINED) > 0);
 
                snprintf(ss_buf, sizeof(ss_buf), "%f%s", (float) ts->ss_criterion.u.f,
-                       ts->ss_state & __FIO_SS_PCT ? "%" : "");
+                       ts->ss_state & FIO_SS_PCT ? "%" : "");
                json_object_add_value_string(tmp, "criterion", ss_buf);
                json_object_add_value_float(tmp, "max_deviation", ts->ss_deviation.u.f);
                json_object_add_value_float(tmp, "slope", ts->ss_slope.u.f);
@@ -1373,7 +1386,7 @@ static struct json_object *show_thread_status_json(struct thread_stat *ts,
                ** otherwise it actually points to the second element
                ** in the list
                */
-               if ((ts->ss_state & __FIO_SS_ATTAINED) || !(ts->ss_state & __FIO_SS_BUFFER_FULL))
+               if ((ts->ss_state & FIO_SS_ATTAINED) || !(ts->ss_state & FIO_SS_BUFFER_FULL))
                        j = ts->ss_head;
                else
                        j = ts->ss_head == 0 ? ts->ss_dur - 1 : ts->ss_head - 1;
@@ -1475,6 +1488,8 @@ void sum_group_stats(struct group_run_stats *dst, struct group_run_stats *src)
                dst->kb_base = src->kb_base;
        if (!dst->unit_base)
                dst->unit_base = src->unit_base;
+       if (!dst->sig_figs)
+               dst->sig_figs = src->sig_figs;
 }
 
 void sum_thread_stats(struct thread_stat *dst, struct thread_stat *src,
@@ -1682,6 +1697,7 @@ void __show_run_stats(void)
 
                        ts->kb_base = td->o.kb_base;
                        ts->unit_base = td->o.unit_base;
+                       ts->sig_figs = td->o.sig_figs;
                        ts->unified_rw_rep = td->o.unified_rw_rep;
                } else if (ts->kb_base != td->o.kb_base && !kb_base_warned) {
                        log_info("fio: kb_base differs for jobs in group, using"
@@ -1744,6 +1760,7 @@ void __show_run_stats(void)
                rs = &runstats[ts->groupid];
                rs->kb_base = ts->kb_base;
                rs->unit_base = ts->unit_base;
+               rs->sig_figs = ts->sig_figs;
                rs->unified_rw_rep += ts->unified_rw_rep;
 
                for (j = 0; j < DDIR_RWDIR_CNT; j++) {