Remove show_run_stats() because it has no callers
[fio.git] / stat.c
diff --git a/stat.c b/stat.c
index cc171a4d52ff69dab7df15037a7b89996e05ecaa..1effbfe9c5b452c625574a3cce02bd87ccdb074a 100644 (file)
--- a/stat.c
+++ b/stat.c
@@ -1,10 +1,7 @@
 #include <stdio.h>
 #include <string.h>
 #include <sys/time.h>
-#include <sys/types.h>
 #include <sys/stat.h>
-#include <dirent.h>
-#include <libgen.h>
 #include <math.h>
 
 #include "fio.h"
@@ -18,9 +15,9 @@
 #include "helper_thread.h"
 #include "smalloc.h"
 
-#define LOG_MSEC_SLACK 10
+#define LOG_MSEC_SLACK 1
 
-struct fio_mutex *stat_mutex;
+struct fio_sem *stat_sem;
 
 void clear_rusage_stat(struct thread_data *td)
 {
@@ -135,7 +132,7 @@ static int double_cmp(const void *a, const void *b)
        return cmp;
 }
 
-unsigned int calc_clat_percentiles(unsigned int *io_u_plat, unsigned long long nr,
+unsigned int calc_clat_percentiles(uint64_t *io_u_plat, unsigned long long nr,
                                   fio_fp64_t *plist, unsigned long long **output,
                                   unsigned long long *maxv, unsigned long long *minv)
 {
@@ -198,20 +195,19 @@ unsigned int calc_clat_percentiles(unsigned int *io_u_plat, unsigned long long n
 /*
  * Find and display the p-th percentile of clat
  */
-static void show_clat_percentiles(unsigned int *io_u_plat, unsigned long long nr,
+static void show_clat_percentiles(uint64_t *io_u_plat, unsigned long long nr,
                                  fio_fp64_t *plist, unsigned int precision,
-                                 bool is_clat, struct buf_output *out)
+                                 const char *pre, struct buf_output *out)
 {
        unsigned int divisor, len, i, j = 0;
        unsigned long long minv, maxv;
        unsigned long long *ovals;
        int per_line, scale_down, time_width;
-       const char *pre = is_clat ? "clat" : " lat";
        bool is_last;
        char fmt[32];
 
        len = calc_clat_percentiles(io_u_plat, nr, plist, &ovals, &maxv, &minv);
-       if (!len)
+       if (!len || !ovals)
                goto out;
 
        /*
@@ -324,7 +320,7 @@ void show_group_stats(struct group_run_stats *rs, struct buf_output *out)
        }
 }
 
-void stat_calc_dist(unsigned int *map, unsigned long total, double *io_u_dist)
+void stat_calc_dist(uint64_t *map, unsigned long total, double *io_u_dist)
 {
        int i;
 
@@ -343,7 +339,7 @@ void stat_calc_dist(unsigned int *map, unsigned long total, double *io_u_dist)
 }
 
 static void stat_calc_lat(struct thread_stat *ts, double *dst,
-                         unsigned int *src, int nr)
+                         uint64_t *src, int nr)
 {
        unsigned long total = ddir_rw_sum(ts->total_io_u);
        int i;
@@ -366,7 +362,7 @@ static void stat_calc_lat(struct thread_stat *ts, double *dst,
  * To keep the terse format unaltered, add all of the ns latency
  * buckets to the first us latency bucket
  */
-void stat_calc_lat_nu(struct thread_stat *ts, double *io_u_lat_u)
+static void stat_calc_lat_nu(struct thread_stat *ts, double *io_u_lat_u)
 {
        unsigned long ntotal = 0, total = ddir_rw_sum(ts->total_io_u);
        int i;
@@ -419,13 +415,26 @@ static void display_lat(const char *name, unsigned long long min,
 static void show_ddir_status(struct group_run_stats *rs, struct thread_stat *ts,
                             int ddir, struct buf_output *out)
 {
-       const char *str[] = { " read", "write", " trim" };
+       const char *str[] = { " read", "write", " trim", "sync" };
        unsigned long runt;
        unsigned long long min, max, bw, iops;
        double mean, dev;
        char *io_p, *bw_p, *bw_p_alt, *iops_p;
        int i2p;
 
+       if (ddir_sync(ddir)) {
+               if (calc_lat(&ts->sync_stat, &min, &max, &mean, &dev)) {
+                       log_buf(out, "  %s:\n", "fsync/fdatasync/sync_file_range");
+                       display_lat(str[ddir], min, max, mean, dev, out);
+                       show_clat_percentiles(ts->io_u_sync_plat,
+                                               ts->sync_stat.samples,
+                                               ts->percentile_list,
+                                               ts->percentile_precision,
+                                               str[ddir], out);
+               }
+               return;
+       }
+
        assert(ddir_rw(ddir));
 
        if (!ts->runtime[ddir])
@@ -460,6 +469,7 @@ static void show_ddir_status(struct group_run_stats *rs, struct thread_stat *ts,
                display_lat(" lat", min, max, mean, dev, out);
 
        if (ts->clat_percentiles || ts->lat_percentiles) {
+               const char *name = ts->clat_percentiles ? "clat" : " lat";
                uint64_t samples;
 
                if (ts->clat_percentiles)
@@ -470,8 +480,7 @@ static void show_ddir_status(struct group_run_stats *rs, struct thread_stat *ts,
                show_clat_percentiles(ts->io_u_plat[ddir],
                                        samples,
                                        ts->percentile_list,
-                                       ts->percentile_precision,
-                                       ts->clat_percentiles, out);
+                                       ts->percentile_precision, name, out);
        }
        if (calc_lat(&ts->bw_stat[ddir], &min, &max, &mean, &dev)) {
                double p_of_agg = 100.0, fkb_base = (double)rs->kb_base;
@@ -661,7 +670,6 @@ static int calc_block_percentiles(int nr_block_infos, uint32_t *block_infos,
        if (len > 1)
                qsort((void *)plist, len, sizeof(plist[0]), double_cmp);
 
-       nr_uninit = 0;
        /* Start only after the uninit entries end */
        for (nr_uninit = 0;
             nr_uninit < nr_block_infos
@@ -803,6 +811,9 @@ static void show_thread_status_normal(struct thread_stat *ts,
 
        show_latencies(ts, out);
 
+       if (ts->sync_stat.samples)
+               show_ddir_status(rs, ts, DDIR_SYNC, out);
+
        runtime = ts->total_run_time;
        if (runtime) {
                double runt = (double) runtime;
@@ -839,12 +850,13 @@ static void show_thread_status_normal(struct thread_stat *ts,
                                        io_u_dist[1], io_u_dist[2],
                                        io_u_dist[3], io_u_dist[4],
                                        io_u_dist[5], io_u_dist[6]);
-       log_buf(out, "     issued rwt: total=%llu,%llu,%llu,"
-                                " short=%llu,%llu,%llu,"
-                                " dropped=%llu,%llu,%llu\n",
+       log_buf(out, "     issued rwts: total=%llu,%llu,%llu,%llu"
+                                " short=%llu,%llu,%llu,0"
+                                " dropped=%llu,%llu,%llu,0\n",
                                        (unsigned long long) ts->total_io_u[0],
                                        (unsigned long long) ts->total_io_u[1],
                                        (unsigned long long) ts->total_io_u[2],
+                                       (unsigned long long) ts->total_io_u[3],
                                        (unsigned long long) ts->short_io_u[0],
                                        (unsigned long long) ts->short_io_u[1],
                                        (unsigned long long) ts->short_io_u[2],
@@ -968,12 +980,12 @@ static void add_ddir_status_json(struct thread_stat *ts,
        double mean, dev, iops;
        unsigned int len;
        int i;
-       const char *ddirname[] = {"read", "write", "trim"};
+       const char *ddirname[] = { "read", "write", "trim", "sync" };
        struct json_object *dir_object, *tmp_object, *percentile_object, *clat_bins_object = NULL;
        char buf[120];
        double p_of_agg = 100.0;
 
-       assert(ddir_rw(ddir));
+       assert(ddir_rw(ddir) || ddir_sync(ddir));
 
        if (ts->unified_rw_rep && ddir != DDIR_READ)
                return;
@@ -982,64 +994,85 @@ static void add_ddir_status_json(struct thread_stat *ts,
        json_object_add_value_object(parent,
                ts->unified_rw_rep ? "mixed" : ddirname[ddir], dir_object);
 
-       bw_bytes = 0;
-       bw = 0;
-       iops = 0.0;
-       if (ts->runtime[ddir]) {
-               uint64_t runt = ts->runtime[ddir];
-
-               bw_bytes = ((1000 * ts->io_bytes[ddir]) / runt); /* Bytes/s */
-               bw = bw_bytes / 1024; /* KiB/s */
-               iops = (1000.0 * (uint64_t) ts->total_io_u[ddir]) / runt;
-       }
+       if (ddir_rw(ddir)) {
+               bw_bytes = 0;
+               bw = 0;
+               iops = 0.0;
+               if (ts->runtime[ddir]) {
+                       uint64_t runt = ts->runtime[ddir];
 
-       json_object_add_value_int(dir_object, "io_bytes", ts->io_bytes[ddir]);
-       json_object_add_value_int(dir_object, "io_kbytes", ts->io_bytes[ddir] >> 10);
-       json_object_add_value_int(dir_object, "bw_bytes", bw_bytes);
-       json_object_add_value_int(dir_object, "bw", bw);
-       json_object_add_value_float(dir_object, "iops", iops);
-       json_object_add_value_int(dir_object, "runtime", ts->runtime[ddir]);
-       json_object_add_value_int(dir_object, "total_ios", ts->total_io_u[ddir]);
-       json_object_add_value_int(dir_object, "short_ios", ts->short_io_u[ddir]);
-       json_object_add_value_int(dir_object, "drop_ios", ts->drop_io_u[ddir]);
+                       bw_bytes = ((1000 * ts->io_bytes[ddir]) / runt); /* Bytes/s */
+                       bw = bw_bytes / 1024; /* KiB/s */
+                       iops = (1000.0 * (uint64_t) ts->total_io_u[ddir]) / runt;
+               }
 
-       if (!calc_lat(&ts->slat_stat[ddir], &min, &max, &mean, &dev)) {
-               min = max = 0;
-               mean = dev = 0.0;
-       }
-       tmp_object = json_create_object();
-       json_object_add_value_object(dir_object, "slat_ns", tmp_object);
-       json_object_add_value_int(tmp_object, "min", min);
-       json_object_add_value_int(tmp_object, "max", max);
-       json_object_add_value_float(tmp_object, "mean", mean);
-       json_object_add_value_float(tmp_object, "stddev", dev);
+               json_object_add_value_int(dir_object, "io_bytes", ts->io_bytes[ddir]);
+               json_object_add_value_int(dir_object, "io_kbytes", ts->io_bytes[ddir] >> 10);
+               json_object_add_value_int(dir_object, "bw_bytes", bw_bytes);
+               json_object_add_value_int(dir_object, "bw", bw);
+               json_object_add_value_float(dir_object, "iops", iops);
+               json_object_add_value_int(dir_object, "runtime", ts->runtime[ddir]);
+               json_object_add_value_int(dir_object, "total_ios", ts->total_io_u[ddir]);
+               json_object_add_value_int(dir_object, "short_ios", ts->short_io_u[ddir]);
+               json_object_add_value_int(dir_object, "drop_ios", ts->drop_io_u[ddir]);
+
+               if (!calc_lat(&ts->slat_stat[ddir], &min, &max, &mean, &dev)) {
+                       min = max = 0;
+                       mean = dev = 0.0;
+               }
+               tmp_object = json_create_object();
+               json_object_add_value_object(dir_object, "slat_ns", tmp_object);
+               json_object_add_value_int(tmp_object, "min", min);
+               json_object_add_value_int(tmp_object, "max", max);
+               json_object_add_value_float(tmp_object, "mean", mean);
+               json_object_add_value_float(tmp_object, "stddev", dev);
+
+               if (!calc_lat(&ts->clat_stat[ddir], &min, &max, &mean, &dev)) {
+                       min = max = 0;
+                       mean = dev = 0.0;
+               }
+               tmp_object = json_create_object();
+               json_object_add_value_object(dir_object, "clat_ns", tmp_object);
+               json_object_add_value_int(tmp_object, "min", min);
+               json_object_add_value_int(tmp_object, "max", max);
+               json_object_add_value_float(tmp_object, "mean", mean);
+               json_object_add_value_float(tmp_object, "stddev", dev);
+       } else {
+               if (!calc_lat(&ts->sync_stat, &min, &max, &mean, &dev)) {
+                       min = max = 0;
+                       mean = dev = 0.0;
+               }
 
-       if (!calc_lat(&ts->clat_stat[ddir], &min, &max, &mean, &dev)) {
-               min = max = 0;
-               mean = dev = 0.0;
+               tmp_object = json_create_object();
+               json_object_add_value_object(dir_object, "lat_ns", tmp_object);
+               json_object_add_value_int(dir_object, "total_ios", ts->total_io_u[DDIR_SYNC]);
+               json_object_add_value_int(tmp_object, "min", min);
+               json_object_add_value_int(tmp_object, "max", max);
+               json_object_add_value_float(tmp_object, "mean", mean);
+               json_object_add_value_float(tmp_object, "stddev", dev);
        }
-       tmp_object = json_create_object();
-       json_object_add_value_object(dir_object, "clat_ns", tmp_object);
-       json_object_add_value_int(tmp_object, "min", min);
-       json_object_add_value_int(tmp_object, "max", max);
-       json_object_add_value_float(tmp_object, "mean", mean);
-       json_object_add_value_float(tmp_object, "stddev", dev);
 
        if (ts->clat_percentiles || ts->lat_percentiles) {
-               len = calc_clat_percentiles(ts->io_u_plat[ddir],
+               if (ddir_rw(ddir)) {
+                       len = calc_clat_percentiles(ts->io_u_plat[ddir],
                                        ts->clat_stat[ddir].samples,
                                        ts->percentile_list, &ovals, &maxv,
                                        &minv);
+               } else {
+                       len = calc_clat_percentiles(ts->io_u_sync_plat,
+                                       ts->sync_stat.samples,
+                                       ts->percentile_list, &ovals, &maxv,
+                                       &minv);
+               }
+
+               if (len > FIO_IO_U_LIST_MAX_LEN)
+                       len = FIO_IO_U_LIST_MAX_LEN;
        } else
                len = 0;
 
        percentile_object = json_create_object();
        json_object_add_value_object(tmp_object, "percentile", percentile_object);
-       for (i = 0; i < FIO_IO_U_LIST_MAX_LEN; i++) {
-               if (i >= len) {
-                       json_object_add_value_int(percentile_object, "0.00", 0);
-                       continue;
-               }
+       for (i = 0; i < len; i++) {
                snprintf(buf, sizeof(buf), "%f", ts->percentile_list[i].u.f);
                json_object_add_value_int(percentile_object, (const char *)buf, ovals[i]);
        }
@@ -1050,13 +1083,23 @@ static void add_ddir_status_json(struct thread_stat *ts,
                        json_object_add_value_object(tmp_object, "bins", clat_bins_object);
 
                for(i = 0; i < FIO_IO_U_PLAT_NR; i++) {
-                       if (ts->io_u_plat[ddir][i]) {
-                               snprintf(buf, sizeof(buf), "%llu", plat_idx_to_val(i));
-                               json_object_add_value_int(clat_bins_object, (const char *)buf, ts->io_u_plat[ddir][i]);
+                       if (ddir_rw(ddir)) {
+                               if (ts->io_u_plat[ddir][i]) {
+                                       snprintf(buf, sizeof(buf), "%llu", plat_idx_to_val(i));
+                                       json_object_add_value_int(clat_bins_object, (const char *)buf, ts->io_u_plat[ddir][i]);
+                               }
+                       } else {
+                               if (ts->io_u_sync_plat[i]) {
+                                       snprintf(buf, sizeof(buf), "%llu", plat_idx_to_val(i));
+                                       json_object_add_value_int(clat_bins_object, (const char *)buf, ts->io_u_sync_plat[i]);
+                               }
                        }
                }
        }
 
+       if (!ddir_rw(ddir))
+               return;
+
        if (!calc_lat(&ts->lat_stat[ddir], &min, &max, &mean, &dev)) {
                min = max = 0;
                mean = dev = 0.0;
@@ -1179,7 +1222,7 @@ static void show_thread_status_terse_all(struct thread_stat *ts,
 }
 
 static void json_add_job_opts(struct json_object *root, const char *name,
-                             struct flist_head *opt_list, bool num_jobs)
+                             struct flist_head *opt_list)
 {
        struct json_object *dir_object;
        struct flist_head *entry;
@@ -1195,8 +1238,6 @@ static void json_add_job_opts(struct json_object *root, const char *name,
                const char *pos = "";
 
                p = flist_entry(entry, struct print_option, list);
-               if (!num_jobs && !strcmp(p->name, "numjobs"))
-                       continue;
                if (p->value)
                        pos = p->value;
                json_object_add_value_string(dir_object, p->name, pos);
@@ -1230,11 +1271,12 @@ static struct json_object *show_thread_status_json(struct thread_stat *ts,
        }
 
        if (opt_list)
-               json_add_job_opts(root, "job options", opt_list, true);
+               json_add_job_opts(root, "job options", opt_list);
 
        add_ddir_status_json(ts, rs, DDIR_READ, root);
        add_ddir_status_json(ts, rs, DDIR_WRITE, root);
        add_ddir_status_json(ts, rs, DDIR_TRIM, root);
+       add_ddir_status_json(ts, rs, DDIR_SYNC, root);
 
        /* CPU Usage */
        if (ts->total_run_time) {
@@ -1490,6 +1532,8 @@ void sum_group_stats(struct group_run_stats *dst, struct group_run_stats *src)
                dst->kb_base = src->kb_base;
        if (!dst->unit_base)
                dst->unit_base = src->unit_base;
+       if (!dst->sig_figs)
+               dst->sig_figs = src->sig_figs;
 }
 
 void sum_thread_stats(struct thread_stat *dst, struct thread_stat *src,
@@ -1529,24 +1573,25 @@ void sum_thread_stats(struct thread_stat *dst, struct thread_stat *src,
                }
        }
 
+       sum_stat(&dst->sync_stat, &src->sync_stat, first);
        dst->usr_time += src->usr_time;
        dst->sys_time += src->sys_time;
        dst->ctx += src->ctx;
        dst->majf += src->majf;
        dst->minf += src->minf;
 
-       for (k = 0; k < FIO_IO_U_MAP_NR; k++)
+       for (k = 0; k < FIO_IO_U_MAP_NR; k++) {
                dst->io_u_map[k] += src->io_u_map[k];
-       for (k = 0; k < FIO_IO_U_MAP_NR; k++)
                dst->io_u_submit[k] += src->io_u_submit[k];
-       for (k = 0; k < FIO_IO_U_MAP_NR; k++)
                dst->io_u_complete[k] += src->io_u_complete[k];
-       for (k = 0; k < FIO_IO_U_LAT_N_NR; k++)
+       }
+       for (k = 0; k < FIO_IO_U_LAT_N_NR; k++) {
                dst->io_u_lat_n[k] += src->io_u_lat_n[k];
-       for (k = 0; k < FIO_IO_U_LAT_U_NR; k++)
                dst->io_u_lat_u[k] += src->io_u_lat_u[k];
-       for (k = 0; k < FIO_IO_U_LAT_M_NR; k++)
                dst->io_u_lat_m[k] += src->io_u_lat_m[k];
+       }
+       for (k = 0; k < FIO_IO_U_PLAT_NR; k++)
+               dst->io_u_sync_plat[k] += src->io_u_sync_plat[k];
 
        for (k = 0; k < DDIR_RWDIR_CNT; k++) {
                if (!dst->unified_rw_rep) {
@@ -1560,6 +1605,8 @@ void sum_thread_stats(struct thread_stat *dst, struct thread_stat *src,
                }
        }
 
+       dst->total_io_u[DDIR_SYNC] += src->total_io_u[DDIR_SYNC];
+
        for (k = 0; k < DDIR_RWDIR_CNT; k++) {
                int m;
 
@@ -1598,6 +1645,7 @@ void init_thread_stat(struct thread_stat *ts)
                ts->bw_stat[j].min_val = -1UL;
                ts->iops_stat[j].min_val = -1UL;
        }
+       ts->sync_stat.min_val = -1UL;
        ts->groupid = -1;
 }
 
@@ -1808,13 +1856,14 @@ void __show_run_stats(void)
                char time_buf[32];
                struct timeval now;
                unsigned long long ms_since_epoch;
+               time_t tv_sec;
 
                gettimeofday(&now, NULL);
                ms_since_epoch = (unsigned long long)(now.tv_sec) * 1000 +
                                 (unsigned long long)(now.tv_usec) / 1000;
 
-               os_ctime_r((const time_t *) &now.tv_sec, time_buf,
-                               sizeof(time_buf));
+               tv_sec = now.tv_sec;
+               os_ctime_r(&tv_sec, time_buf, sizeof(time_buf));
                if (time_buf[strlen(time_buf) - 1] == '\n')
                        time_buf[strlen(time_buf) - 1] = '\0';
 
@@ -1824,7 +1873,7 @@ void __show_run_stats(void)
                json_object_add_value_int(root, "timestamp_ms", ms_since_epoch);
                json_object_add_value_string(root, "time", time_buf);
                global = get_global_options();
-               json_add_job_opts(root, "global options", &global->opt_list, false);
+               json_add_job_opts(root, "global options", &global->opt_list);
                array = json_create_array();
                json_object_add_value_array(root, "jobs", array);
        }
@@ -1891,13 +1940,6 @@ void __show_run_stats(void)
        free(opt_lists);
 }
 
-void show_run_stats(void)
-{
-       fio_mutex_down(stat_mutex);
-       __show_run_stats();
-       fio_mutex_up(stat_mutex);
-}
-
 void __show_running_run_stats(void)
 {
        struct thread_data *td;
@@ -1905,7 +1947,7 @@ void __show_running_run_stats(void)
        struct timespec ts;
        int i;
 
-       fio_mutex_down(stat_mutex);
+       fio_sem_down(stat_sem);
 
        rt = malloc(thread_number * sizeof(unsigned long long));
        fio_gettime(&ts, NULL);
@@ -1931,7 +1973,7 @@ void __show_running_run_stats(void)
                        continue;
                if (td->rusage_sem) {
                        td->update_rusage = 1;
-                       fio_mutex_down(td->rusage_sem);
+                       fio_sem_down(td->rusage_sem);
                }
                td->update_rusage = 0;
        }
@@ -1948,7 +1990,7 @@ void __show_running_run_stats(void)
        }
 
        free(rt);
-       fio_mutex_up(stat_mutex);
+       fio_sem_up(stat_sem);
 }
 
 static bool status_interval_init;
@@ -2231,10 +2273,15 @@ void reset_io_stats(struct thread_data *td)
                ts->short_io_u[i] = 0;
                ts->drop_io_u[i] = 0;
 
-               for (j = 0; j < FIO_IO_U_PLAT_NR; j++)
+               for (j = 0; j < FIO_IO_U_PLAT_NR; j++) {
                        ts->io_u_plat[i][j] = 0;
+                       if (!i)
+                               ts->io_u_sync_plat[j] = 0;
+               }
        }
 
+       ts->total_io_u[DDIR_SYNC] = 0;
+
        for (i = 0; i < FIO_IO_U_MAP_NR; i++) {
                ts->io_u_map[i] = 0;
                ts->io_u_submit[i] = 0;
@@ -2283,9 +2330,11 @@ static void _add_stat_to_log(struct io_log *iolog, unsigned long elapsed,
                __add_stat_to_log(iolog, ddir, elapsed, log_max);
 }
 
-static long add_log_sample(struct thread_data *td, struct io_log *iolog,
-                          union io_sample_data data, enum fio_ddir ddir,
-                          unsigned int bs, uint64_t offset)
+static unsigned long add_log_sample(struct thread_data *td,
+                                   struct io_log *iolog,
+                                   union io_sample_data data,
+                                   enum fio_ddir ddir, unsigned int bs,
+                                   uint64_t offset)
 {
        unsigned long elapsed, this_window;
 
@@ -2316,7 +2365,7 @@ static long add_log_sample(struct thread_data *td, struct io_log *iolog,
        if (elapsed < iolog->avg_last[ddir])
                return iolog->avg_last[ddir] - elapsed;
        else if (this_window < iolog->avg_msec) {
-               int diff = iolog->avg_msec - this_window;
+               unsigned long diff = iolog->avg_msec - this_window;
 
                if (inline_log(iolog) || diff > LOG_MSEC_SLACK)
                        return diff;
@@ -2357,6 +2406,15 @@ void add_agg_sample(union io_sample_data data, enum fio_ddir ddir, unsigned int
        __add_log_sample(iolog, data, ddir, bs, mtime_since_genesis(), 0);
 }
 
+void add_sync_clat_sample(struct thread_stat *ts, unsigned long long nsec)
+{
+       unsigned int idx = plat_val_to_idx(nsec);
+       assert(idx < FIO_IO_U_PLAT_NR);
+
+       ts->io_u_sync_plat[idx]++;
+       add_stat_sample(&ts->sync_stat, nsec);
+}
+
 static void add_clat_percentile_sample(struct thread_stat *ts,
                                unsigned long long nsec, enum fio_ddir ddir)
 {
@@ -2394,7 +2452,7 @@ void add_clat_sample(struct thread_data *td, enum fio_ddir ddir,
                this_window = elapsed - hw->hist_last;
                
                if (this_window >= iolog->hist_msec) {
-                       unsigned int *io_u_plat;
+                       uint64_t *io_u_plat;
                        struct io_u_plat_entry *dst;
 
                        /*
@@ -2404,7 +2462,7 @@ void add_clat_sample(struct thread_data *td, enum fio_ddir ddir,
                         * located in iolog.c after printing this sample to the
                         * log file.
                         */
-                       io_u_plat = (unsigned int *) td->ts.io_u_plat[ddir];
+                       io_u_plat = (uint64_t *) td->ts.io_u_plat[ddir];
                        dst = malloc(sizeof(struct io_u_plat_entry));
                        memcpy(&(dst->io_u_plat), io_u_plat,
                                FIO_IO_U_PLAT_NR * sizeof(unsigned int));
@@ -2496,7 +2554,7 @@ static int __add_samples(struct thread_data *td, struct timespec *parent_tv,
 {
        unsigned long spent, rate;
        enum fio_ddir ddir;
-       unsigned int next, next_log;
+       unsigned long next, next_log;
 
        next_log = avg_time;
 
@@ -2621,7 +2679,7 @@ int calc_log_samples(void)
 
 void stat_init(void)
 {
-       stat_mutex = fio_mutex_init(FIO_MUTEX_UNLOCKED);
+       stat_sem = fio_sem_init(FIO_SEM_UNLOCKED);
 }
 
 void stat_exit(void)
@@ -2630,8 +2688,8 @@ void stat_exit(void)
         * When we have the mutex, we know out-of-band access to it
         * have ended.
         */
-       fio_mutex_down(stat_mutex);
-       fio_mutex_remove(stat_mutex);
+       fio_sem_down(stat_sem);
+       fio_sem_remove(stat_sem);
 }
 
 /*