[PATCH] Enable _FORTIFY_SOURCE and stack protector checking

[fio.git] / parse.c

diff --git a/parse.c b/parse.c
index bc308ffe82902f99728890d1108fa6e300c52d42..cab6ca727d37005641afd36f83835dccf82101f5 100644 (file)
--- a/parse.c
+++ b/parse.c
@@ -218,8 +218,11 @@ static int __handle_option(struct fio_option *o, const char *ptr, void *data,
 
                p1 = strchr(tmp, '-');
                if (!p1) {
-                       ret = 1;
-                       break;
+                       p1 = strchr(tmp, ':');
+                       if (!p1) {
+                               ret = 1;
+                               break;
+                       }
                }
 
                p2 = p1 + 1;
@@ -309,8 +312,11 @@ static int handle_option(struct fio_option *o, const char *ptr, void *data)
         * Do this before parsing the first round, to check if we should
         * copy set 1 options to set 2.
         */
-       if (ptr)
+       if (ptr && (o->type != FIO_OPT_STR_STORE)) {
                ptr2 = strchr(ptr, ',');
+               if (!ptr2)
+                       ptr2 = strchr(ptr, ':');
+       }
 
        /*
         * Don't return early if parsing the first option fails - if
@@ -437,6 +443,9 @@ int show_cmd_help(struct fio_option *options, const char *name)
                                continue;
                }
 
+               if (!match)
+                       continue;
+
                printf("%16s: %s\n", "type", typehelp[o->type]);
                printf("%16s: %s\n", "default", o->def ? o->def : "no default");
                show_option_range(o);
@@ -464,7 +473,7 @@ void fill_default_options(void *data, struct fio_option *options)
 
 /*
  * Sanitize the options structure. For now it just sets min/max for bool
- * values.
+ * values and whether both callback and offsets are given.
  */
 void options_init(struct fio_option *options)
 {
@@ -475,5 +484,7 @@ void options_init(struct fio_option *options)
                        o->minval = 0;
                        o->maxval = 1;
                }
+               if (o->cb && (o->off1 || o->off2 || o->off3 || o->off4))
+                       fprintf(stderr, "Option %s: both cb and offset given\n", o->name);
        }
 }