options: improvements to parse dry run
[fio.git] / options.c
index a222b190f159e8d6b3dca0ef93a72109c8ee6aab..7075d84d42493b8bec52702151dbdb4be578fbdf 100644 (file)
--- a/options.c
+++ b/options.c
@@ -44,35 +44,28 @@ static int bs_cmp(const void *p1, const void *p2)
        return (int) bsp1->perc - (int) bsp2->perc;
 }
 
-static int bssplit_ddir(struct thread_options *o, int ddir, char *str)
+struct split {
+       unsigned int nr;
+       unsigned int val1[100];
+       unsigned int val2[100];
+};
+
+static int split_parse_ddir(struct thread_options *o, struct split *split,
+                           enum fio_ddir ddir, char *str)
 {
-       struct bssplit *bssplit;
-       unsigned int i, perc, perc_missing;
-       unsigned int max_bs, min_bs;
+       unsigned int i, perc;
        long long val;
        char *fname;
 
-       o->bssplit_nr[ddir] = 4;
-       bssplit = malloc(4 * sizeof(struct bssplit));
+       split->nr = 0;
 
        i = 0;
-       max_bs = 0;
-       min_bs = -1;
        while ((fname = strsep(&str, ":")) != NULL) {
                char *perc_str;
 
                if (!strlen(fname))
                        break;
 
-               /*
-                * grow struct buffer, if needed
-                */
-               if (i == o->bssplit_nr[ddir]) {
-                       o->bssplit_nr[ddir] <<= 1;
-                       bssplit = realloc(bssplit, o->bssplit_nr[ddir]
-                                                 * sizeof(struct bssplit));
-               }
-
                perc_str = strstr(fname, "/");
                if (perc_str) {
                        *perc_str = '\0';
@@ -87,28 +80,53 @@ static int bssplit_ddir(struct thread_options *o, int ddir, char *str)
 
                if (str_to_decimal(fname, &val, 1, o, 0, 0)) {
                        log_err("fio: bssplit conversion failed\n");
-                       free(bssplit);
                        return 1;
                }
 
-               if (val > max_bs)
-                       max_bs = val;
-               if (val < min_bs)
-                       min_bs = val;
-
-               bssplit[i].bs = val;
-               bssplit[i].perc = perc;
+               split->val1[i] = val;
+               split->val2[i] = perc;
                i++;
+               if (i == 100)
+                       break;
        }
 
-       o->bssplit_nr[ddir] = i;
+       split->nr = i;
+       return 0;
+}
+
+static int bssplit_ddir(struct thread_options *o, enum fio_ddir ddir, char *str)
+{
+       unsigned int i, perc, perc_missing;
+       unsigned int max_bs, min_bs;
+       struct split split;
+
+       memset(&split, 0, sizeof(split));
+
+       if (split_parse_ddir(o, &split, ddir, str))
+               return 1;
+       if (!split.nr)
+               return 0;
+
+       max_bs = 0;
+       min_bs = -1;
+       o->bssplit[ddir] = malloc(split.nr * sizeof(struct bssplit));
+       o->bssplit_nr[ddir] = split.nr;
+       for (i = 0; i < split.nr; i++) {
+               if (split.val1[i] > max_bs)
+                       max_bs = split.val1[i];
+               if (split.val1[i] < min_bs)
+                       min_bs = split.val1[i];
+
+               o->bssplit[ddir][i].bs = split.val1[i];
+               o->bssplit[ddir][i].perc =split.val2[i];
+       }
 
        /*
         * Now check if the percentages add up, and how much is missing
         */
        perc = perc_missing = 0;
        for (i = 0; i < o->bssplit_nr[ddir]; i++) {
-               struct bssplit *bsp = &bssplit[i];
+               struct bssplit *bsp = &o->bssplit[ddir][i];
 
                if (bsp->perc == -1U)
                        perc_missing++;
@@ -118,7 +136,8 @@ static int bssplit_ddir(struct thread_options *o, int ddir, char *str)
 
        if (perc > 100 && perc_missing > 1) {
                log_err("fio: bssplit percentages add to more than 100%%\n");
-               free(bssplit);
+               free(o->bssplit[ddir]);
+               o->bssplit[ddir] = NULL;
                return 1;
        }
 
@@ -130,7 +149,7 @@ static int bssplit_ddir(struct thread_options *o, int ddir, char *str)
                if (perc_missing == 1 && o->bssplit_nr[ddir] == 1)
                        perc = 100;
                for (i = 0; i < o->bssplit_nr[ddir]; i++) {
-                       struct bssplit *bsp = &bssplit[i];
+                       struct bssplit *bsp = &o->bssplit[ddir][i];
 
                        if (bsp->perc == -1U)
                                bsp->perc = (100 - perc) / perc_missing;
@@ -143,60 +162,78 @@ static int bssplit_ddir(struct thread_options *o, int ddir, char *str)
        /*
         * now sort based on percentages, for ease of lookup
         */
-       qsort(bssplit, o->bssplit_nr[ddir], sizeof(struct bssplit), bs_cmp);
-       o->bssplit[ddir] = bssplit;
+       qsort(o->bssplit[ddir], o->bssplit_nr[ddir], sizeof(struct bssplit), bs_cmp);
        return 0;
 }
 
-static int str_bssplit_cb(void *data, const char *input)
+typedef int (split_parse_fn)(struct thread_options *, enum fio_ddir, char *);
+
+static int str_split_parse(struct thread_data *td, char *str, split_parse_fn *fn)
 {
-       struct thread_data *td = data;
-       char *str, *p, *odir, *ddir;
+       char *odir, *ddir;
        int ret = 0;
 
-       if (parse_dryrun())
-               return 0;
-
-       p = str = strdup(input);
-
-       strip_blank_front(&str);
-       strip_blank_end(str);
-
        odir = strchr(str, ',');
        if (odir) {
                ddir = strchr(odir + 1, ',');
                if (ddir) {
-                       ret = bssplit_ddir(&td->o, DDIR_TRIM, ddir + 1);
+                       ret = fn(&td->o, DDIR_TRIM, ddir + 1);
                        if (!ret)
                                *ddir = '\0';
                } else {
                        char *op;
 
                        op = strdup(odir + 1);
-                       ret = bssplit_ddir(&td->o, DDIR_TRIM, op);
+                       ret = fn(&td->o, DDIR_TRIM, op);
 
                        free(op);
                }
                if (!ret)
-                       ret = bssplit_ddir(&td->o, DDIR_WRITE, odir + 1);
+                       ret = fn(&td->o, DDIR_WRITE, odir + 1);
                if (!ret) {
                        *odir = '\0';
-                       ret = bssplit_ddir(&td->o, DDIR_READ, str);
+                       ret = fn(&td->o, DDIR_READ, str);
                }
        } else {
                char *op;
 
                op = strdup(str);
-               ret = bssplit_ddir(&td->o, DDIR_WRITE, op);
+               ret = fn(&td->o, DDIR_WRITE, op);
                free(op);
 
                if (!ret) {
                        op = strdup(str);
-                       ret = bssplit_ddir(&td->o, DDIR_TRIM, op);
+                       ret = fn(&td->o, DDIR_TRIM, op);
                        free(op);
                }
                if (!ret)
-                       ret = bssplit_ddir(&td->o, DDIR_READ, str);
+                       ret = fn(&td->o, DDIR_READ, str);
+       }
+
+       return ret;
+}
+
+static int str_bssplit_cb(void *data, const char *input)
+{
+       struct thread_data *td = data;
+       char *str, *p;
+       int ret = 0;
+
+       p = str = strdup(input);
+
+       strip_blank_front(&str);
+       strip_blank_end(str);
+
+       ret = str_split_parse(td, str, bssplit_ddir);
+
+       if (parse_dryrun()) {
+               int i;
+
+               for (i = 0; i < DDIR_RWDIR_CNT; i++) {
+                       free(td->o.bssplit[i]);
+                       td->o.bssplit[i] = NULL;
+                       td->o.bssplit_nr[i] = 0;
+               }
        }
 
        free(p);
@@ -714,64 +751,33 @@ static int zone_cmp(const void *p1, const void *p2)
        return (int) zsp2->access_perc - (int) zsp1->access_perc;
 }
 
-static int zone_split_ddir(struct thread_options *o, int ddir, char *str)
+static int zone_split_ddir(struct thread_options *o, enum fio_ddir ddir,
+                          char *str)
 {
-       struct zone_split *zsplit;
        unsigned int i, perc, perc_missing, sperc, sperc_missing;
-       long long val;
-       char *fname;
-
-       o->zone_split_nr[ddir] = 4;
-       zsplit = malloc(4 * sizeof(struct zone_split));
-
-       i = 0;
-       while ((fname = strsep(&str, ":")) != NULL) {
-               char *perc_str;
-
-               if (!strlen(fname))
-                       break;
-
-               /*
-                * grow struct buffer, if needed
-                */
-               if (i == o->zone_split_nr[ddir]) {
-                       o->zone_split_nr[ddir] <<= 1;
-                       zsplit = realloc(zsplit, o->zone_split_nr[ddir]
-                                                 * sizeof(struct zone_split));
-               }
+       struct split split;
 
-               perc_str = strstr(fname, "/");
-               if (perc_str) {
-                       *perc_str = '\0';
-                       perc_str++;
-                       perc = atoi(perc_str);
-                       if (perc > 100)
-                               perc = 100;
-                       else if (!perc)
-                               perc = -1U;
-               } else
-                       perc = -1U;
+       memset(&split, 0, sizeof(split));
 
-               if (str_to_decimal(fname, &val, 1, o, 0, 0)) {
-                       log_err("fio: zone_split conversion failed\n");
-                       free(zsplit);
-                       return 1;
-               }
+       if (split_parse_ddir(o, &split, ddir, str))
+               return 1;
+       if (!split.nr)
+               return 0;
 
-               zsplit[i].access_perc = val;
-               zsplit[i].size_perc = perc;
-               i++;
+       o->zone_split[ddir] = malloc(split.nr * sizeof(struct zone_split));
+       o->zone_split_nr[ddir] = split.nr;
+       for (i = 0; i < split.nr; i++) {
+               o->zone_split[ddir][i].access_perc = split.val1[i];
+               o->zone_split[ddir][i].size_perc = split.val2[i];
        }
 
-       o->zone_split_nr[ddir] = i;
-
        /*
         * Now check if the percentages add up, and how much is missing
         */
        perc = perc_missing = 0;
        sperc = sperc_missing = 0;
        for (i = 0; i < o->zone_split_nr[ddir]; i++) {
-               struct zone_split *zsp = &zsplit[i];
+               struct zone_split *zsp = &o->zone_split[ddir][i];
 
                if (zsp->access_perc == (uint8_t) -1U)
                        perc_missing++;
@@ -787,13 +793,15 @@ static int zone_split_ddir(struct thread_options *o, int ddir, char *str)
 
        if (perc > 100 || sperc > 100) {
                log_err("fio: zone_split percentages add to more than 100%%\n");
-               free(zsplit);
+               free(o->zone_split[ddir]);
+               o->zone_split[ddir] = NULL;
                return 1;
        }
        if (perc < 100) {
                log_err("fio: access percentage don't add up to 100 for zoned "
                        "random distribution (got=%u)\n", perc);
-               free(zsplit);
+               free(o->zone_split[ddir]);
+               o->zone_split[ddir] = NULL;
                return 1;
        }
 
@@ -805,7 +813,7 @@ static int zone_split_ddir(struct thread_options *o, int ddir, char *str)
                if (perc_missing == 1 && o->zone_split_nr[ddir] == 1)
                        perc = 100;
                for (i = 0; i < o->zone_split_nr[ddir]; i++) {
-                       struct zone_split *zsp = &zsplit[i];
+                       struct zone_split *zsp = &o->zone_split[ddir][i];
 
                        if (zsp->access_perc == (uint8_t) -1U)
                                zsp->access_perc = (100 - perc) / perc_missing;
@@ -815,7 +823,7 @@ static int zone_split_ddir(struct thread_options *o, int ddir, char *str)
                if (sperc_missing == 1 && o->zone_split_nr[ddir] == 1)
                        sperc = 100;
                for (i = 0; i < o->zone_split_nr[ddir]; i++) {
-                       struct zone_split *zsp = &zsplit[i];
+                       struct zone_split *zsp = &o->zone_split[ddir][i];
 
                        if (zsp->size_perc == (uint8_t) -1U)
                                zsp->size_perc = (100 - sperc) / sperc_missing;
@@ -825,8 +833,7 @@ static int zone_split_ddir(struct thread_options *o, int ddir, char *str)
        /*
         * now sort based on percentages, for ease of lookup
         */
-       qsort(zsplit, o->zone_split_nr[ddir], sizeof(struct zone_split), zone_cmp);
-       o->zone_split[ddir] = zsplit;
+       qsort(o->zone_split[ddir], o->zone_split_nr[ddir], sizeof(struct zone_split), zone_cmp);
        return 0;
 }
 
@@ -867,10 +874,9 @@ static void td_zone_gen_index(struct thread_data *td)
                __td_zone_gen_index(td, i);
 }
 
-
 static int parse_zoned_distribution(struct thread_data *td, const char *input)
 {
-       char *str, *p, *odir, *ddir;
+       char *str, *p;
        int i, ret = 0;
 
        p = str = strdup(input);
@@ -886,42 +892,7 @@ static int parse_zoned_distribution(struct thread_data *td, const char *input)
        }
        str += strlen("zoned:");
 
-       odir = strchr(str, ',');
-       if (odir) {
-               ddir = strchr(odir + 1, ',');
-               if (ddir) {
-                       ret = zone_split_ddir(&td->o, DDIR_TRIM, ddir + 1);
-                       if (!ret)
-                               *ddir = '\0';
-               } else {
-                       char *op;
-
-                       op = strdup(odir + 1);
-                       ret = zone_split_ddir(&td->o, DDIR_TRIM, op);
-
-                       free(op);
-               }
-               if (!ret)
-                       ret = zone_split_ddir(&td->o, DDIR_WRITE, odir + 1);
-               if (!ret) {
-                       *odir = '\0';
-                       ret = zone_split_ddir(&td->o, DDIR_READ, str);
-               }
-       } else {
-               char *op;
-
-               op = strdup(str);
-               ret = zone_split_ddir(&td->o, DDIR_WRITE, op);
-               free(op);
-
-               if (!ret) {
-                       op = strdup(str);
-                       ret = zone_split_ddir(&td->o, DDIR_TRIM, op);
-                       free(op);
-               }
-               if (!ret)
-                       ret = zone_split_ddir(&td->o, DDIR_READ, str);
-       }
+       ret = str_split_parse(td, str, zone_split_ddir);
 
        free(p);
 
@@ -938,8 +909,24 @@ static int parse_zoned_distribution(struct thread_data *td, const char *input)
                }
        }
 
+       if (parse_dryrun()) {
+               int i;
+
+               for (i = 0; i < DDIR_RWDIR_CNT; i++) {
+                       free(td->o.zone_split[i]);
+                       td->o.zone_split[i] = NULL;
+                       td->o.zone_split_nr[i] = 0;
+               }
+
+               return ret;
+       }
+
        if (!ret)
                td_zone_gen_index(td);
+       else {
+               for (i = 0; i < DDIR_RWDIR_CNT; i++)
+                       td->o.zone_split_nr[i] = 0;
+       }
 
        return ret;
 }
@@ -950,9 +937,6 @@ static int str_random_distribution_cb(void *data, const char *str)
        double val;
        char *nr;
 
-       if (parse_dryrun())
-               return 0;
-
        if (td->o.random_distribution == FIO_RAND_DIST_ZIPF)
                val = FIO_DEF_ZIPF;
        else if (td->o.random_distribution == FIO_RAND_DIST_PARETO)
@@ -978,18 +962,24 @@ static int str_random_distribution_cb(void *data, const char *str)
                        log_err("fio: zipf theta must different than 1.0\n");
                        return 1;
                }
+               if (parse_dryrun())
+                       return 0;
                td->o.zipf_theta.u.f = val;
        } else if (td->o.random_distribution == FIO_RAND_DIST_PARETO) {
                if (val <= 0.00 || val >= 1.00) {
                        log_err("fio: pareto input out of range (0 < input < 1.0)\n");
                        return 1;
                }
+               if (parse_dryrun())
+                       return 0;
                td->o.pareto_h.u.f = val;
        } else {
                if (val <= 0.00 || val >= 100.0) {
                        log_err("fio: normal deviation out of range (0 < input < 100.0)\n");
                        return 1;
                }
+               if (parse_dryrun())
+                       return 0;
                td->o.gauss_dev.u.f = val;
        }
 
@@ -4414,14 +4404,6 @@ void fio_options_free(struct thread_data *td)
                free(td->eo);
                td->eo = NULL;
        }
-       if (td->zone_state_index) {
-               int i;
-
-               for (i = 0; i < DDIR_RWDIR_CNT; i++)
-                       free(td->zone_state_index[i]);
-               free(td->zone_state_index);
-               td->zone_state_index = NULL;
-       }
 }
 
 struct fio_option *fio_option_find(const char *name)