mutex: set and use the proper clock source

[fio.git] / mutex.c

diff --git a/mutex.c b/mutex.c
index 34b3324ca7d395f49e1579390ba2f60322dd2ba1..6b4c9fe187bcdb0f080af0a14ae29e7615695e83 100644 (file)
--- a/mutex.c
+++ b/mutex.c
@@ -11,69 +11,58 @@
 #include "mutex.h"
 #include "arch/arch.h"
 #include "os/os.h"
+#include "helpers.h"
 
 void fio_mutex_remove(struct fio_mutex *mutex)
 {
-       close(mutex->mutex_fd);
        munmap((void *) mutex, sizeof(*mutex));
 }
 
 struct fio_mutex *fio_mutex_init(int value)
 {
-       char mutex_name[] = "/tmp/.fio_mutex.XXXXXX";
        struct fio_mutex *mutex = NULL;
        pthread_mutexattr_t attr;
        pthread_condattr_t cond;
-       int fd, ret, mflag;
-
-       fd = mkstemp(mutex_name);
-       if (fd < 0) {
-               perror("open mutex");
-               return NULL;
-       }
-
-       if (ftruncate(fd, sizeof(struct fio_mutex)) < 0) {
-               perror("ftruncate mutex");
-               goto err;
-       }
+       int ret;
 
        mutex = (void *) mmap(NULL, sizeof(struct fio_mutex),
-                               PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
+                               PROT_READ | PROT_WRITE,
+                               OS_MAP_ANON | MAP_SHARED, -1, 0);
        if (mutex == MAP_FAILED) {
                perror("mmap mutex");
-               close(fd);
                mutex = NULL;
                goto err;
        }
 
-       unlink(mutex_name);
-       mutex->mutex_fd = fd;
        mutex->value = value;
 
-       /*
-        * Not all platforms support process shared mutexes (FreeBSD)
-        */
-#ifdef FIO_HAVE_PSHARED_MUTEX
-       mflag = PTHREAD_PROCESS_SHARED;
-#else
-       mflag = PTHREAD_PROCESS_PRIVATE;
-#endif
-
        ret = pthread_mutexattr_init(&attr);
        if (ret) {
                log_err("pthread_mutexattr_init: %s\n", strerror(ret));
                goto err;
        }
-       ret = pthread_mutexattr_setpshared(&attr, mflag);
+
+       /*
+        * Not all platforms support process shared mutexes (FreeBSD)
+        */
+#ifdef FIO_HAVE_PSHARED_MUTEX
+       ret = pthread_mutexattr_setpshared(&attr, PTHREAD_PROCESS_SHARED);
        if (ret) {
                log_err("pthread_mutexattr_setpshared: %s\n", strerror(ret));
                goto err;
        }
+#endif
 
        pthread_condattr_init(&cond);
-       pthread_condattr_setpshared(&cond, mflag);
-       pthread_condattr_setclock(&cond, CLOCK_MONOTONIC);
+#ifdef FIO_HAVE_PSHARED_MUTEX
+       pthread_condattr_setpshared(&cond, PTHREAD_PROCESS_SHARED);
+#endif
        pthread_cond_init(&mutex->cond, &cond);
+#ifdef FIO_HAVE_CLOCK_MONOTONIC
+       pthread_condattr_setclock(&cond, CLOCK_MONOTONIC);
+#else
+       pthread_condattr_setclock(&cond, CLOCK_REALTIME);
+#endif
 
        ret = pthread_mutex_init(&mutex->lock, &attr);
        if (ret) {
@@ -81,12 +70,14 @@ struct fio_mutex *fio_mutex_init(int value)
                goto err;
        }
 
+       pthread_condattr_destroy(&cond);
+       pthread_mutexattr_destroy(&attr);
+
        return mutex;
 err:
        if (mutex)
                fio_mutex_remove(mutex);
 
-       unlink(mutex_name);
        return NULL;
 }
 
@@ -95,7 +86,11 @@ int fio_mutex_down_timeout(struct fio_mutex *mutex, unsigned int seconds)
        struct timespec t;
        int ret = 0;
 
+#ifdef FIO_HAVE_CLOCK_MONOTONIC
        clock_gettime(CLOCK_MONOTONIC, &t);
+#else
+       clock_gettime(CLOCK_REALTIME, &t);
+#endif
        t.tv_sec += seconds;
 
        pthread_mutex_lock(&mutex->lock);