No need to do fadvise() on O_DIRECT/raw IO

[fio.git] / log.c

diff --git a/log.c b/log.c
index 91ac0830582625af31a8c78c730ee78ffc53ccd8..6de98ac2900a9bdb0a92dc571d77e188fa140b10 100644 (file)
--- a/log.c
+++ b/log.c
@@ -5,7 +5,7 @@
 
 void write_iolog_put(struct thread_data *td, struct io_u *io_u)
 {
-       fprintf(td->iolog_f, "%d,%llu,%u\n", io_u->ddir, io_u->offset, io_u->buflen);
+       fprintf(td->iolog_f, "%u,%llu,%lu\n", io_u->ddir, io_u->offset, io_u->buflen);
 }
 
 int read_iolog_get(struct thread_data *td, struct io_u *io_u)
@@ -56,7 +56,7 @@ void log_io_piece(struct thread_data *td, struct io_u *io_u)
         * be laid out with the block scattered as written. it's faster to
         * read them in in that order again, so don't sort
         */
-       if (td->sequential || !td->overwrite) {
+       if (!td_random(td) || !td->overwrite) {
                list_add_tail(&ipo->list, &td->io_hist_list);
                return;
        }
@@ -93,7 +93,7 @@ static int init_iolog_read(struct thread_data *td)
        FILE *f;
        int rw, reads, writes;
 
-       f = fopen(td->iolog_file, "r");
+       f = fopen(td->read_iolog_file, "r");
        if (!f) {
                perror("fopen read iolog");
                return 1;
@@ -125,9 +125,9 @@ static int init_iolog_read(struct thread_data *td)
                INIT_LIST_HEAD(&ipo->list);
                ipo->offset = offset;
                ipo->len = bytes;
-               if (bytes > td->max_bs)
-                       td->max_bs = bytes;
-               ipo->ddir = rw;
+               ipo->ddir = (enum fio_ddir) rw;
+               if (bytes > td->max_bs[rw])
+                       td->max_bs[rw] = bytes;
                list_add_tail(&ipo->list, &td->io_log_list);
        }
 
@@ -137,11 +137,11 @@ static int init_iolog_read(struct thread_data *td)
        if (!reads && !writes)
                return 1;
        else if (reads && !writes)
-               td->ddir = DDIR_READ;
+               td->td_ddir = TD_DDIR_READ;
        else if (!reads && writes)
-               td->ddir = DDIR_READ;
+               td->td_ddir = TD_DDIR_READ;
        else
-               td->iomix = 1;
+               td->td_ddir = TD_DDIR_RW;
 
        return 0;
 }
@@ -151,9 +151,9 @@ static int init_iolog_read(struct thread_data *td)
  */
 static int init_iolog_write(struct thread_data *td)
 {
-       FILE *f = fopen(td->iolog_file, "w");
+       FILE *f;
 
-       f = fopen(td->iolog_file, "w");
+       f = fopen(td->write_iolog_file, "w+");
        if (!f) {
                perror("fopen write iolog");
                return 1;
@@ -172,19 +172,22 @@ int init_iolog(struct thread_data *td)
 {
        int ret = 0;
 
-       if (td->read_iolog)
+       if (td->io_ops->flags & FIO_CPUIO)
+               return 0;
+
+       if (td->read_iolog_file)
                ret = init_iolog_read(td);
-       else if (td->write_iolog)
+       else if (td->write_iolog_file)
                ret = init_iolog_write(td);
 
-       free(td->iolog_file);
-       td->iolog_file = NULL;
-       return 0;
+       return ret;
 }
 
 int setup_rate(struct thread_data *td)
 {
-       int nr_reads_per_sec;
+       unsigned long long rate;
+       int nr_reads_per_msec;
+       unsigned int bs;
 
        if (!td->rate)
                return 0;
@@ -194,8 +197,21 @@ int setup_rate(struct thread_data *td)
                return -1;
        }
 
-       nr_reads_per_sec = (td->rate * 1024) / td->min_bs;
-       td->rate_usec_cycle = 1000000 / nr_reads_per_sec;
+       if (td_rw(td))
+               bs = td->rw_min_bs;
+       else if (td_read(td))
+               bs = td->min_bs[DDIR_READ];
+       else
+               bs = td->min_bs[DDIR_WRITE];
+
+       rate = td->rate;
+       nr_reads_per_msec = (rate * 1024 * 1000) / bs;
+       if (!nr_reads_per_msec) {
+               log_err("rate lower than supported\n");
+               return -1;
+       }
+
+       td->rate_usec_cycle = 1000000000ULL / nr_reads_per_msec;
        td->rate_pending_usleep = 0;
        return 0;
 }
@@ -210,14 +226,12 @@ void setup_log(struct io_log **log)
        *log = l;
 }
 
-void finish_log(struct thread_data *td, struct io_log *log, const char *name)
+void __finish_log(struct io_log *log, const char *name)
 {
-       char file_name[256];
-       FILE *f;
        unsigned int i;
+       FILE *f;
 
-       snprintf(file_name, 200, "client%d_%s.log", td->thread_number, name);
-       f = fopen(file_name, "w");
+       f = fopen(name, "w");
        if (!f) {
                perror("fopen log");
                return;
@@ -230,3 +244,11 @@ void finish_log(struct thread_data *td, struct io_log *log, const char *name)
        free(log->log);
        free(log);
 }
+
+void finish_log(struct thread_data *td, struct io_log *log, const char *name)
+{
+       char file_name[256];
+
+       snprintf(file_name, 200, "client%d_%s.log", td->thread_number, name);
+       __finish_log(log, file_name);
+}