client: ensure that cmd line arguments are always run
[fio.git] / init.c
diff --git a/init.c b/init.c
index 2341915831d22eff07b88a468283aa24fe029cc2..c4d6a1ee150860de95c322d945a9731a519d181c 100644 (file)
--- a/init.c
+++ b/init.c
@@ -37,6 +37,7 @@ static char fio_version_string[] =    __fio_stringify(FIO_MAJOR) "."  \
 static char **ini_file;
 static int max_jobs = FIO_MAX_JOBS;
 static int dump_cmdline;
+static int def_timeout;
 
 static struct thread_data def_thread;
 struct thread_data *threads = NULL;
@@ -69,6 +70,26 @@ unsigned int *fio_debug_jobp = NULL;
 
 static char cmd_optstr[256];
 
+const fio_fp64_t def_percentile_list[FIO_IO_U_LIST_MAX_LEN] = {
+       { .u.f  =  1.0 },
+       { .u.f  =  5.0 },
+       { .u.f  = 10.0 },
+       { .u.f  = 20.0 },
+       { .u.f  = 30.0 },
+       { .u.f  = 40.0 },
+       { .u.f  = 50.0 },
+       { .u.f  = 60.0 },
+       { .u.f  = 70.0 },
+       { .u.f  = 80.0 },
+       { .u.f  = 90.0 },
+       { .u.f  = 95.0 },
+       { .u.f  = 99.0 },
+       { .u.f  = 99.5 },
+       { .u.f  = 99.9 },
+};
+
+#define FIO_CLIENT_FLAG                (1 << 16)
+
 /*
  * Command line options. These will contain the above, plus a few
  * extra that only pertain to fio itself and not jobs.
@@ -77,92 +98,92 @@ static struct option l_opts[FIO_NR_OPTIONS] = {
        {
                .name           = (char *) "output",
                .has_arg        = required_argument,
-               .val            = 'o',
+               .val            = 'o' | FIO_CLIENT_FLAG,
        },
        {
                .name           = (char *) "timeout",
                .has_arg        = required_argument,
-               .val            = 't',
+               .val            = 't' | FIO_CLIENT_FLAG,
        },
        {
                .name           = (char *) "latency-log",
                .has_arg        = required_argument,
-               .val            = 'l',
+               .val            = 'l' | FIO_CLIENT_FLAG,
        },
        {
                .name           = (char *) "bandwidth-log",
                .has_arg        = required_argument,
-               .val            = 'b',
+               .val            = 'b' | FIO_CLIENT_FLAG,
        },
        {
                .name           = (char *) "minimal",
                .has_arg        = optional_argument,
-               .val            = 'm',
+               .val            = 'm' | FIO_CLIENT_FLAG,
        },
        {
                .name           = (char *) "version",
                .has_arg        = no_argument,
-               .val            = 'v',
+               .val            = 'v' | FIO_CLIENT_FLAG,
        },
        {
                .name           = (char *) "help",
                .has_arg        = no_argument,
-               .val            = 'h',
+               .val            = 'h' | FIO_CLIENT_FLAG,
        },
        {
                .name           = (char *) "cmdhelp",
                .has_arg        = optional_argument,
-               .val            = 'c',
+               .val            = 'c' | FIO_CLIENT_FLAG,
        },
        {
                .name           = (char *) "showcmd",
                .has_arg        = no_argument,
-               .val            = 's',
+               .val            = 's' | FIO_CLIENT_FLAG,
        },
        {
                .name           = (char *) "readonly",
                .has_arg        = no_argument,
-               .val            = 'r',
+               .val            = 'r' | FIO_CLIENT_FLAG,
        },
        {
                .name           = (char *) "eta",
                .has_arg        = required_argument,
-               .val            = 'e',
+               .val            = 'e' | FIO_CLIENT_FLAG,
        },
        {
                .name           = (char *) "debug",
                .has_arg        = required_argument,
-               .val            = 'd',
+               .val            = 'd' | FIO_CLIENT_FLAG,
        },
        {
                .name           = (char *) "section",
                .has_arg        = required_argument,
-               .val            = 'x',
+               .val            = 'x' | FIO_CLIENT_FLAG,
        },
        {
                .name           = (char *) "alloc-size",
                .has_arg        = required_argument,
-               .val            = 'a',
+               .val            = 'a' | FIO_CLIENT_FLAG,
        },
        {
                .name           = (char *) "profile",
                .has_arg        = required_argument,
-               .val            = 'p',
+               .val            = 'p' | FIO_CLIENT_FLAG,
        },
        {
                .name           = (char *) "warnings-fatal",
                .has_arg        = no_argument,
-               .val            = 'w',
+               .val            = 'w' | FIO_CLIENT_FLAG,
        },
        {
                .name           = (char *) "max-jobs",
                .has_arg        = required_argument,
-               .val            = 'j',
+               .val            = 'j' | FIO_CLIENT_FLAG,
        },
        {
                .name           = (char *) "terse-version",
                .has_arg        = required_argument,
-               .val            = 'V',
+               .val            = 'V' | FIO_CLIENT_FLAG,
        },
        {
                .name           = (char *) "server",
@@ -718,9 +739,9 @@ static int add_job(struct thread_data *td, const char *jobname, int job_add_num)
 
        td->ts.clat_percentiles = td->o.clat_percentiles;
        if (td->o.overwrite_plist)
-               td->ts.percentile_list = td->o.percentile_list;
+               memcpy(td->ts.percentile_list, td->o.percentile_list, sizeof(td->o.percentile_list));
        else
-               td->ts.percentile_list = NULL;
+               memcpy(td->ts.percentile_list, def_percentile_list, sizeof(def_percentile_list));
 
        td->ts.clat_stat[0].min_val = td->ts.clat_stat[1].min_val = ULONG_MAX;
        td->ts.slat_stat[0].min_val = td->ts.slat_stat[1].min_val = ULONG_MAX;
@@ -749,6 +770,8 @@ static int add_job(struct thread_data *td, const char *jobname, int job_add_num)
        }
        if (td->o.write_bw_log)
                setup_log(&td->bw_log);
+       if (td->o.write_iops_log)
+               setup_log(&td->iops_log);
 
        if (!td->o.name)
                td->o.name = strdup(jobname);
@@ -1065,6 +1088,7 @@ static int fill_def_thread(void)
        memset(&def_thread, 0, sizeof(def_thread));
 
        fio_getaffinity(getpid(), &def_thread.o.cpumask);
+       def_thread.o.timeout = def_timeout;
 
        /*
         * fill default options
@@ -1205,6 +1229,28 @@ static void fio_options_fill_optstring(void)
        ostr[c] = '\0';
 }
 
+static int client_flag_set(char c)
+{
+       int i;
+
+       i = 0;
+       while (l_opts[i].name) {
+               int val = l_opts[i].val;
+
+               if (c == (val & 0xff))
+                       return (val & FIO_CLIENT_FLAG);
+
+               i++;
+       }
+
+       return 0;
+}
+
+int parse_cmd_client(char *client, char *opt)
+{
+       return fio_client_add_cmd_option(client, opt);
+}
+
 int parse_cmd_line(int argc, char *argv[])
 {
        struct thread_data *td = NULL;
@@ -1214,26 +1260,36 @@ int parse_cmd_line(int argc, char *argv[])
        char *cur_client = NULL;
        int backend = 0;
 
+       /*
+        * Reset optind handling, since we may call this multiple times
+        * for the backend.
+        */
+       optind = 1;
+
        while ((c = getopt_long_only(argc, argv, ostr, l_opts, &lidx)) != -1) {
+               if ((c & FIO_CLIENT_FLAG) || client_flag_set(c)) {
+                       if (parse_cmd_client(cur_client, argv[optind - 1])) {
+                               exit_val = 1;
+                               do_exit++;
+                               break;
+                       }
+                       c &= ~FIO_CLIENT_FLAG;
+               }
+
                switch (c) {
                case 'a':
-                       fio_client_add_cmd_option(cur_client, argv[optind-1]);
                        smalloc_pool_size = atoi(optarg);
                        break;
                case 't':
-                       fio_client_add_cmd_option(cur_client, argv[optind-1]);
-                       def_thread.o.timeout = atoi(optarg);
+                       def_timeout = atoi(optarg);
                        break;
                case 'l':
-                       fio_client_add_cmd_option(cur_client, argv[optind-1]);
                        write_lat_log = 1;
                        break;
                case 'b':
-                       fio_client_add_cmd_option(cur_client, argv[optind-1]);
                        write_bw_log = 1;
                        break;
                case 'o':
-                       fio_client_add_cmd_option(cur_client, argv[optind-1]);
                        f_out = fopen(optarg, "w+");
                        if (!f_out) {
                                perror("fopen output");
@@ -1242,27 +1298,30 @@ int parse_cmd_line(int argc, char *argv[])
                        f_err = f_out;
                        break;
                case 'm':
-                       fio_client_add_cmd_option(cur_client, argv[optind-1]);
                        terse_output = 1;
                        break;
                case 'h':
-                       usage(argv[0]);
-                       exit(0);
+                       if (!cur_client)
+                               usage(argv[0]);
+                       do_exit++;
+                       break;
                case 'c':
-                       exit(fio_show_option_help(optarg));
+                       if (!cur_client)
+                               fio_show_option_help(optarg);
+                       do_exit++;
+                       break;
                case 's':
-                       fio_client_add_cmd_option(cur_client, argv[optind-1]);
                        dump_cmdline = 1;
                        break;
                case 'r':
-                       fio_client_add_cmd_option(cur_client, argv[optind-1]);
                        read_only = 1;
                        break;
                case 'v':
-                       log_info("%s\n", fio_version_string);
-                       exit(0);
+                       if (!cur_client)
+                               log_info("%s\n", fio_version_string);
+                       do_exit++;
+                       break;
                case 'V':
-                       fio_client_add_cmd_option(cur_client, argv[optind-1]);
                        terse_version = atoi(optarg);
                        if (terse_version != 2) {
                                log_err("fio: bad terse version format\n");
@@ -1271,22 +1330,18 @@ int parse_cmd_line(int argc, char *argv[])
                        }
                        break;
                case 'e':
-                       fio_client_add_cmd_option(cur_client, argv[optind-1]);
                        if (!strcmp("always", optarg))
                                eta_print = FIO_ETA_ALWAYS;
                        else if (!strcmp("never", optarg))
                                eta_print = FIO_ETA_NEVER;
                        break;
                case 'd':
-                       fio_client_add_cmd_option(cur_client, argv[optind-1]);
                        if (set_debug(optarg))
                                do_exit++;
                        break;
                case 'x': {
                        size_t new_size;
 
-                       fio_client_add_cmd_option(cur_client, argv[optind-1]);
-
                        if (!strcmp(optarg, "global")) {
                                log_err("fio: can't use global as only "
                                        "section\n");
@@ -1301,15 +1356,12 @@ int parse_cmd_line(int argc, char *argv[])
                        break;
                        }
                case 'p':
-                       fio_client_add_cmd_option(cur_client, argv[optind-1]);
                        exec_profile = strdup(optarg);
                        break;
                case FIO_GETOPT_JOB: {
                        const char *opt = l_opts[lidx].name;
                        char *val = optarg;
 
-                       fio_client_add_cmd_option(cur_client, argv[optind-1]);
-
                        if (!strncmp(opt, "name", 4) && td) {
                                ret = add_job(td, td->o.name ?: "fio", 0);
                                if (ret)
@@ -1335,11 +1387,9 @@ int parse_cmd_line(int argc, char *argv[])
                        break;
                }
                case 'w':
-                       fio_client_add_cmd_option(cur_client, argv[optind-1]);
                        warnings_fatal = 1;
                        break;
                case 'j':
-                       fio_client_add_cmd_option(cur_client, argv[optind-1]);
                        max_jobs = atoi(optarg);
                        if (!max_jobs || max_jobs > REAL_MAX_JOBS) {
                                log_err("fio: invalid max jobs: %d\n", max_jobs);
@@ -1382,8 +1432,10 @@ int parse_cmd_line(int argc, char *argv[])
                        break;
        }
 
-       if (do_exit)
-               exit(exit_val);
+       if (do_exit) {
+               if (exit_val && !(is_backend || nr_clients))
+                       exit(exit_val);
+       }
 
        if (nr_clients && fio_clients_connect()) {
                do_exit++;
@@ -1453,10 +1505,8 @@ int parse_options(int argc, char *argv[])
                if (is_backend || nr_clients)
                        return 0;
 
-               if (job_files > 0) {
-                       log_err("No jobs(s) defined\n\n");
-                       usage(argv[0]);
-               }
+               log_err("No jobs(s) defined\n\n");
+               usage(argv[0]);
                return 1;
        }