#include <ctype.h>
#include <string.h>
#include <errno.h>
-#include <getopt.h>
#include <sys/ipc.h>
#include <sys/shm.h>
#include <sys/types.h>
#include "verify.h"
#include "profile.h"
-static char fio_version_string[] = "fio 1.41.3";
+#include "lib/getopt.h"
+
+static char fio_version_string[] = "fio 1.50-rc4";
#define FIO_RANDSEED (0xb1899bedUL)
FILE *f_err = NULL;
char *job_section = NULL;
char *exec_profile = NULL;
+int warnings_fatal = 0;
int write_bw_log = 0;
int read_only = 0;
unsigned int fio_debug_jobno = -1;
unsigned int *fio_debug_jobp = NULL;
+static char cmd_optstr[256];
+
/*
* Command line options. These will contain the above, plus a few
* extra that only pertain to fio itself and not jobs.
.has_arg = required_argument,
.val = 'p',
},
+ {
+ .name = "warnings-fatal",
+ .has_arg = no_argument,
+ .val = 'w',
+ },
{
.name = NULL,
},
if (global)
return &def_thread;
- if (thread_number >= max_jobs)
+ if (thread_number >= max_jobs) {
+ log_err("error: maximum number of jobs (%d) reached.\n",
+ max_jobs);
return NULL;
+ }
td = &threads[thread_number++];
*td = *parent;
unsigned int bs = td->o.min_bs[ddir];
unsigned long long bytes_per_sec;
+ assert(ddir_rw(ddir));
+
if (td->o.rate[ddir])
bytes_per_sec = td->o.rate[ddir];
else
static int fixup_options(struct thread_data *td)
{
struct thread_options *o = &td->o;
+ int ret = 0;
#ifndef FIO_HAVE_PSHARED_MUTEX
if (!o->use_thread) {
" mutexes, forcing use of threads. Use the 'thread'"
" option to get rid of this warning.\n");
o->use_thread = 1;
+ ret = warnings_fatal;
}
#endif
log_err("fio: read iolog overrides write_iolog\n");
free(o->write_iolog_file);
o->write_iolog_file = NULL;
+ ret = warnings_fatal;
}
/*
!o->norandommap) {
log_err("fio: Any use of blockalign= turns off randommap\n");
o->norandommap = 1;
+ ret = warnings_fatal;
}
if (!o->file_size_high)
log_err("fio: norandommap given for variable block sizes, "
"verify disabled\n");
o->verify = VERIFY_NONE;
+ ret = warnings_fatal;
}
if (o->bs_unaligned && (o->odirect || td->io_ops->flags & FIO_RAWIO))
log_err("fio: bs_unaligned may not work with raw io\n");
((o->ratemin[0] + o->ratemin[1]) && (o->rate_iops_min[0] +
o->rate_iops_min[1]))) {
log_err("fio: rate and rate_iops are mutually exclusive\n");
- return 1;
+ ret = 1;
}
if ((o->rate[0] < o->ratemin[0]) || (o->rate[1] < o->ratemin[1]) ||
(o->rate_iops[0] < o->rate_iops_min[0]) ||
(o->rate_iops[1] < o->rate_iops_min[1])) {
log_err("fio: minimum rate exceeds rate\n");
- return 1;
+ ret = 1;
}
if (!o->timeout && o->time_based) {
log_err("fio: time_based requires a runtime/timeout setting\n");
o->time_based = 0;
+ ret = warnings_fatal;
}
if (o->fill_device && !o->size)
o->size = -1ULL;
- if (td_rw(td) && o->verify != VERIFY_NONE)
- log_info("fio: mixed read/write workload with verify. May not "
- "work as expected, unless you pre-populated the file\n");
-
if (o->verify != VERIFY_NONE) {
+ if (td_rw(td)) {
+ log_info("fio: mixed read/write workload with verify. "
+ "May not work as expected, unless you "
+ "pre-populated the file\n");
+ ret = warnings_fatal;
+ }
+ if (td_write(td) && o->do_verify && o->numjobs > 1) {
+ log_info("Multiple writers may overwrite blocks that "
+ "belong to other jobs. This can cause "
+ "verification failures.\n");
+ ret = warnings_fatal;
+ }
+
o->refill_buffers = 1;
if (o->max_bs[DDIR_WRITE] != o->min_bs[DDIR_WRITE] &&
!o->verify_interval)
if (o->pre_read) {
o->invalidate_cache = 0;
- if (td->io_ops->flags & FIO_PIPEIO)
+ if (td->io_ops->flags & FIO_PIPEIO) {
log_info("fio: cannot pre-read files with an IO engine"
" that isn't seekable. Pre-read disabled.\n");
+ ret = warnings_fatal;
+ }
}
#ifndef FIO_HAVE_FDATASYNC
" this warning\n");
o->fsync_blocks = o->fdatasync_blocks;
o->fdatasync_blocks = 0;
+ ret = warnings_fatal;
}
#endif
- return 0;
+ return ret;
}
/*
if (lstat(filename, &sb) == -1)
return 0;
- if (S_ISREG(sb.st_mode))
+ /* \\.\ is the device namespace in Windows, where every file
+ * is a device node */
+ if (S_ISREG(sb.st_mode) && strncmp(filename, "\\\\.\\", 4) != 0)
return 0;
return 1;
os_random_seed(td->rand_seeds[3], &td->next_file_state);
os_random_seed(td->rand_seeds[5], &td->file_size_state);
+ os_random_seed(td->rand_seeds[6], &td->trim_state);
if (!td_random(td))
return;
td->ts.clat_stat[0].min_val = td->ts.clat_stat[1].min_val = ULONG_MAX;
td->ts.slat_stat[0].min_val = td->ts.slat_stat[1].min_val = ULONG_MAX;
+ td->ts.lat_stat[0].min_val = td->ts.lat_stat[1].min_val = ULONG_MAX;
td->ts.bw_stat[0].min_val = td->ts.bw_stat[1].min_val = ULONG_MAX;
- td->ddir_nr = td->o.ddir_nr;
+ td->ddir_seq_nr = td->o.ddir_seq_nr;
if ((td->o.stonewall || td->o.new_group) && prev_group_jobs) {
prev_group_jobs = 0;
goto err;
if (td->o.write_lat_log) {
+ setup_log(&td->ts.lat_log);
setup_log(&td->ts.slat_log);
setup_log(&td->ts.clat_log);
}
static void usage(const char *name)
{
- printf("%s\n", fio_version_string);
printf("%s [options] [job options] <job file(s)>\n", name);
printf("\t--debug=options\tEnable debug logging\n");
printf("\t--output\tWrite output to file\n");
printf("\t--section=name\tOnly run specified section in job file\n");
printf("\t--alloc-size=kb\tSet smalloc pool to this size in kb"
" (def 1024)\n");
+ printf("\t--warnings-fatal Fio parser warnings are fatal\n");
printf("\nFio was written by Jens Axboe <jens.axboe@oracle.com>");
printf("\n Jens Axboe <jaxboe@fusionio.com>\n");
}
int i;
if (!strcmp(string, "?") || !strcmp(string, "help")) {
- int i;
-
log_info("fio: dumping debug options:");
for (i = 0; debug_levels[i].name; i++) {
dl = &debug_levels[i];
}
#endif
+static void fio_options_fill_optstring(void)
+{
+ char *ostr = cmd_optstr;
+ int i, c;
+
+ c = i = 0;
+ while (l_opts[i].name) {
+ ostr[c++] = l_opts[i].val;
+ if (l_opts[i].has_arg == required_argument)
+ ostr[c++] = ':';
+ else if (l_opts[i].has_arg == optional_argument) {
+ ostr[c++] = ':';
+ ostr[c++] = ':';
+ }
+ i++;
+ }
+ ostr[c] = '\0';
+}
+
static int parse_cmd_line(int argc, char *argv[])
{
struct thread_data *td = NULL;
int c, ini_idx = 0, lidx, ret = 0, do_exit = 0, exit_val = 0;
+ char *ostr = cmd_optstr;
- while ((c = getopt_long_only(argc, argv, "", l_opts, &lidx)) != -1) {
+ while ((c = getopt_long_only(argc, argv, ostr, l_opts, &lidx)) != -1) {
switch (c) {
case 'a':
smalloc_pool_size = atoi(optarg);
read_only = 1;
break;
case 'v':
- printf("%s\n", fio_version_string);
+ /* already being printed, just quit */
exit(0);
case 'e':
if (!strcmp("always", optarg))
ret = fio_cmd_option_parse(td, opt, val);
break;
}
+ case 'w':
+ warnings_fatal = 1;
+ break;
default:
do_exit++;
exit_val = 1;
f_out = stdout;
f_err = stderr;
+ log_info("%s\n", fio_version_string);
+
+ fio_options_fill_optstring();
fio_options_dup_and_init(l_opts);
if (setup_thread_area())
if (exec_profile)
return 0;
- log_err("No jobs defined(s)\n\n");
+ log_err("No jobs(s) defined\n\n");
usage(argv[0]);
return 1;
}
projects / fio.git / blobdiff