gfio: add support for graph tooltips
[fio.git] / gfio.c
diff --git a/gfio.c b/gfio.c
index f6f8eb1d771559edd32ea0aafc4c89321d318b4c..76bbbf5c340b985fd19e78f5fa55b7a66dfbb37e 100644 (file)
--- a/gfio.c
+++ b/gfio.c
@@ -68,11 +68,18 @@ struct probe_widget {
        GtkWidget *fio_ver;
 };
 
+struct multitext_widget {
+       GtkWidget *entry;
+       char **text;
+       unsigned int cur_text;
+       unsigned int max_text;
+};
+
 struct eta_widget {
        GtkWidget *names;
-       GtkWidget *iotype;
-       GtkWidget *ioengine;
-       GtkWidget *iodepth;
+       struct multitext_widget iotype;
+       struct multitext_widget ioengine;
+       struct multitext_widget iodepth;
        GtkWidget *jobs;
        GtkWidget *files;
        GtkWidget *read_bw;
@@ -89,9 +96,6 @@ struct gfio_graphs {
 #define DRAWING_AREA_XDIM 1000
 #define DRAWING_AREA_YDIM 400
        GtkWidget *drawing_area;
-       int drawing_area_xdim;
-       int drawing_area_ydim;
-
        struct graph *iops_graph;
        struct graph *bandwidth_graph;
 };
@@ -100,6 +104,8 @@ struct gfio_graphs {
  * Main window widgets and data
  */
 struct gui {
+       GtkUIManager *uimanager;
+       GtkWidget *menu;
        GtkWidget *window;
        GtkWidget *vbox;
        GtkWidget *topvbox;
@@ -125,6 +131,15 @@ struct gui {
        struct flist_head list;
 } main_ui;
 
+enum {
+       GE_STATE_NEW = 1,
+       GE_STATE_CONNECTED,
+       GE_STATE_JOB_SENT,
+       GE_STATE_JOB_STARTED,
+       GE_STATE_JOB_RUNNING,
+       GE_STATE_JOB_DONE,
+};
+
 /*
  * Notebook entry
  */
@@ -136,6 +151,7 @@ struct gui_entry {
        GtkWidget *topvbox;
        GtkWidget *topalign;
        GtkWidget *bottomalign;
+       GtkWidget *job_notebook;
        GtkWidget *thread_status_pb;
        GtkWidget *buttonbox;
        GtkWidget *button[ARRAYSIZE(buttonspeclist)];
@@ -153,7 +169,7 @@ struct gui_entry {
        struct eta_widget eta;
        GtkWidget *page_label;
        gint page_num;
-       int connected;
+       unsigned int state;
 
        struct gfio_client *client;
        int nr_job_files;
@@ -174,6 +190,21 @@ static void gfio_update_thread_status(struct gui_entry *ge, char *status_message
 static void gfio_update_thread_status_all(char *status_message, double perc);
 void report_error(GError *error);
 
+static void iops_graph_y_axis_unit_change(struct graph *g, int power_of_ten)
+{
+       switch (power_of_ten) {
+               case 9: graph_y_title(g, "Billions of IOs / sec");
+                       break;
+               case 6: graph_y_title(g, "Millions of IOs / sec");
+                       break;
+               case 3: graph_y_title(g, "Thousands of IOs / sec");
+                       break;
+               case 0:
+               default: graph_y_title(g, "IOs / sec");
+                       break;
+       }
+}
+
 static struct graph *setup_iops_graph(void)
 {
        struct graph *g;
@@ -187,9 +218,26 @@ static struct graph *setup_iops_graph(void)
        graph_set_color(g, "Read IOPS", 0.13, 0.54, 0.13);
        graph_set_color(g, "Write IOPS", 1.0, 0.0, 0.0);
        line_graph_set_data_count_limit(g, gfio_graph_limit);
+       graph_y_axis_unit_change_notify(g, iops_graph_y_axis_unit_change);
+       graph_add_extra_space(g, 0.005, 0.005, 0.03, 0.03);
        return g;
 }
 
+static void bandwidth_graph_y_axis_unit_change(struct graph *g, int power_of_ten)
+{
+       switch (power_of_ten) {
+               case 9: graph_y_title(g, "Petabytes / sec");
+                       break;
+               case 6: graph_y_title(g, "Gigabytes / sec");
+                       break;
+               case 3: graph_y_title(g, "Megabytes / sec");
+                       break;
+               case 0:
+               default: graph_y_title(g, "Kilobytes / sec");
+                       break;
+       }
+}
+
 static struct graph *setup_bandwidth_graph(void)
 {
        struct graph *g;
@@ -203,6 +251,9 @@ static struct graph *setup_bandwidth_graph(void)
        graph_set_color(g, "Read Bandwidth", 0.13, 0.54, 0.13);
        graph_set_color(g, "Write Bandwidth", 1.0, 0.0, 0.0);
        line_graph_set_data_count_limit(g, 100);
+       graph_y_axis_unit_change_notify(g, bandwidth_graph_y_axis_unit_change);
+       graph_add_extra_space(g, 0.005, 0.005, 0.03, 0.03);
+
        return g;
 }
 
@@ -212,6 +263,54 @@ static void setup_graphs(struct gfio_graphs *g)
        g->bandwidth_graph = setup_bandwidth_graph();
 }
 
+static void multitext_add_entry(struct multitext_widget *mt, const char *text)
+{
+       mt->text = realloc(mt->text, (mt->max_text + 1) * sizeof(char *));
+       mt->text[mt->max_text] = strdup(text);
+       mt->max_text++;
+}
+
+static void multitext_set_entry(struct multitext_widget *mt, unsigned int index)
+{
+       if (index >= mt->max_text)
+               return;
+       if (!mt->text || !mt->text[index])
+               return;
+
+       mt->cur_text = index;
+       gtk_entry_set_text(GTK_ENTRY(mt->entry), mt->text[index]);
+}
+
+static void multitext_update_entry(struct multitext_widget *mt,
+                                  unsigned int index, const char *text)
+{
+       if (!mt->text)
+               return;
+
+       if (mt->text[index])
+               free(mt->text[index]);
+
+       mt->text[index] = strdup(text);
+       if (mt->cur_text == index)
+               gtk_entry_set_text(GTK_ENTRY(mt->entry), mt->text[index]);
+}
+
+static void multitext_free(struct multitext_widget *mt)
+{
+       int i;
+
+       gtk_entry_set_text(GTK_ENTRY(mt->entry), "");
+
+       for (i = 0; i < mt->max_text; i++) {
+               if (mt->text[i])
+                       free(mt->text[i]);
+       }
+
+       free(mt->text);
+       mt->cur_text = -1;
+       mt->max_text = 0;
+}
+
 static void clear_ge_ui_info(struct gui_entry *ge)
 {
        gtk_label_set_text(GTK_LABEL(ge->probe.hostname), "");
@@ -222,9 +321,9 @@ static void clear_ge_ui_info(struct gui_entry *ge)
        /* should we empty it... */
        gtk_entry_set_text(GTK_ENTRY(ge->eta.name), "");
 #endif
-       gtk_entry_set_text(GTK_ENTRY(ge->eta.iotype), "");
-       gtk_entry_set_text(GTK_ENTRY(ge->eta.ioengine), "");
-       gtk_entry_set_text(GTK_ENTRY(ge->eta.iodepth), "");
+       multitext_update_entry(&ge->eta.iotype, 0, "");
+       multitext_update_entry(&ge->eta.ioengine, 0, "");
+       multitext_update_entry(&ge->eta.iodepth, 0, "");
        gtk_entry_set_text(GTK_ENTRY(ge->eta.jobs), "");
        gtk_entry_set_text(GTK_ENTRY(ge->eta.files), "");
        gtk_entry_set_text(GTK_ENTRY(ge->eta.read_bw), "");
@@ -287,22 +386,6 @@ static GtkWidget *create_spinbutton(GtkWidget *hbox, double min, double max, dou
        return button;
 }
 
-static void gfio_set_connected(struct gui_entry *ge, int connected)
-{
-       if (connected) {
-               gtk_widget_set_sensitive(ge->button[SEND_BUTTON], 1);
-               ge->connected = 1;
-               gtk_button_set_label(GTK_BUTTON(ge->button[CONNECT_BUTTON]), "Disconnect");
-               gtk_widget_set_sensitive(ge->button[CONNECT_BUTTON], 1);
-       } else {
-               ge->connected = 0;
-               gtk_button_set_label(GTK_BUTTON(ge->button[CONNECT_BUTTON]), "Connect");
-               gtk_widget_set_sensitive(ge->button[SEND_BUTTON], 0);
-               gtk_widget_set_sensitive(ge->button[START_JOB_BUTTON], 0);
-               gtk_widget_set_sensitive(ge->button[CONNECT_BUTTON], 1);
-       }
-}
-
 static void label_set_int_value(GtkWidget *entry, unsigned int val)
 {
        char tmp[80];
@@ -319,6 +402,119 @@ static void entry_set_int_value(GtkWidget *entry, unsigned int val)
        gtk_entry_set_text(GTK_ENTRY(entry), tmp);
 }
 
+static void show_info_dialog(struct gui *ui, const char *title,
+                            const char *message)
+{
+       GtkWidget *dialog, *content, *label;
+
+       dialog = gtk_dialog_new_with_buttons(title, GTK_WINDOW(ui->window),
+                       GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT,
+                       GTK_STOCK_OK, GTK_RESPONSE_OK, NULL);
+
+       content = gtk_dialog_get_content_area(GTK_DIALOG(dialog));
+       label = gtk_label_new(message);
+       gtk_container_add(GTK_CONTAINER(content), label);
+       gtk_widget_show_all(dialog);
+       gtk_dialog_set_default_response(GTK_DIALOG(dialog), GTK_RESPONSE_ACCEPT);
+       gtk_dialog_run(GTK_DIALOG(dialog));
+       gtk_widget_destroy(dialog);
+}
+
+/*
+ * Update sensitivity of job buttons and job menu items, based on the
+ * state of the client.
+ */
+static void update_button_states(struct gui *ui, struct gui_entry *ge)
+{
+       unsigned int connect_state, send_state, start_state, edit_state;
+       const char *connect_str = NULL;
+       GtkWidget *w;
+
+       switch (ge->state) {
+       default: {
+               char tmp[80];
+
+               sprintf(tmp, "Bad client state: %u\n", ge->state);
+               show_info_dialog(ui, "Error", tmp);
+               /* fall through to new state */
+               }
+
+       case GE_STATE_NEW:
+               connect_state = 1;
+               edit_state = 0;
+               connect_str = "Connect";
+               send_state = 0;
+               start_state = 0;
+               break;
+       case GE_STATE_CONNECTED:
+               connect_state = 1;
+               edit_state = 0;
+               connect_str = "Disconnect";
+               send_state = 1;
+               start_state = 0;
+               break;
+       case GE_STATE_JOB_SENT:
+               connect_state = 1;
+               edit_state = 0;
+               connect_str = "Disconnect";
+               send_state = 0;
+               start_state = 1;
+               break;
+       case GE_STATE_JOB_STARTED:
+               connect_state = 1;
+               edit_state = 1;
+               connect_str = "Disconnect";
+               send_state = 0;
+               start_state = 1;
+               break;
+       case GE_STATE_JOB_RUNNING:
+               connect_state = 1;
+               edit_state = 0;
+               connect_str = "Disconnect";
+               send_state = 0;
+               start_state = 0;
+               break;
+       case GE_STATE_JOB_DONE:
+               connect_state = 1;
+               edit_state = 0;
+               connect_str = "Connect";
+               send_state = 0;
+               start_state = 0;
+               break;
+       }
+
+       gtk_widget_set_sensitive(ge->button[CONNECT_BUTTON], connect_state);
+       gtk_widget_set_sensitive(ge->button[SEND_BUTTON], send_state);
+       gtk_widget_set_sensitive(ge->button[START_JOB_BUTTON], start_state);
+       gtk_button_set_label(GTK_BUTTON(ge->button[CONNECT_BUTTON]), connect_str);
+
+       /*
+        * So the below doesn't work at all, how to set those menu items
+        * invisibible...
+        */
+       w = gtk_ui_manager_get_widget(ui->uimanager, "/MainMenu/JobMenu/Connect");
+       if (w)
+               gtk_widget_set_sensitive(w, connect_state);
+
+       w = gtk_ui_manager_get_widget(ui->uimanager, "/MainMenu/JobMenu/Edit job");
+       if (w)
+               gtk_widget_set_sensitive(w, edit_state);
+
+       w = gtk_ui_manager_get_widget(ui->uimanager, "/MainMenu/JobMenu/Send job");
+       if (w)
+               gtk_widget_set_sensitive(w, send_state);
+
+       w = gtk_ui_manager_get_widget(ui->uimanager, "/MainMenu/JobMenu/Start job");
+       if (w)
+               gtk_widget_set_sensitive(w, start_state);
+}
+
+static void gfio_set_state(struct gui_entry *ge, unsigned int state)
+{
+       ge->state = state;
+       update_button_states(ge->ui, ge);
+}
+
 #define ALIGN_LEFT 1
 #define ALIGN_RIGHT 2
 #define INVISIBLE 4
@@ -1098,35 +1294,55 @@ static gint on_config_drawing_area(GtkWidget *w, GdkEventConfigure *event,
 {
        struct gfio_graphs *g = data;
 
-       g->drawing_area_xdim = w->allocation.width;
-       g->drawing_area_ydim = w->allocation.height;
+       graph_set_size(g->iops_graph, w->allocation.width / 2.0, w->allocation.height);
+       graph_set_position(g->iops_graph, w->allocation.width / 2.0, 0.0);
+       graph_set_size(g->bandwidth_graph, w->allocation.width / 2.0, w->allocation.height);
+       graph_set_position(g->bandwidth_graph, 0, 0);
        return TRUE;
 }
 
+static void draw_graph(struct graph *g, cairo_t *cr)
+{
+       line_graph_draw(g, cr);
+       cairo_stroke(cr);
+}
+
+static gboolean graph_tooltip(GtkWidget *w, gint x, gint y,
+                             gboolean keyboard_mode, GtkTooltip *tooltip,
+                             gpointer data)
+{
+       struct gfio_graphs *g = data;
+       const char *text = NULL;
+
+       if (graph_contains_xy(g->iops_graph, x, y))
+               text = graph_find_tooltip(g->iops_graph, x, y);
+       else if (graph_contains_xy(g->bandwidth_graph, x, y))
+               text = graph_find_tooltip(g->bandwidth_graph, x, y);
+
+       if (text) {
+               gtk_tooltip_set_text(tooltip, text);
+               return TRUE;
+       }
+
+       return FALSE;
+}
+
 static int on_expose_drawing_area(GtkWidget *w, GdkEvent *event, gpointer p)
 {
        struct gfio_graphs *g = p;
        cairo_t *cr;
 
-       graph_set_size(g->iops_graph, g->drawing_area_xdim / 2.0,
-                                       g->drawing_area_ydim);
-       graph_set_size(g->bandwidth_graph, g->drawing_area_xdim / 2.0,
-                                       g->drawing_area_ydim);
        cr = gdk_cairo_create(w->window);
 
-       cairo_set_source_rgb(cr, 0, 0, 0);
-
-       cairo_save(cr);
-       cairo_translate(cr, 0, 0);
-       line_graph_draw(g->bandwidth_graph, cr);
-       cairo_stroke(cr);
-       cairo_restore(cr);
+       if (graph_has_tooltips(g->iops_graph) ||
+           graph_has_tooltips(g->bandwidth_graph)) {
+               g_object_set(w, "has-tooltip", TRUE, NULL);
+               g_signal_connect(w, "query-tooltip", G_CALLBACK(graph_tooltip), g);
+       }
 
-       cairo_save(cr);
-       cairo_translate(cr, g->drawing_area_xdim / 2.0, 0);
-       line_graph_draw(g->iops_graph, cr);
-       cairo_stroke(cr);
-       cairo_restore(cr);
+       cairo_set_source_rgb(cr, 0, 0, 0);
+       draw_graph(g->iops_graph, cr);
+       draw_graph(g->bandwidth_graph, cr);
        cairo_destroy(cr);
 
        return FALSE;
@@ -1204,10 +1420,10 @@ static void gfio_update_client_eta(struct fio_client *client, struct jobs_eta *j
                gtk_entry_set_text(GTK_ENTRY(ge->eta.write_bw), rate_str[1]);
                gtk_entry_set_text(GTK_ENTRY(ge->eta.write_iops), iops_str[1]);
 
-               graph_add_xy_data(ge->graphs.iops_graph, "Read IOPS", je->elapsed_sec, je->iops[0]);
-               graph_add_xy_data(ge->graphs.iops_graph, "Write IOPS", je->elapsed_sec, je->iops[1]);
-               graph_add_xy_data(ge->graphs.bandwidth_graph, "Read Bandwidth", je->elapsed_sec, je->rate[0]);
-               graph_add_xy_data(ge->graphs.bandwidth_graph, "Write Bandwidth", je->elapsed_sec, je->rate[1]);
+               graph_add_xy_data(ge->graphs.iops_graph, "Read IOPS", je->elapsed_sec, je->iops[0], iops_str[0]);
+               graph_add_xy_data(ge->graphs.iops_graph, "Write IOPS", je->elapsed_sec, je->iops[1], iops_str[1]);
+               graph_add_xy_data(ge->graphs.bandwidth_graph, "Read Bandwidth", je->elapsed_sec, je->rate[0], rate_str[0]);
+               graph_add_xy_data(ge->graphs.bandwidth_graph, "Write Bandwidth", je->elapsed_sec, je->rate[1], rate_str[1]);
 
                free(rate_str[0]);
                free(rate_str[1]);
@@ -1292,10 +1508,10 @@ static void gfio_update_all_eta(struct jobs_eta *je)
                gtk_entry_set_text(GTK_ENTRY(ui->eta.write_bw), rate_str[1]);
                gtk_entry_set_text(GTK_ENTRY(ui->eta.write_iops), iops_str[1]);
 
-               graph_add_xy_data(ui->graphs.iops_graph, "Read IOPS", je->elapsed_sec, je->iops[0]);
-               graph_add_xy_data(ui->graphs.iops_graph, "Write IOPS", je->elapsed_sec, je->iops[1]);
-               graph_add_xy_data(ui->graphs.bandwidth_graph, "Read Bandwidth", je->elapsed_sec, je->rate[0]);
-               graph_add_xy_data(ui->graphs.bandwidth_graph, "Write Bandwidth", je->elapsed_sec, je->rate[1]);
+               graph_add_xy_data(ui->graphs.iops_graph, "Read IOPS", je->elapsed_sec, je->iops[0], iops_str[0]);
+               graph_add_xy_data(ui->graphs.iops_graph, "Write IOPS", je->elapsed_sec, je->iops[1], iops_str[1]);
+               graph_add_xy_data(ui->graphs.bandwidth_graph, "Read Bandwidth", je->elapsed_sec, je->rate[0], rate_str[0]);
+               graph_add_xy_data(ui->graphs.bandwidth_graph, "Write Bandwidth", je->elapsed_sec, je->rate[1], rate_str[1]);
 
                free(rate_str[0]);
                free(rate_str[1]);
@@ -1340,7 +1556,7 @@ static void gfio_probe_op(struct fio_client *client, struct fio_net_cmd *cmd)
        sprintf(buf, "%u.%u.%u", probe->fio_major, probe->fio_minor, probe->fio_patch);
        gtk_label_set_text(GTK_LABEL(ge->probe.fio_ver), buf);
 
-       gfio_set_connected(ge, 1);
+       gfio_set_state(ge, GE_STATE_CONNECTED);
 
        gdk_threads_leave();
 }
@@ -1374,7 +1590,7 @@ static void gfio_quit_op(struct fio_client *client)
        struct gfio_client *gc = client->client_data;
 
        gdk_threads_enter();
-       gfio_set_connected(gc->ge, 0);
+       gfio_set_state(gc->ge, GE_STATE_NEW);
        gdk_threads_leave();
 }
 
@@ -1395,45 +1611,35 @@ static void gfio_add_job_op(struct fio_client *client, struct fio_net_cmd *cmd)
        gtk_combo_box_append_text(GTK_COMBO_BOX(ge->eta.names), (gchar *) o->name);
        gtk_combo_box_set_active(GTK_COMBO_BOX(ge->eta.names), 0);
 
-       gtk_entry_set_text(GTK_ENTRY(ge->eta.iotype), ddir_str(o->td_ddir));
-       gtk_entry_set_text(GTK_ENTRY(ge->eta.ioengine), (gchar *) o->ioengine);
+       multitext_add_entry(&ge->eta.iotype, ddir_str(o->td_ddir));
+       multitext_add_entry(&ge->eta.ioengine, (const char *) o->ioengine);
 
        sprintf(tmp, "%u", o->iodepth);
-       gtk_entry_set_text(GTK_ENTRY(ge->eta.iodepth), tmp);
+       multitext_add_entry(&ge->eta.iodepth, tmp);
+
+       multitext_set_entry(&ge->eta.iotype, 0);
+       multitext_set_entry(&ge->eta.ioengine, 0);
+       multitext_set_entry(&ge->eta.iodepth, 0);
 
        gc->job_added++;
 
+       gfio_set_state(ge, GE_STATE_JOB_SENT);
+
        gdk_threads_leave();
 }
 
 static void gfio_client_timed_out(struct fio_client *client)
 {
        struct gfio_client *gc = client->client_data;
-       GtkWidget *dialog, *label, *content;
        char buf[256];
 
        gdk_threads_enter();
 
-       gfio_set_connected(gc->ge, 0);
+       gfio_set_state(gc->ge, GE_STATE_NEW);
        clear_ge_ui_info(gc->ge);
 
        sprintf(buf, "Client %s: timeout talking to server.\n", client->hostname);
-
-       dialog = gtk_dialog_new_with_buttons("Timed out!",
-                       GTK_WINDOW(main_ui.window),
-                       GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT,
-                       GTK_STOCK_OK, GTK_RESPONSE_OK, NULL);
-
-       /* gtk_dialog_get_content_area() is 2.14 and newer */
-       content = GTK_DIALOG(dialog)->vbox;
-
-       label = gtk_label_new((const gchar *) buf);
-       gtk_container_add(GTK_CONTAINER(content), label);
-       gtk_widget_show_all(dialog);
-       gtk_dialog_set_default_response(GTK_DIALOG(dialog), GTK_RESPONSE_ACCEPT);
-
-       gtk_dialog_run(GTK_DIALOG(dialog));
-       gtk_widget_destroy(dialog);
+       show_info_dialog(gc->ge->ui, "Network timeout", buf);
 
        gdk_threads_leave();
 }
@@ -1444,7 +1650,7 @@ static void gfio_client_stop(struct fio_client *client, struct fio_net_cmd *cmd)
 
        gdk_threads_enter();
 
-       gfio_set_connected(gc->ge, 0);
+       gfio_set_state(gc->ge, GE_STATE_JOB_DONE);
 
        if (gc->err_entry)
                entry_set_int_value(gc->err_entry, client->error);
@@ -1452,6 +1658,24 @@ static void gfio_client_stop(struct fio_client *client, struct fio_net_cmd *cmd)
        gdk_threads_leave();
 }
 
+static void gfio_client_start(struct fio_client *client, struct fio_net_cmd *cmd)
+{
+       struct gfio_client *gc = client->client_data;
+
+       gdk_threads_enter();
+       gfio_set_state(gc->ge, GE_STATE_JOB_STARTED);
+       gdk_threads_leave();
+}
+
+static void gfio_client_job_start(struct fio_client *client, struct fio_net_cmd *cmd)
+{
+       struct gfio_client *gc = client->client_data;
+
+       gdk_threads_enter();
+       gfio_set_state(gc->ge, GE_STATE_JOB_RUNNING);
+       gdk_threads_leave();
+}
+
 struct client_ops gfio_client_ops = {
        .text_op                = gfio_text_op,
        .disk_util              = gfio_disk_util_op,
@@ -1464,6 +1688,8 @@ struct client_ops gfio_client_ops = {
        .add_job                = gfio_add_job_op,
        .timed_out              = gfio_client_timed_out,
        .stop                   = gfio_client_stop,
+       .start                  = gfio_client_start,
+       .job_start              = gfio_client_job_start,
        .eta_msec               = FIO_CLIENT_DEF_ETA_MSEC,
        .stay_connected         = 1,
 };
@@ -1539,8 +1765,8 @@ static void start_job_clicked(__attribute__((unused)) GtkWidget *widget,
        struct gui_entry *ge = data;
        struct gfio_client *gc = ge->client;
 
-       gtk_widget_set_sensitive(ge->button[START_JOB_BUTTON], 0);
-       fio_start_client(gc->client);
+       if (gc)
+               fio_start_client(gc->client);
 }
 
 static void file_open(GtkWidget *w, gpointer data);
@@ -1550,11 +1776,11 @@ static void connect_clicked(GtkWidget *widget, gpointer data)
        struct gui_entry *ge = data;
        struct gfio_client *gc = ge->client;
 
-       if (!ge->connected) {
+       if (ge->state == GE_STATE_NEW) {
                int ret;
 
                if (!ge->nr_job_files)
-                       file_open(widget, data);
+                       file_open(widget, ge->ui);
                if (!ge->nr_job_files)
                        return;
 
@@ -1564,8 +1790,7 @@ static void connect_clicked(GtkWidget *widget, gpointer data)
                if (!ret) {
                        if (!ge->ui->handler_running)
                                pthread_create(&ge->ui->t, NULL, job_thread, ge->ui);
-                       gtk_widget_set_sensitive(ge->button[CONNECT_BUTTON], 0);
-                       gtk_widget_set_sensitive(ge->button[SEND_BUTTON], 1);
+                       gfio_set_state(ge, GE_STATE_CONNECTED);
                } else {
                        GError *error;
 
@@ -1575,7 +1800,7 @@ static void connect_clicked(GtkWidget *widget, gpointer data)
                }
        } else {
                fio_client_terminate(gc->client);
-               gfio_set_connected(ge, 0);
+               gfio_set_state(ge, GE_STATE_NEW);
                clear_ge_ui_info(ge);
        }
 }
@@ -1593,9 +1818,6 @@ static void send_clicked(GtkWidget *widget, gpointer data)
 
                gtk_widget_set_sensitive(ge->button[START_JOB_BUTTON], 1);
        }
-
-       gtk_widget_set_sensitive(ge->button[SEND_BUTTON], 0);
-       gtk_widget_set_sensitive(ge->button[START_JOB_BUTTON], 1);
 }
 
 static GtkWidget *add_button(GtkWidget *buttonbox,
@@ -1815,6 +2037,7 @@ static struct gui_entry *alloc_new_gui_entry(struct gui *ui)
 
        ge = malloc(sizeof(*ge));
        memset(ge, 0, sizeof(*ge));
+       ge->state = GE_STATE_NEW;
        INIT_FLIST_HEAD(&ge->list);
        flist_add_tail(&ge->list, &ui->list);
        ge->ui = ui;
@@ -1829,8 +2052,12 @@ static void ge_destroy(GtkWidget *w, gpointer data)
        struct gui_entry *ge = data;
        struct gfio_client *gc = ge->client;
 
-       if (gc->client)
+       if (gc && gc->client) {
+               if (ge->state >= GE_STATE_CONNECTED)
+                       fio_client_terminate(gc->client);
+
                fio_put_client(gc->client);
+       }
 
        flist_del(&ge->list);
        free(ge);
@@ -1854,14 +2081,18 @@ static struct gui_entry *get_new_ge_with_tab(const char *name)
 
 static void file_new(GtkWidget *w, gpointer data)
 {
-       get_new_ge_with_tab("Untitled");
+       struct gui *ui = (struct gui *) data;
+       struct gui_entry *ge;
+
+       ge = get_new_ge_with_tab("Untitled");
+       gtk_notebook_set_current_page(GTK_NOTEBOOK(ui->notebook), ge->page_num);
 }
 
 /*
  * Return the 'ge' corresponding to the tab. If the active tab is the
  * main tab, open a new tab.
  */
-static struct gui_entry *get_ge_from_page(unsigned int cur_page)
+static struct gui_entry *get_ge_from_page(gint cur_page)
 {
        struct flist_head *entry;
        struct gui_entry *ge;
@@ -1878,6 +2109,43 @@ static struct gui_entry *get_ge_from_page(unsigned int cur_page)
        return NULL;
 }
 
+static struct gui_entry *get_ge_from_cur_tab(struct gui *ui)
+{
+       gint cur_page;
+
+       /*
+        * Main tab is tab 0, so any current page other than 0 holds
+        * a ge entry.
+        */
+       cur_page = gtk_notebook_get_current_page(GTK_NOTEBOOK(ui->notebook));
+       if (cur_page)
+               return get_ge_from_page(cur_page);
+
+       return NULL;
+}
+
+static void file_close(GtkWidget *w, gpointer data)
+{
+       struct gui *ui = (struct gui *) data;
+       struct gui_entry *ge;
+
+       /*
+        * Can't close the main tab
+        */
+       ge = get_ge_from_cur_tab(ui);
+       if (ge) {
+               gtk_widget_destroy(ge->vbox);
+               return;
+       }
+
+       if (!flist_empty(&ui->list)) {
+               show_info_dialog(ui, "Error", "The main page view cannot be closed\n");
+               return;
+       }
+
+               gtk_main_quit();
+}
+
 static void file_open(GtkWidget *w, gpointer data)
 {
        struct gui *ui = data;
@@ -2023,6 +2291,41 @@ static void view_log(GtkWidget *w, gpointer data)
        gtk_widget_show_all(win);
 }
 
+static void connect_job_entry(GtkWidget *w, gpointer data)
+{
+       struct gui *ui = (struct gui *) data;
+       struct gui_entry *ge;
+       
+       ge = get_ge_from_cur_tab(ui);
+       if (ge)
+               connect_clicked(w, ge);
+}
+
+static void send_job_entry(GtkWidget *w, gpointer data)
+{
+       struct gui *ui = (struct gui *) data;
+       struct gui_entry *ge;
+
+       ge = get_ge_from_cur_tab(ui);
+       if (ge)
+               send_clicked(w, ge);
+
+}
+
+static void edit_job_entry(GtkWidget *w, gpointer data)
+{
+}
+
+static void start_job_entry(GtkWidget *w, gpointer data)
+{
+       struct gui *ui = (struct gui *) data;
+       struct gui_entry *ge;
+
+       ge = get_ge_from_cur_tab(ui);
+       if (ge)
+               start_job_clicked(w, ge);
+}
+
 static void __update_graph_limits(struct gfio_graphs *g)
 {
        line_graph_set_data_count_limit(g->iops_graph, gfio_graph_limit);
@@ -2045,7 +2348,7 @@ static void update_graph_limits(void)
 static void preferences(GtkWidget *w, gpointer data)
 {
        GtkWidget *dialog, *frame, *box, **buttons, *vbox, *font;
-       GtkWidget *hbox, *spin, *entry;
+       GtkWidget *hbox, *spin, *entry, *spin_int;
        int i;
 
        dialog = gtk_dialog_new_with_buttons("Preferences",
@@ -2055,9 +2358,40 @@ static void preferences(GtkWidget *w, gpointer data)
                GTK_STOCK_CANCEL, GTK_RESPONSE_REJECT,
                NULL);
 
-       frame = gtk_frame_new("Debug logging");
+       frame = gtk_frame_new("Graphing");
        gtk_box_pack_start(GTK_BOX(GTK_DIALOG(dialog)->vbox), frame, FALSE, FALSE, 5);
+       vbox = gtk_vbox_new(FALSE, 6);
+       gtk_container_add(GTK_CONTAINER(frame), vbox);
+
+       hbox = gtk_hbox_new(FALSE, 5);
+       gtk_box_pack_start(GTK_BOX(vbox), hbox, FALSE, FALSE, 5);
+       entry = gtk_label_new("Font face to use for graph labels");
+       gtk_box_pack_start(GTK_BOX(hbox), entry, TRUE, TRUE, 5);
+
+       font = gtk_font_button_new();
+       gtk_box_pack_start(GTK_BOX(hbox), font, FALSE, FALSE, 5);
+
+       box = gtk_vbox_new(FALSE, 6);
+       gtk_box_pack_start(GTK_BOX(vbox), box, FALSE, FALSE, 5);
+
+       hbox = gtk_hbox_new(FALSE, 5);
+       gtk_box_pack_start(GTK_BOX(box), hbox, TRUE, TRUE, 5);
+       entry = gtk_label_new("Maximum number of data points in graph (seconds)");
+       gtk_box_pack_start(GTK_BOX(hbox), entry, FALSE, FALSE, 5);
+
+       spin = create_spinbutton(hbox, 10, 1000000, gfio_graph_limit);
+
+       box = gtk_vbox_new(FALSE, 6);
+       gtk_box_pack_start(GTK_BOX(vbox), box, FALSE, FALSE, 5);
+
+       hbox = gtk_hbox_new(FALSE, 5);
+       gtk_box_pack_start(GTK_BOX(box), hbox, TRUE, TRUE, 5);
+       entry = gtk_label_new("Client ETA request interval (msec)");
+       gtk_box_pack_start(GTK_BOX(hbox), entry, FALSE, FALSE, 5);
 
+       spin_int = create_spinbutton(hbox, 100, 100000, gfio_client_ops.eta_msec);
+       frame = gtk_frame_new("Debug logging");
+       gtk_box_pack_start(GTK_BOX(GTK_DIALOG(dialog)->vbox), frame, FALSE, FALSE, 5);
        vbox = gtk_vbox_new(FALSE, 6);
        gtk_container_add(GTK_CONTAINER(frame), vbox);
 
@@ -2078,24 +2412,6 @@ static void preferences(GtkWidget *w, gpointer data)
                gtk_box_pack_start(GTK_BOX(box), buttons[i], FALSE, FALSE, 6);
        }
 
-       frame = gtk_frame_new("Graphing");
-       gtk_box_pack_start(GTK_BOX(GTK_DIALOG(dialog)->vbox), frame, FALSE, FALSE, 5);
-       vbox = gtk_vbox_new(FALSE, 6);
-       gtk_container_add(GTK_CONTAINER(frame), vbox);
-
-       font = gtk_font_button_new();
-       gtk_box_pack_start(GTK_BOX(vbox), font, FALSE, FALSE, 5);
-
-       box = gtk_vbox_new(FALSE, 6);
-       gtk_box_pack_start(GTK_BOX(vbox), box, FALSE, FALSE, 5);
-
-       hbox = gtk_hbox_new(FALSE, 5);
-       gtk_box_pack_start(GTK_BOX(box), hbox, FALSE, FALSE, 5);
-       entry = gtk_label_new("Maximum number of data points in graph (seconds)");
-       gtk_box_pack_start(GTK_BOX(hbox), entry, FALSE, FALSE, 5);
-
-       spin = create_spinbutton(hbox, 10, 1000000, 100);
-
        gtk_widget_show_all(dialog);
 
        if (gtk_dialog_run(GTK_DIALOG(dialog)) != GTK_RESPONSE_ACCEPT) {
@@ -2114,6 +2430,7 @@ static void preferences(GtkWidget *w, gpointer data)
        gfio_graph_font = strdup(gtk_font_button_get_font_name(GTK_FONT_BUTTON(font)));
        gfio_graph_limit = gtk_spin_button_get_value_as_int(GTK_SPIN_BUTTON(spin));
        update_graph_limits();
+       gfio_client_ops.eta_msec = gtk_spin_button_get_value_as_int(GTK_SPIN_BUTTON(spin_int));
 
        gtk_widget_destroy(dialog);
 }
@@ -2162,12 +2479,18 @@ static void about_dialog(GtkWidget *w, gpointer data)
 static GtkActionEntry menu_items[] = {
        { "FileMenuAction", GTK_STOCK_FILE, "File", NULL, NULL, NULL},
        { "ViewMenuAction", GTK_STOCK_FILE, "View", NULL, NULL, NULL},
+       { "JobMenuAction", GTK_STOCK_FILE, "Job", NULL, NULL, NULL},
        { "HelpMenuAction", GTK_STOCK_HELP, "Help", NULL, NULL, NULL},
        { "NewFile", GTK_STOCK_NEW, "New", "<Control>N", NULL, G_CALLBACK(file_new) },
+       { "CloseFile", GTK_STOCK_CLOSE, "Close", "<Control>W", NULL, G_CALLBACK(file_close) },
        { "OpenFile", GTK_STOCK_OPEN, NULL,   "<Control>O", NULL, G_CALLBACK(file_open) },
        { "SaveFile", GTK_STOCK_SAVE, NULL,   "<Control>S", NULL, G_CALLBACK(file_save) },
        { "Preferences", GTK_STOCK_PREFERENCES, NULL, "<Control>p", NULL, G_CALLBACK(preferences) },
        { "ViewLog", NULL, "Log", "<Control>l", NULL, G_CALLBACK(view_log) },
+       { "ConnectJob", NULL, "Connect", "<Control>E", NULL, G_CALLBACK(connect_job_entry) },
+       { "EditJob", NULL, "Edit job", "<Control>E", NULL, G_CALLBACK(edit_job_entry) },
+       { "SendJob", NULL, "Send job", "<Control>X", NULL, G_CALLBACK(send_job_entry) },
+       { "StartJob", NULL, "Start job", "<Control>L", NULL, G_CALLBACK(start_job_entry) },
        { "Quit", GTK_STOCK_QUIT, NULL,   "<Control>Q", NULL, G_CALLBACK(quit_clicked) },
        { "About", GTK_STOCK_ABOUT, NULL,  NULL, NULL, G_CALLBACK(about_dialog) },
 };
@@ -2178,14 +2501,25 @@ static const gchar *ui_string = " \
                <menubar name=\"MainMenu\"> \
                        <menu name=\"FileMenu\" action=\"FileMenuAction\"> \
                                <menuitem name=\"New\" action=\"NewFile\" /> \
+                               <menuitem name=\"Close\" action=\"CloseFile\" /> \
                                <separator name=\"Separator1\"/> \
                                <menuitem name=\"Open\" action=\"OpenFile\" /> \
                                <menuitem name=\"Save\" action=\"SaveFile\" /> \
                                <separator name=\"Separator2\"/> \
                                <menuitem name=\"Preferences\" action=\"Preferences\" /> \
                                <separator name=\"Separator3\"/> \
+                               <placeholder name=\"FileRecentFiles\"/> \
+                               <separator name=\"Separator4\"/> \
                                <menuitem name=\"Quit\" action=\"Quit\" /> \
                        </menu> \
+                       <menu name=\"JobMenu\" action=\"JobMenuAction\"> \
+                               <menuitem name=\"Connect\" action=\"ConnectJob\" /> \
+                               <separator name=\"Separator5\"/> \
+                               <menuitem name=\"Edit job\" action=\"EditJob\" /> \
+                               <menuitem name=\"Send job\" action=\"SendJob\" /> \
+                               <separator name=\"Separator6\"/> \
+                               <menuitem name=\"Start job\" action=\"StartJob\" /> \
+                       </menu>\
                        <menu name=\"ViewMenu\" action=\"ViewMenuAction\"> \
                                <menuitem name=\"Log\" action=\"ViewLog\" /> \
                        </menu>\
@@ -2196,6 +2530,14 @@ static const gchar *ui_string = " \
        </ui> \
 ";
 
+static void set_job_menu_visible(struct gui *ui, int visible)
+{
+       GtkWidget *job;
+
+       job = gtk_ui_manager_get_widget(ui->uimanager, "/MainMenu/JobMenu");
+       gtk_widget_set_sensitive(job, visible);
+}
+
 static GtkWidget *get_menubar_menu(GtkWidget *window, GtkUIManager *ui_manager,
                                   struct gui *ui)
 {
@@ -2209,6 +2551,7 @@ static GtkWidget *get_menubar_menu(GtkWidget *window, GtkUIManager *ui_manager,
        gtk_ui_manager_add_ui_from_string(GTK_UI_MANAGER(ui_manager), ui_string, -1, &error);
 
        gtk_window_add_accel_group(GTK_WINDOW(window), gtk_ui_manager_get_accel_group(ui_manager));
+
        return gtk_ui_manager_get_widget(ui_manager, "/MainMenu");
 }
 
@@ -2218,6 +2561,27 @@ void gfio_ui_setup(GtkSettings *settings, GtkWidget *menubar,
         gtk_box_pack_start(GTK_BOX(vbox), menubar, FALSE, FALSE, 0);
 }
 
+static void combo_entry_changed(GtkComboBox *box, gpointer data)
+{
+       struct gui_entry *ge = (struct gui_entry *) data;
+       gint index;
+
+       index = gtk_combo_box_get_active(box);
+
+       multitext_set_entry(&ge->eta.iotype, index);
+       multitext_set_entry(&ge->eta.ioengine, index);
+       multitext_set_entry(&ge->eta.iodepth, index);
+}
+
+static void combo_entry_destroy(GtkWidget *widget, gpointer data)
+{
+       struct gui_entry *ge = (struct gui_entry *) data;
+
+       multitext_free(&ge->eta.iotype);
+       multitext_free(&ge->eta.ioengine);
+       multitext_free(&ge->eta.iodepth);
+}
+
 static GtkWidget *new_client_page(struct gui_entry *ge)
 {
        GtkWidget *main_vbox, *probe, *probe_frame, *probe_box;
@@ -2246,9 +2610,11 @@ static GtkWidget *new_client_page(struct gui_entry *ge)
        gtk_box_pack_start(GTK_BOX(probe_frame), probe_box, FALSE, FALSE, 3);
 
        ge->eta.names = new_combo_entry_in_frame(probe_box, "Jobs");
-       ge->eta.iotype = new_info_entry_in_frame(probe_box, "IO");
-       ge->eta.ioengine = new_info_entry_in_frame(probe_box, "IO Engine");
-       ge->eta.iodepth = new_info_entry_in_frame(probe_box, "IO Depth");
+       g_signal_connect(ge->eta.names, "changed", G_CALLBACK(combo_entry_changed), ge);
+       g_signal_connect(ge->eta.names, "destroy", G_CALLBACK(combo_entry_destroy), ge);
+       ge->eta.iotype.entry = new_info_entry_in_frame(probe_box, "IO");
+       ge->eta.ioengine.entry = new_info_entry_in_frame(probe_box, "IO Engine");
+       ge->eta.iodepth.entry = new_info_entry_in_frame(probe_box, "IO Depth");
        ge->eta.jobs = new_info_entry_in_frame(probe_box, "Jobs");
        ge->eta.files = new_info_entry_in_frame(probe_box, "Open files");
 
@@ -2278,10 +2644,8 @@ static GtkWidget *new_client_page(struct gui_entry *ge)
         */
        gdk_color_parse("white", &white);
        ge->graphs.drawing_area = gtk_drawing_area_new();
-       ge->graphs.drawing_area_xdim = DRAWING_AREA_XDIM;
-       ge->graphs.drawing_area_ydim = DRAWING_AREA_YDIM;
        gtk_widget_set_size_request(GTK_WIDGET(ge->graphs.drawing_area),
-               ge->graphs.drawing_area_xdim, ge->graphs.drawing_area_ydim);
+               DRAWING_AREA_XDIM, DRAWING_AREA_YDIM);
        gtk_widget_modify_bg(ge->graphs.drawing_area, GTK_STATE_NORMAL, &white);
        g_signal_connect(G_OBJECT(ge->graphs.drawing_area), "expose_event",
                                G_CALLBACK(on_expose_drawing_area), &ge->graphs);
@@ -2369,10 +2733,8 @@ static GtkWidget *new_main_page(struct gui *ui)
         */
        gdk_color_parse("white", &white);
        ui->graphs.drawing_area = gtk_drawing_area_new();
-       ui->graphs.drawing_area_xdim = DRAWING_AREA_XDIM;
-       ui->graphs.drawing_area_ydim = DRAWING_AREA_YDIM;
        gtk_widget_set_size_request(GTK_WIDGET(ui->graphs.drawing_area),
-               ui->graphs.drawing_area_xdim, ui->graphs.drawing_area_ydim);
+               DRAWING_AREA_XDIM, DRAWING_AREA_YDIM);
        gtk_widget_modify_bg(ui->graphs.drawing_area, GTK_STATE_NORMAL, &white);
        g_signal_connect(G_OBJECT(ui->graphs.drawing_area), "expose_event",
                        G_CALLBACK(on_expose_drawing_area), &ui->graphs);
@@ -2413,14 +2775,26 @@ static gboolean notebook_switch_page(GtkNotebook *notebook, GtkWidget *widget,
                                     guint page, gpointer data)
 
 {
+       struct gui *ui = (struct gui *) data;
+       struct gui_entry *ge;
+
+       if (!page) {
+               set_job_menu_visible(ui, 0);
+               return TRUE;
+       }
+
+       set_job_menu_visible(ui, 1);
+       ge = get_ge_from_page(page);
+       if (ge)
+               update_button_states(ui, ge);
+
        return TRUE;
 }
 
 static void init_ui(int *argc, char **argv[], struct gui *ui)
 {
        GtkSettings *settings;
-       GtkUIManager *uimanager;
-       GtkWidget *menu, *vbox;
+       GtkWidget *vbox;
 
        /* Magical g*thread incantation, you just need this thread stuff.
         * Without it, the update that happens in gfio_update_thread_status
@@ -2445,9 +2819,9 @@ static void init_ui(int *argc, char **argv[], struct gui *ui)
        ui->vbox = gtk_vbox_new(FALSE, 0);
        gtk_container_add(GTK_CONTAINER(ui->window), ui->vbox);
 
-       uimanager = gtk_ui_manager_new();
-       menu = get_menubar_menu(ui->window, uimanager, ui);
-       gfio_ui_setup(settings, menu, ui->vbox, uimanager);
+       ui->uimanager = gtk_ui_manager_new();
+       ui->menu = get_menubar_menu(ui->window, ui->uimanager, ui);
+       gfio_ui_setup(settings, ui->menu, ui->vbox, ui->uimanager);
 
        ui->notebook = gtk_notebook_new();
        g_signal_connect(ui->notebook, "switch-page", G_CALLBACK(notebook_switch_page), ui);