gfio: add support for graph tooltips
[fio.git] / gfio.c
diff --git a/gfio.c b/gfio.c
index 7f4782821dedb6c20e22479b019229aad1e5691f..76bbbf5c340b985fd19e78f5fa55b7a66dfbb37e 100644 (file)
--- a/gfio.c
+++ b/gfio.c
@@ -104,6 +104,8 @@ struct gfio_graphs {
  * Main window widgets and data
  */
 struct gui {
+       GtkUIManager *uimanager;
+       GtkWidget *menu;
        GtkWidget *window;
        GtkWidget *vbox;
        GtkWidget *topvbox;
@@ -129,6 +131,15 @@ struct gui {
        struct flist_head list;
 } main_ui;
 
+enum {
+       GE_STATE_NEW = 1,
+       GE_STATE_CONNECTED,
+       GE_STATE_JOB_SENT,
+       GE_STATE_JOB_STARTED,
+       GE_STATE_JOB_RUNNING,
+       GE_STATE_JOB_DONE,
+};
+
 /*
  * Notebook entry
  */
@@ -158,7 +169,7 @@ struct gui_entry {
        struct eta_widget eta;
        GtkWidget *page_label;
        gint page_num;
-       int connected;
+       unsigned int state;
 
        struct gfio_client *client;
        int nr_job_files;
@@ -375,22 +386,6 @@ static GtkWidget *create_spinbutton(GtkWidget *hbox, double min, double max, dou
        return button;
 }
 
-static void gfio_set_connected(struct gui_entry *ge, int connected)
-{
-       if (connected) {
-               gtk_widget_set_sensitive(ge->button[SEND_BUTTON], 1);
-               ge->connected = 1;
-               gtk_button_set_label(GTK_BUTTON(ge->button[CONNECT_BUTTON]), "Disconnect");
-               gtk_widget_set_sensitive(ge->button[CONNECT_BUTTON], 1);
-       } else {
-               ge->connected = 0;
-               gtk_button_set_label(GTK_BUTTON(ge->button[CONNECT_BUTTON]), "Connect");
-               gtk_widget_set_sensitive(ge->button[SEND_BUTTON], 0);
-               gtk_widget_set_sensitive(ge->button[START_JOB_BUTTON], 0);
-               gtk_widget_set_sensitive(ge->button[CONNECT_BUTTON], 1);
-       }
-}
-
 static void label_set_int_value(GtkWidget *entry, unsigned int val)
 {
        char tmp[80];
@@ -407,6 +402,119 @@ static void entry_set_int_value(GtkWidget *entry, unsigned int val)
        gtk_entry_set_text(GTK_ENTRY(entry), tmp);
 }
 
+static void show_info_dialog(struct gui *ui, const char *title,
+                            const char *message)
+{
+       GtkWidget *dialog, *content, *label;
+
+       dialog = gtk_dialog_new_with_buttons(title, GTK_WINDOW(ui->window),
+                       GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT,
+                       GTK_STOCK_OK, GTK_RESPONSE_OK, NULL);
+
+       content = gtk_dialog_get_content_area(GTK_DIALOG(dialog));
+       label = gtk_label_new(message);
+       gtk_container_add(GTK_CONTAINER(content), label);
+       gtk_widget_show_all(dialog);
+       gtk_dialog_set_default_response(GTK_DIALOG(dialog), GTK_RESPONSE_ACCEPT);
+       gtk_dialog_run(GTK_DIALOG(dialog));
+       gtk_widget_destroy(dialog);
+}
+
+/*
+ * Update sensitivity of job buttons and job menu items, based on the
+ * state of the client.
+ */
+static void update_button_states(struct gui *ui, struct gui_entry *ge)
+{
+       unsigned int connect_state, send_state, start_state, edit_state;
+       const char *connect_str = NULL;
+       GtkWidget *w;
+
+       switch (ge->state) {
+       default: {
+               char tmp[80];
+
+               sprintf(tmp, "Bad client state: %u\n", ge->state);
+               show_info_dialog(ui, "Error", tmp);
+               /* fall through to new state */
+               }
+
+       case GE_STATE_NEW:
+               connect_state = 1;
+               edit_state = 0;
+               connect_str = "Connect";
+               send_state = 0;
+               start_state = 0;
+               break;
+       case GE_STATE_CONNECTED:
+               connect_state = 1;
+               edit_state = 0;
+               connect_str = "Disconnect";
+               send_state = 1;
+               start_state = 0;
+               break;
+       case GE_STATE_JOB_SENT:
+               connect_state = 1;
+               edit_state = 0;
+               connect_str = "Disconnect";
+               send_state = 0;
+               start_state = 1;
+               break;
+       case GE_STATE_JOB_STARTED:
+               connect_state = 1;
+               edit_state = 1;
+               connect_str = "Disconnect";
+               send_state = 0;
+               start_state = 1;
+               break;
+       case GE_STATE_JOB_RUNNING:
+               connect_state = 1;
+               edit_state = 0;
+               connect_str = "Disconnect";
+               send_state = 0;
+               start_state = 0;
+               break;
+       case GE_STATE_JOB_DONE:
+               connect_state = 1;
+               edit_state = 0;
+               connect_str = "Connect";
+               send_state = 0;
+               start_state = 0;
+               break;
+       }
+
+       gtk_widget_set_sensitive(ge->button[CONNECT_BUTTON], connect_state);
+       gtk_widget_set_sensitive(ge->button[SEND_BUTTON], send_state);
+       gtk_widget_set_sensitive(ge->button[START_JOB_BUTTON], start_state);
+       gtk_button_set_label(GTK_BUTTON(ge->button[CONNECT_BUTTON]), connect_str);
+
+       /*
+        * So the below doesn't work at all, how to set those menu items
+        * invisibible...
+        */
+       w = gtk_ui_manager_get_widget(ui->uimanager, "/MainMenu/JobMenu/Connect");
+       if (w)
+               gtk_widget_set_sensitive(w, connect_state);
+
+       w = gtk_ui_manager_get_widget(ui->uimanager, "/MainMenu/JobMenu/Edit job");
+       if (w)
+               gtk_widget_set_sensitive(w, edit_state);
+
+       w = gtk_ui_manager_get_widget(ui->uimanager, "/MainMenu/JobMenu/Send job");
+       if (w)
+               gtk_widget_set_sensitive(w, send_state);
+
+       w = gtk_ui_manager_get_widget(ui->uimanager, "/MainMenu/JobMenu/Start job");
+       if (w)
+               gtk_widget_set_sensitive(w, start_state);
+}
+
+static void gfio_set_state(struct gui_entry *ge, unsigned int state)
+{
+       ge->state = state;
+       update_button_states(ge->ui, ge);
+}
+
 #define ALIGN_LEFT 1
 #define ALIGN_RIGHT 2
 #define INVISIBLE 4
@@ -1199,12 +1307,39 @@ static void draw_graph(struct graph *g, cairo_t *cr)
        cairo_stroke(cr);
 }
 
+static gboolean graph_tooltip(GtkWidget *w, gint x, gint y,
+                             gboolean keyboard_mode, GtkTooltip *tooltip,
+                             gpointer data)
+{
+       struct gfio_graphs *g = data;
+       const char *text = NULL;
+
+       if (graph_contains_xy(g->iops_graph, x, y))
+               text = graph_find_tooltip(g->iops_graph, x, y);
+       else if (graph_contains_xy(g->bandwidth_graph, x, y))
+               text = graph_find_tooltip(g->bandwidth_graph, x, y);
+
+       if (text) {
+               gtk_tooltip_set_text(tooltip, text);
+               return TRUE;
+       }
+
+       return FALSE;
+}
+
 static int on_expose_drawing_area(GtkWidget *w, GdkEvent *event, gpointer p)
 {
        struct gfio_graphs *g = p;
        cairo_t *cr;
 
        cr = gdk_cairo_create(w->window);
+
+       if (graph_has_tooltips(g->iops_graph) ||
+           graph_has_tooltips(g->bandwidth_graph)) {
+               g_object_set(w, "has-tooltip", TRUE, NULL);
+               g_signal_connect(w, "query-tooltip", G_CALLBACK(graph_tooltip), g);
+       }
+
        cairo_set_source_rgb(cr, 0, 0, 0);
        draw_graph(g->iops_graph, cr);
        draw_graph(g->bandwidth_graph, cr);
@@ -1285,10 +1420,10 @@ static void gfio_update_client_eta(struct fio_client *client, struct jobs_eta *j
                gtk_entry_set_text(GTK_ENTRY(ge->eta.write_bw), rate_str[1]);
                gtk_entry_set_text(GTK_ENTRY(ge->eta.write_iops), iops_str[1]);
 
-               graph_add_xy_data(ge->graphs.iops_graph, "Read IOPS", je->elapsed_sec, je->iops[0]);
-               graph_add_xy_data(ge->graphs.iops_graph, "Write IOPS", je->elapsed_sec, je->iops[1]);
-               graph_add_xy_data(ge->graphs.bandwidth_graph, "Read Bandwidth", je->elapsed_sec, je->rate[0]);
-               graph_add_xy_data(ge->graphs.bandwidth_graph, "Write Bandwidth", je->elapsed_sec, je->rate[1]);
+               graph_add_xy_data(ge->graphs.iops_graph, "Read IOPS", je->elapsed_sec, je->iops[0], iops_str[0]);
+               graph_add_xy_data(ge->graphs.iops_graph, "Write IOPS", je->elapsed_sec, je->iops[1], iops_str[1]);
+               graph_add_xy_data(ge->graphs.bandwidth_graph, "Read Bandwidth", je->elapsed_sec, je->rate[0], rate_str[0]);
+               graph_add_xy_data(ge->graphs.bandwidth_graph, "Write Bandwidth", je->elapsed_sec, je->rate[1], rate_str[1]);
 
                free(rate_str[0]);
                free(rate_str[1]);
@@ -1373,10 +1508,10 @@ static void gfio_update_all_eta(struct jobs_eta *je)
                gtk_entry_set_text(GTK_ENTRY(ui->eta.write_bw), rate_str[1]);
                gtk_entry_set_text(GTK_ENTRY(ui->eta.write_iops), iops_str[1]);
 
-               graph_add_xy_data(ui->graphs.iops_graph, "Read IOPS", je->elapsed_sec, je->iops[0]);
-               graph_add_xy_data(ui->graphs.iops_graph, "Write IOPS", je->elapsed_sec, je->iops[1]);
-               graph_add_xy_data(ui->graphs.bandwidth_graph, "Read Bandwidth", je->elapsed_sec, je->rate[0]);
-               graph_add_xy_data(ui->graphs.bandwidth_graph, "Write Bandwidth", je->elapsed_sec, je->rate[1]);
+               graph_add_xy_data(ui->graphs.iops_graph, "Read IOPS", je->elapsed_sec, je->iops[0], iops_str[0]);
+               graph_add_xy_data(ui->graphs.iops_graph, "Write IOPS", je->elapsed_sec, je->iops[1], iops_str[1]);
+               graph_add_xy_data(ui->graphs.bandwidth_graph, "Read Bandwidth", je->elapsed_sec, je->rate[0], rate_str[0]);
+               graph_add_xy_data(ui->graphs.bandwidth_graph, "Write Bandwidth", je->elapsed_sec, je->rate[1], rate_str[1]);
 
                free(rate_str[0]);
                free(rate_str[1]);
@@ -1421,7 +1556,7 @@ static void gfio_probe_op(struct fio_client *client, struct fio_net_cmd *cmd)
        sprintf(buf, "%u.%u.%u", probe->fio_major, probe->fio_minor, probe->fio_patch);
        gtk_label_set_text(GTK_LABEL(ge->probe.fio_ver), buf);
 
-       gfio_set_connected(ge, 1);
+       gfio_set_state(ge, GE_STATE_CONNECTED);
 
        gdk_threads_leave();
 }
@@ -1455,7 +1590,7 @@ static void gfio_quit_op(struct fio_client *client)
        struct gfio_client *gc = client->client_data;
 
        gdk_threads_enter();
-       gfio_set_connected(gc->ge, 0);
+       gfio_set_state(gc->ge, GE_STATE_NEW);
        gdk_threads_leave();
 }
 
@@ -1488,37 +1623,23 @@ static void gfio_add_job_op(struct fio_client *client, struct fio_net_cmd *cmd)
 
        gc->job_added++;
 
+       gfio_set_state(ge, GE_STATE_JOB_SENT);
+
        gdk_threads_leave();
 }
 
 static void gfio_client_timed_out(struct fio_client *client)
 {
        struct gfio_client *gc = client->client_data;
-       GtkWidget *dialog, *label, *content;
        char buf[256];
 
        gdk_threads_enter();
 
-       gfio_set_connected(gc->ge, 0);
+       gfio_set_state(gc->ge, GE_STATE_NEW);
        clear_ge_ui_info(gc->ge);
 
        sprintf(buf, "Client %s: timeout talking to server.\n", client->hostname);
-
-       dialog = gtk_dialog_new_with_buttons("Timed out!",
-                       GTK_WINDOW(main_ui.window),
-                       GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT,
-                       GTK_STOCK_OK, GTK_RESPONSE_OK, NULL);
-
-       /* gtk_dialog_get_content_area() is 2.14 and newer */
-       content = GTK_DIALOG(dialog)->vbox;
-
-       label = gtk_label_new((const gchar *) buf);
-       gtk_container_add(GTK_CONTAINER(content), label);
-       gtk_widget_show_all(dialog);
-       gtk_dialog_set_default_response(GTK_DIALOG(dialog), GTK_RESPONSE_ACCEPT);
-
-       gtk_dialog_run(GTK_DIALOG(dialog));
-       gtk_widget_destroy(dialog);
+       show_info_dialog(gc->ge->ui, "Network timeout", buf);
 
        gdk_threads_leave();
 }
@@ -1529,7 +1650,7 @@ static void gfio_client_stop(struct fio_client *client, struct fio_net_cmd *cmd)
 
        gdk_threads_enter();
 
-       gfio_set_connected(gc->ge, 0);
+       gfio_set_state(gc->ge, GE_STATE_JOB_DONE);
 
        if (gc->err_entry)
                entry_set_int_value(gc->err_entry, client->error);
@@ -1537,6 +1658,24 @@ static void gfio_client_stop(struct fio_client *client, struct fio_net_cmd *cmd)
        gdk_threads_leave();
 }
 
+static void gfio_client_start(struct fio_client *client, struct fio_net_cmd *cmd)
+{
+       struct gfio_client *gc = client->client_data;
+
+       gdk_threads_enter();
+       gfio_set_state(gc->ge, GE_STATE_JOB_STARTED);
+       gdk_threads_leave();
+}
+
+static void gfio_client_job_start(struct fio_client *client, struct fio_net_cmd *cmd)
+{
+       struct gfio_client *gc = client->client_data;
+
+       gdk_threads_enter();
+       gfio_set_state(gc->ge, GE_STATE_JOB_RUNNING);
+       gdk_threads_leave();
+}
+
 struct client_ops gfio_client_ops = {
        .text_op                = gfio_text_op,
        .disk_util              = gfio_disk_util_op,
@@ -1549,6 +1688,8 @@ struct client_ops gfio_client_ops = {
        .add_job                = gfio_add_job_op,
        .timed_out              = gfio_client_timed_out,
        .stop                   = gfio_client_stop,
+       .start                  = gfio_client_start,
+       .job_start              = gfio_client_job_start,
        .eta_msec               = FIO_CLIENT_DEF_ETA_MSEC,
        .stay_connected         = 1,
 };
@@ -1624,8 +1765,8 @@ static void start_job_clicked(__attribute__((unused)) GtkWidget *widget,
        struct gui_entry *ge = data;
        struct gfio_client *gc = ge->client;
 
-       gtk_widget_set_sensitive(ge->button[START_JOB_BUTTON], 0);
-       fio_start_client(gc->client);
+       if (gc)
+               fio_start_client(gc->client);
 }
 
 static void file_open(GtkWidget *w, gpointer data);
@@ -1635,11 +1776,11 @@ static void connect_clicked(GtkWidget *widget, gpointer data)
        struct gui_entry *ge = data;
        struct gfio_client *gc = ge->client;
 
-       if (!ge->connected) {
+       if (ge->state == GE_STATE_NEW) {
                int ret;
 
                if (!ge->nr_job_files)
-                       file_open(widget, data);
+                       file_open(widget, ge->ui);
                if (!ge->nr_job_files)
                        return;
 
@@ -1649,8 +1790,7 @@ static void connect_clicked(GtkWidget *widget, gpointer data)
                if (!ret) {
                        if (!ge->ui->handler_running)
                                pthread_create(&ge->ui->t, NULL, job_thread, ge->ui);
-                       gtk_widget_set_sensitive(ge->button[CONNECT_BUTTON], 0);
-                       gtk_widget_set_sensitive(ge->button[SEND_BUTTON], 1);
+                       gfio_set_state(ge, GE_STATE_CONNECTED);
                } else {
                        GError *error;
 
@@ -1660,7 +1800,7 @@ static void connect_clicked(GtkWidget *widget, gpointer data)
                }
        } else {
                fio_client_terminate(gc->client);
-               gfio_set_connected(ge, 0);
+               gfio_set_state(ge, GE_STATE_NEW);
                clear_ge_ui_info(ge);
        }
 }
@@ -1678,9 +1818,6 @@ static void send_clicked(GtkWidget *widget, gpointer data)
 
                gtk_widget_set_sensitive(ge->button[START_JOB_BUTTON], 1);
        }
-
-       gtk_widget_set_sensitive(ge->button[SEND_BUTTON], 0);
-       gtk_widget_set_sensitive(ge->button[START_JOB_BUTTON], 1);
 }
 
 static GtkWidget *add_button(GtkWidget *buttonbox,
@@ -1900,6 +2037,7 @@ static struct gui_entry *alloc_new_gui_entry(struct gui *ui)
 
        ge = malloc(sizeof(*ge));
        memset(ge, 0, sizeof(*ge));
+       ge->state = GE_STATE_NEW;
        INIT_FLIST_HEAD(&ge->list);
        flist_add_tail(&ge->list, &ui->list);
        ge->ui = ui;
@@ -1914,8 +2052,12 @@ static void ge_destroy(GtkWidget *w, gpointer data)
        struct gui_entry *ge = data;
        struct gfio_client *gc = ge->client;
 
-       if (gc->client)
+       if (gc && gc->client) {
+               if (ge->state >= GE_STATE_CONNECTED)
+                       fio_client_terminate(gc->client);
+
                fio_put_client(gc->client);
+       }
 
        flist_del(&ge->list);
        free(ge);
@@ -1939,14 +2081,18 @@ static struct gui_entry *get_new_ge_with_tab(const char *name)
 
 static void file_new(GtkWidget *w, gpointer data)
 {
-       get_new_ge_with_tab("Untitled");
+       struct gui *ui = (struct gui *) data;
+       struct gui_entry *ge;
+
+       ge = get_new_ge_with_tab("Untitled");
+       gtk_notebook_set_current_page(GTK_NOTEBOOK(ui->notebook), ge->page_num);
 }
 
 /*
  * Return the 'ge' corresponding to the tab. If the active tab is the
  * main tab, open a new tab.
  */
-static struct gui_entry *get_ge_from_page(unsigned int cur_page)
+static struct gui_entry *get_ge_from_page(gint cur_page)
 {
        struct flist_head *entry;
        struct gui_entry *ge;
@@ -1963,6 +2109,43 @@ static struct gui_entry *get_ge_from_page(unsigned int cur_page)
        return NULL;
 }
 
+static struct gui_entry *get_ge_from_cur_tab(struct gui *ui)
+{
+       gint cur_page;
+
+       /*
+        * Main tab is tab 0, so any current page other than 0 holds
+        * a ge entry.
+        */
+       cur_page = gtk_notebook_get_current_page(GTK_NOTEBOOK(ui->notebook));
+       if (cur_page)
+               return get_ge_from_page(cur_page);
+
+       return NULL;
+}
+
+static void file_close(GtkWidget *w, gpointer data)
+{
+       struct gui *ui = (struct gui *) data;
+       struct gui_entry *ge;
+
+       /*
+        * Can't close the main tab
+        */
+       ge = get_ge_from_cur_tab(ui);
+       if (ge) {
+               gtk_widget_destroy(ge->vbox);
+               return;
+       }
+
+       if (!flist_empty(&ui->list)) {
+               show_info_dialog(ui, "Error", "The main page view cannot be closed\n");
+               return;
+       }
+
+               gtk_main_quit();
+}
+
 static void file_open(GtkWidget *w, gpointer data)
 {
        struct gui *ui = data;
@@ -2108,6 +2291,41 @@ static void view_log(GtkWidget *w, gpointer data)
        gtk_widget_show_all(win);
 }
 
+static void connect_job_entry(GtkWidget *w, gpointer data)
+{
+       struct gui *ui = (struct gui *) data;
+       struct gui_entry *ge;
+       
+       ge = get_ge_from_cur_tab(ui);
+       if (ge)
+               connect_clicked(w, ge);
+}
+
+static void send_job_entry(GtkWidget *w, gpointer data)
+{
+       struct gui *ui = (struct gui *) data;
+       struct gui_entry *ge;
+
+       ge = get_ge_from_cur_tab(ui);
+       if (ge)
+               send_clicked(w, ge);
+
+}
+
+static void edit_job_entry(GtkWidget *w, gpointer data)
+{
+}
+
+static void start_job_entry(GtkWidget *w, gpointer data)
+{
+       struct gui *ui = (struct gui *) data;
+       struct gui_entry *ge;
+
+       ge = get_ge_from_cur_tab(ui);
+       if (ge)
+               start_job_clicked(w, ge);
+}
+
 static void __update_graph_limits(struct gfio_graphs *g)
 {
        line_graph_set_data_count_limit(g->iops_graph, gfio_graph_limit);
@@ -2261,12 +2479,18 @@ static void about_dialog(GtkWidget *w, gpointer data)
 static GtkActionEntry menu_items[] = {
        { "FileMenuAction", GTK_STOCK_FILE, "File", NULL, NULL, NULL},
        { "ViewMenuAction", GTK_STOCK_FILE, "View", NULL, NULL, NULL},
+       { "JobMenuAction", GTK_STOCK_FILE, "Job", NULL, NULL, NULL},
        { "HelpMenuAction", GTK_STOCK_HELP, "Help", NULL, NULL, NULL},
        { "NewFile", GTK_STOCK_NEW, "New", "<Control>N", NULL, G_CALLBACK(file_new) },
+       { "CloseFile", GTK_STOCK_CLOSE, "Close", "<Control>W", NULL, G_CALLBACK(file_close) },
        { "OpenFile", GTK_STOCK_OPEN, NULL,   "<Control>O", NULL, G_CALLBACK(file_open) },
        { "SaveFile", GTK_STOCK_SAVE, NULL,   "<Control>S", NULL, G_CALLBACK(file_save) },
        { "Preferences", GTK_STOCK_PREFERENCES, NULL, "<Control>p", NULL, G_CALLBACK(preferences) },
        { "ViewLog", NULL, "Log", "<Control>l", NULL, G_CALLBACK(view_log) },
+       { "ConnectJob", NULL, "Connect", "<Control>E", NULL, G_CALLBACK(connect_job_entry) },
+       { "EditJob", NULL, "Edit job", "<Control>E", NULL, G_CALLBACK(edit_job_entry) },
+       { "SendJob", NULL, "Send job", "<Control>X", NULL, G_CALLBACK(send_job_entry) },
+       { "StartJob", NULL, "Start job", "<Control>L", NULL, G_CALLBACK(start_job_entry) },
        { "Quit", GTK_STOCK_QUIT, NULL,   "<Control>Q", NULL, G_CALLBACK(quit_clicked) },
        { "About", GTK_STOCK_ABOUT, NULL,  NULL, NULL, G_CALLBACK(about_dialog) },
 };
@@ -2277,14 +2501,25 @@ static const gchar *ui_string = " \
                <menubar name=\"MainMenu\"> \
                        <menu name=\"FileMenu\" action=\"FileMenuAction\"> \
                                <menuitem name=\"New\" action=\"NewFile\" /> \
+                               <menuitem name=\"Close\" action=\"CloseFile\" /> \
                                <separator name=\"Separator1\"/> \
                                <menuitem name=\"Open\" action=\"OpenFile\" /> \
                                <menuitem name=\"Save\" action=\"SaveFile\" /> \
                                <separator name=\"Separator2\"/> \
                                <menuitem name=\"Preferences\" action=\"Preferences\" /> \
                                <separator name=\"Separator3\"/> \
+                               <placeholder name=\"FileRecentFiles\"/> \
+                               <separator name=\"Separator4\"/> \
                                <menuitem name=\"Quit\" action=\"Quit\" /> \
                        </menu> \
+                       <menu name=\"JobMenu\" action=\"JobMenuAction\"> \
+                               <menuitem name=\"Connect\" action=\"ConnectJob\" /> \
+                               <separator name=\"Separator5\"/> \
+                               <menuitem name=\"Edit job\" action=\"EditJob\" /> \
+                               <menuitem name=\"Send job\" action=\"SendJob\" /> \
+                               <separator name=\"Separator6\"/> \
+                               <menuitem name=\"Start job\" action=\"StartJob\" /> \
+                       </menu>\
                        <menu name=\"ViewMenu\" action=\"ViewMenuAction\"> \
                                <menuitem name=\"Log\" action=\"ViewLog\" /> \
                        </menu>\
@@ -2295,6 +2530,14 @@ static const gchar *ui_string = " \
        </ui> \
 ";
 
+static void set_job_menu_visible(struct gui *ui, int visible)
+{
+       GtkWidget *job;
+
+       job = gtk_ui_manager_get_widget(ui->uimanager, "/MainMenu/JobMenu");
+       gtk_widget_set_sensitive(job, visible);
+}
+
 static GtkWidget *get_menubar_menu(GtkWidget *window, GtkUIManager *ui_manager,
                                   struct gui *ui)
 {
@@ -2308,6 +2551,7 @@ static GtkWidget *get_menubar_menu(GtkWidget *window, GtkUIManager *ui_manager,
        gtk_ui_manager_add_ui_from_string(GTK_UI_MANAGER(ui_manager), ui_string, -1, &error);
 
        gtk_window_add_accel_group(GTK_WINDOW(window), gtk_ui_manager_get_accel_group(ui_manager));
+
        return gtk_ui_manager_get_widget(ui_manager, "/MainMenu");
 }
 
@@ -2531,14 +2775,26 @@ static gboolean notebook_switch_page(GtkNotebook *notebook, GtkWidget *widget,
                                     guint page, gpointer data)
 
 {
+       struct gui *ui = (struct gui *) data;
+       struct gui_entry *ge;
+
+       if (!page) {
+               set_job_menu_visible(ui, 0);
+               return TRUE;
+       }
+
+       set_job_menu_visible(ui, 1);
+       ge = get_ge_from_page(page);
+       if (ge)
+               update_button_states(ui, ge);
+
        return TRUE;
 }
 
 static void init_ui(int *argc, char **argv[], struct gui *ui)
 {
        GtkSettings *settings;
-       GtkUIManager *uimanager;
-       GtkWidget *menu, *vbox;
+       GtkWidget *vbox;
 
        /* Magical g*thread incantation, you just need this thread stuff.
         * Without it, the update that happens in gfio_update_thread_status
@@ -2563,9 +2819,9 @@ static void init_ui(int *argc, char **argv[], struct gui *ui)
        ui->vbox = gtk_vbox_new(FALSE, 0);
        gtk_container_add(GTK_CONTAINER(ui->window), ui->vbox);
 
-       uimanager = gtk_ui_manager_new();
-       menu = get_menubar_menu(ui->window, uimanager, ui);
-       gfio_ui_setup(settings, menu, ui->vbox, uimanager);
+       ui->uimanager = gtk_ui_manager_new();
+       ui->menu = get_menubar_menu(ui->window, ui->uimanager, ui);
+       gfio_ui_setup(settings, ui->menu, ui->vbox, ui->uimanager);
 
        ui->notebook = gtk_notebook_new();
        g_signal_connect(ui->notebook, "switch-page", G_CALLBACK(notebook_switch_page), ui);