io_u timeout handling
[fio.git] / fio.c
diff --git a/fio.c b/fio.c
index 5358af2c8a8dc7bea5234c329bdf39087679a15f..fad4cca76bbe2cb9781ad10183e0ab369d126ff2 100644 (file)
--- a/fio.c
+++ b/fio.c
@@ -136,47 +136,22 @@ static inline int runtime_exceeded(struct thread_data *td, struct timeval *t)
        return 0;
 }
 
-static struct fio_file *get_next_file(struct thread_data *td)
-{
-       unsigned int old_next_file = td->next_file;
-       struct fio_file *f;
-
-       do {
-               f = &td->files[td->next_file];
-
-               td->next_file++;
-               if (td->next_file >= td->nr_files)
-                       td->next_file = 0;
-
-               if (f->fd != -1)
-                       break;
-
-               f = NULL;
-       } while (td->next_file != old_next_file);
-
-       return f;
-}
-
 /*
  * When job exits, we can cancel the in-flight IO if we are using async
  * io. Attempt to do so.
  */
 static void cleanup_pending_aio(struct thread_data *td)
 {
-       struct timespec ts = { .tv_sec = 0, .tv_nsec = 0};
        struct list_head *entry, *n;
-       struct io_completion_data icd;
        struct io_u *io_u;
        int r;
 
        /*
         * get immediately available events, if any
         */
-       r = td_io_getevents(td, 0, td->cur_depth, &ts);
-       if (r > 0) {
-               icd.nr = r;
-               ios_completed(td, &icd);
-       }
+       r = io_u_queued_complete(td, 0, NULL);
+       if (r < 0)
+               return;
 
        /*
         * now cancel remaining active events
@@ -185,19 +160,24 @@ static void cleanup_pending_aio(struct thread_data *td)
                list_for_each_safe(entry, n, &td->io_u_busylist) {
                        io_u = list_entry(entry, struct io_u, list);
 
-                       r = td->io_ops->cancel(td, io_u);
-                       if (!r)
+                       /*
+                        * if the io_u isn't in flight, then that generally
+                        * means someone leaked an io_u. complain but fix
+                        * it up, so we don't stall here.
+                        */
+                       if ((io_u->flags & IO_U_F_FLIGHT) == 0) {
+                               log_err("fio: non-busy IO on busy list\n");
                                put_io_u(td, io_u);
+                       } else {
+                               r = td->io_ops->cancel(td, io_u);
+                               if (!r)
+                                       put_io_u(td, io_u);
+                       }
                }
        }
 
-       if (td->cur_depth) {
-               r = td_io_getevents(td, td->cur_depth, td->cur_depth, NULL);
-               if (r > 0) {
-                       icd.nr = r;
-                       ios_completed(td, &icd);
-               }
-       }
+       if (td->cur_depth)
+               r = io_u_queued_complete(td, td->cur_depth, NULL);
 }
 
 /*
@@ -207,7 +187,6 @@ static void cleanup_pending_aio(struct thread_data *td)
 static int fio_io_sync(struct thread_data *td, struct fio_file *f)
 {
        struct io_u *io_u = __get_io_u(td);
-       struct io_completion_data icd;
        int ret;
 
        if (!io_u)
@@ -221,33 +200,27 @@ static int fio_io_sync(struct thread_data *td, struct fio_file *f)
                return 1;
        }
 
+requeue:
        ret = td_io_queue(td, io_u);
        if (ret < 0) {
                td_verror(td, io_u->error);
                put_io_u(td, io_u);
                return 1;
        } else if (ret == FIO_Q_QUEUED) {
-               ret = td_io_getevents(td, 1, td->cur_depth, NULL);
-               if (ret < 0) {
-                       td_verror(td, ret);
-                       return 1;
-               }
-
-               icd.nr = ret;
-               ios_completed(td, &icd);
-               if (icd.error) {
-                       td_verror(td, icd.error);
+               if (io_u_queued_complete(td, 1, NULL) < 0)
                        return 1;
-               }
        } else if (ret == FIO_Q_COMPLETED) {
                if (io_u->error) {
                        td_verror(td, io_u->error);
                        return 1;
                }
 
-               init_icd(&icd);
-               io_completed(td, io_u, &icd);
-               put_io_u(td, io_u);
+               if (io_u_sync_complete(td, io_u, NULL) < 0)
+                       return 1;
+       } else if (ret == FIO_Q_BUSY) {
+               if (td_io_commit(td))
+                       return 1;
+               goto requeue;
        }
 
        return 0;
@@ -261,17 +234,22 @@ static void do_verify(struct thread_data *td)
 {
        struct fio_file *f;
        struct io_u *io_u;
-       int ret, i;
+       int ret, i, min_events;
 
        /*
         * sync io first and invalidate cache, to make sure we really
         * read from disk.
         */
        for_each_file(td, f, i) {
-               fio_io_sync(td, f);
-               file_invalidate_cache(td, f);
+               if (fio_io_sync(td, f))
+                       break;
+               if (file_invalidate_cache(td, f))
+                       break;
        }
 
+       if (td->error)
+               return;
+
        td_set_runstate(td, TD_VERIFYING);
 
        io_u = NULL;
@@ -280,22 +258,27 @@ static void do_verify(struct thread_data *td)
                if (!io_u)
                        break;
 
-               if (runtime_exceeded(td, &io_u->start_time))
+               if (runtime_exceeded(td, &io_u->start_time)) {
+                       put_io_u(td, io_u);
                        break;
+               }
 
-               if (get_next_verify(td, io_u))
+               if (get_next_verify(td, io_u)) {
+                       put_io_u(td, io_u);
                        break;
+               }
 
-               if (td_io_prep(td, io_u))
+               if (td_io_prep(td, io_u)) {
+                       put_io_u(td, io_u);
                        break;
-
+               }
 requeue:
                ret = td_io_queue(td, io_u);
 
                switch (ret) {
                case FIO_Q_COMPLETED:
                        if (io_u->error)
-                               ret = io_u->error;
+                               ret = -io_u->error;
                        if (io_u->xfer_buflen != io_u->resid && io_u->resid) {
                                int bytes = io_u->xfer_buflen - io_u->resid;
 
@@ -303,38 +286,45 @@ requeue:
                                io_u->xfer_buf += bytes;
                                goto requeue;
                        }
-                       if (do_io_u_verify(td, &io_u)) {
-                               ret = -EIO;
+                       ret = io_u_sync_complete(td, io_u, verify_io_u);
+                       if (ret < 0)
                                break;
-                       }
                        continue;
                case FIO_Q_QUEUED:
                        break;
+               case FIO_Q_BUSY:
+                       requeue_io_u(td, &io_u);
+                       ret = td_io_commit(td);
+                       break;
                default:
                        assert(ret < 0);
-                       td_verror(td, ret);
+                       td_verror(td, -ret);
                        break;
                }
 
+               if (ret < 0 || td->error)
+                       break;
+
                /*
-                * We get here for a queued request, in the future we
-                * want to later make this take full advantage of
-                * keeping IO in flight while verifying others.
+                * if we can queue more, do so. but check if there are
+                * completed io_u's first.
                 */
-               ret = td_io_getevents(td, 1, 1, NULL);
-               if (ret < 0)
-                       break;
+               min_events = 0;
+               if (queue_full(td) || ret == FIO_Q_BUSY) {
+                       min_events = 1;
 
-               assert(ret == 1);
-               io_u = td->io_ops->event(td, 0);
+                       if (td->cur_depth > td->iodepth_low)
+                               min_events = td->cur_depth - td->iodepth_low;
+               }
 
-               if (do_io_u_verify(td, &io_u))
+               /*
+                * Reap required number of io units, if any, and do the
+                * verification on them through the callback handler
+                */
+               if (io_u_queued_complete(td, min_events, verify_io_u) < 0)
                        break;
        }
 
-       if (io_u)
-               put_io_u(td, io_u);
-
        if (td->cur_depth)
                cleanup_pending_aio(td);
 
@@ -372,31 +362,31 @@ static void do_cpuio(struct thread_data *td)
  */
 static void do_io(struct thread_data *td)
 {
-       struct io_completion_data icd;
        struct timeval s;
        unsigned long usec;
-       struct fio_file *f;
        int i, ret = 0;
 
        td_set_runstate(td, TD_RUNNING);
 
        while ((td->this_io_bytes[0] + td->this_io_bytes[1]) < td->io_size) {
-               struct timespec *timeout;
+               struct timeval comp_time;
+               long bytes_done = 0;
                int min_evts = 0;
                struct io_u *io_u;
 
                if (td->terminate)
                        break;
 
-               f = get_next_file(td);
-               if (!f)
-                       break;
-
-               io_u = get_io_u(td, f);
+               io_u = get_io_u(td);
                if (!io_u)
                        break;
 
                memcpy(&s, &io_u->start_time, sizeof(s));
+
+               if (runtime_exceeded(td, &s)) {
+                       put_io_u(td, io_u);
+                       break;
+               }
 requeue:
                ret = td_io_queue(td, io_u);
 
@@ -413,11 +403,23 @@ requeue:
                                io_u->xfer_buf += bytes;
                                goto requeue;
                        }
-                       init_icd(&icd);
-                       io_completed(td, io_u, &icd);
-                       put_io_u(td, io_u);
+                       fio_gettime(&comp_time, NULL);
+                       bytes_done = io_u_sync_complete(td, io_u, NULL);
+                       if (bytes_done < 0)
+                               ret = bytes_done;
                        break;
                case FIO_Q_QUEUED:
+                       /*
+                        * if the engine doesn't have a commit hook,
+                        * the io_u is really queued. if it does have such
+                        * a hook, it has to call io_u_queued() itself.
+                        */
+                       if (td->io_ops->commit == NULL)
+                               io_u_queued(td, io_u);
+                       break;
+               case FIO_Q_BUSY:
+                       requeue_io_u(td, &io_u);
+                       ret = td_io_commit(td);
                        break;
                default:
                        assert(ret < 0);
@@ -425,58 +427,46 @@ requeue:
                        break;
                }
 
-               if (ret < 0)
+               if (ret < 0 || td->error)
                        break;
 
-               add_slat_sample(td, io_u->ddir, mtime_since(&io_u->start_time, &io_u->issue_time));
-
-               if (ret == FIO_Q_QUEUED) {
-                       if (td->cur_depth < td->iodepth) {
-                               struct timespec ts;
-
-                               ts.tv_sec = 0;
-                               ts.tv_nsec = 0;
-                               timeout = &ts;
-                               min_evts = 0;
-                       } else {
-                               timeout = NULL;
+               /*
+                * See if we need to complete some commands
+                */
+               if (ret == FIO_Q_QUEUED || ret == FIO_Q_BUSY) {
+                       min_evts = 0;
+                       if (queue_full(td) || ret == FIO_Q_BUSY) {
                                min_evts = 1;
-                       }
 
-                       ret = td_io_getevents(td, min_evts, td->cur_depth, timeout);
-                       if (ret < 0) {
-                               td_verror(td, ret);
-                               break;
-                       } else if (!ret)
-                               continue;
+                               if (td->cur_depth > td->iodepth_low)
+                                       min_evts = td->cur_depth - td->iodepth_low;
+                       }
 
-                       icd.nr = ret;
-                       ios_completed(td, &icd);
-                       if (icd.error) {
-                               td_verror(td, icd.error);
+                       fio_gettime(&comp_time, NULL);
+                       bytes_done = io_u_queued_complete(td, min_evts, NULL);
+                       if (bytes_done < 0)
                                break;
-                       }
                }
 
+               if (!bytes_done)
+                       continue;
+
                /*
                 * the rate is batched for now, it should work for batches
                 * of completions except the very first one which may look
                 * a little bursty
                 */
-               usec = utime_since(&s, &icd.time);
+               usec = utime_since(&s, &comp_time);
 
-               rate_throttle(td, usec, icd.bytes_done[td->ddir], td->ddir);
+               rate_throttle(td, usec, bytes_done, td->ddir);
 
-               if (check_min_rate(td, &icd.time)) {
+               if (check_min_rate(td, &comp_time)) {
                        if (exitall_on_terminate)
                                terminate_threads(td->groupid, 0);
                        td_verror(td, ENODATA);
                        break;
                }
 
-               if (runtime_exceeded(td, &icd.time))
-                       break;
-
                if (td->thinktime) {
                        unsigned long long b;
 
@@ -495,6 +485,8 @@ requeue:
        }
 
        if (!td->error) {
+               struct fio_file *f;
+
                if (td->cur_depth)
                        cleanup_pending_aio(td);
 
@@ -571,9 +563,12 @@ static int init_io_u(struct thread_data *td)
                        fill_rand_buf(io_u, max_bs);
 
                io_u->index = i;
+               io_u->flags = IO_U_F_FREE;
                list_add(&io_u->list, &td->io_u_freelist);
        }
 
+       io_u_init_timeout();
+
        return 0;
 }
 
@@ -633,11 +628,15 @@ static void clear_io_state(struct thread_data *td)
        struct fio_file *f;
        int i;
 
-       td->stat_io_bytes[0] = td->stat_io_bytes[1] = 0;
+       td->ts.stat_io_bytes[0] = td->ts.stat_io_bytes[1] = 0;
        td->this_io_bytes[0] = td->this_io_bytes[1] = 0;
        td->zone_bytes = 0;
 
+       td->last_was_sync = 0;
+
        for_each_file(td, f, i) {
+               f->last_completed_pos = 0;
+
                f->last_pos = 0;
                if (td->io_ops->flags & FIO_SYNCIO)
                        lseek(f->fd, SEEK_SET, 0);
@@ -663,6 +662,7 @@ static void *thread_main(void *data)
 
        INIT_LIST_HEAD(&td->io_u_freelist);
        INIT_LIST_HEAD(&td->io_u_busylist);
+       INIT_LIST_HEAD(&td->io_u_requeues);
        INIT_LIST_HEAD(&td->io_hist_list);
        INIT_LIST_HEAD(&td->io_log_list);
 
@@ -717,15 +717,16 @@ static void *thread_main(void *data)
        }
 
        fio_gettime(&td->epoch, NULL);
-       getrusage(RUSAGE_SELF, &td->ru_start);
+       memcpy(&td->timeout_end, &td->epoch, sizeof(td->epoch));
+       getrusage(RUSAGE_SELF, &td->ts.ru_start);
 
        runtime[0] = runtime[1] = 0;
        while (td->loops--) {
                fio_gettime(&td->start, NULL);
-               memcpy(&td->stat_sample_time, &td->start, sizeof(td->start));
+               memcpy(&td->ts.stat_sample_time, &td->start, sizeof(td->start));
 
                if (td->ratemin)
-                       memcpy(&td->lastrate, &td->stat_sample_time, sizeof(td->lastrate));
+                       memcpy(&td->lastrate, &td->ts.stat_sample_time, sizeof(td->lastrate));
 
                clear_io_state(td);
                prune_io_piece_log(td);
@@ -761,12 +762,12 @@ static void *thread_main(void *data)
        td->runtime[0] = runtime[0] / 1000;
        td->runtime[1] = runtime[1] / 1000;
 
-       if (td->bw_log)
-               finish_log(td, td->bw_log, "bw");
-       if (td->slat_log)
-               finish_log(td, td->slat_log, "slat");
-       if (td->clat_log)
-               finish_log(td, td->clat_log, "clat");
+       if (td->ts.bw_log)
+               finish_log(td, td->ts.bw_log, "bw");
+       if (td->ts.slat_log)
+               finish_log(td, td->ts.slat_log, "slat");
+       if (td->ts.clat_log)
+               finish_log(td, td->ts.clat_log, "clat");
        if (td->write_iolog_file)
                write_iolog_close(td);
        if (td->exec_postrun) {
@@ -784,7 +785,7 @@ err:
        close_ioengine(td);
        cleanup_io_u(td);
        td_set_runstate(td, TD_EXITED);
-       return (void *) td->error;
+       return (void *) (unsigned long) td->error;
 }
 
 /*
@@ -807,7 +808,7 @@ static int fork_main(int shmid, int offset)
        td = data + offset * sizeof(struct thread_data);
        ret = thread_main(td);
        shmdt(data);
-       return (int) ret;
+       return (int) (unsigned long) ret;
 }
 
 /*
@@ -835,9 +836,14 @@ static void reap_threads(int *nr_running, int *t_rate, int *m_rate)
                         * check if someone quit or got killed in an unusual way
                         */
                        ret = waitpid(td->pid, &status, WNOHANG);
-                       if (ret < 0)
+                       if (ret < 0) {
+                               if (errno == ECHILD) {
+                                       log_err("fio: pid=%d disappeared\n", td->pid);
+                                       td_set_runstate(td, TD_REAPED);
+                                       goto reaped;
+                               }
                                perror("waitpid");
-                       else if ((ret == td->pid) && WIFSIGNALED(status)) {
+                       else if ((ret == td->pid) && WIFSIGNALED(status)) {
                                int sig = WTERMSIG(status);
 
                                log_err("fio: pid=%d, got signal=%d\n", td->pid, sig);
@@ -867,9 +873,14 @@ static void reap_threads(int *nr_running, int *t_rate, int *m_rate)
                        int status;
 
                        ret = waitpid(td->pid, &status, 0);
-                       if (ret < 0)
+                       if (ret < 0) {
+                               if (errno == ECHILD) {
+                                       log_err("fio: pid=%d disappeared\n", td->pid);
+                                       td_set_runstate(td, TD_REAPED);
+                                       goto reaped;
+                               }
                                perror("waitpid");
-                       else if (WIFEXITED(status) && WEXITSTATUS(status)) {
+                       else if (WIFEXITED(status) && WEXITSTATUS(status)) {
                                if (!exit_value)
                                        exit_value++;
                        }