[PATCH] Fix fileoffset option

[fio.git] / filesetup.c

diff --git a/filesetup.c b/filesetup.c
index 7a9a2afed29b34d345e1628156c2d3ac6848163c..b8b22b5a54da51504b369b67975c46ef10f95084 100644 (file)
--- a/filesetup.c
+++ b/filesetup.c
@@ -9,6 +9,8 @@
 
 #include "fio.h"
 
+static int root_warn;
+
 static int extend_file(struct thread_data *td, struct fio_file *f)
 {
        int r, new_layout = 0, unlink_file = 0, flags;
@@ -178,7 +180,10 @@ int file_invalidate_cache(struct thread_data *td, struct fio_file *f)
        else if (f->filetype == FIO_TYPE_BD) {
                ret = blockdev_invalidate_cache(f->fd);
                if (ret < 0 && errno == EACCES && geteuid()) {
-                       log_err("fio: only root may flush block devices. Cache flush bypassed!\n");
+                       if (!root_warn) {
+                               log_err("fio: only root may flush block devices. Cache flush bypassed!\n");
+                               root_warn = 1;
+                       }
                        ret = 0;
                }
        } else if (f->filetype == FIO_TYPE_CHAR || f->filetype == FIO_TYPE_PIPE)
@@ -373,6 +378,8 @@ int setup_files(struct thread_data *td)
        extend_size = total_size = 0;
        need_extend = 0;
        for_each_file(td, f, i) {
+               f->file_offset = td->o.start_offset;
+
                if (!td->o.file_size_low) {
                        /*
                         * no file size range given, file size is equal to
@@ -380,20 +387,27 @@ int setup_files(struct thread_data *td)
                         * zero, set it to the real file size.
                         */
                        f->io_size = td->o.size / td->o.nr_files;
-                       if (!f->io_size)
-                               f->io_size = f->real_file_size;
+                       if (!f->io_size) {
+                               if (f->file_offset > f->real_file_size)
+                                       goto err_offset;
+                               f->io_size = f->real_file_size - f->file_offset;
+                       }
                } else if (f->real_file_size < td->o.file_size_low ||
                           f->real_file_size > td->o.file_size_high) {
+                       if (f->file_offset > td->o.file_size_low) 
+                               goto err_offset;
                        /*
                         * file size given. if it's fixed, use that. if it's a
                         * range, generate a random size in-between.
                         */
                        if (td->o.file_size_low == td->o.file_size_high)
-                               f->io_size = td->o.file_size_low;
+                               f->io_size = td->o.file_size_low - f->file_offset;
                        else
-                               f->io_size = get_rand_file_size(td);
-               } else
-                       f->io_size = f->real_file_size;
+                               f->io_size = get_rand_file_size(td) - f->file_offset;
+               } else if (f->file_offset > f->real_file_size)
+                       goto err_offset;
+               else
+                       f->io_size = f->real_file_size - f->file_offset;
 
                if (f->io_size == -1ULL)
                        total_size = -1ULL;
@@ -401,15 +415,15 @@ int setup_files(struct thread_data *td)
                        total_size += f->io_size;
 
                if (f->filetype == FIO_TYPE_FILE &&
-                   f->io_size > f->real_file_size &&
+                   (f->io_size + f->file_offset) > f->real_file_size &&
                    !(td->io_ops->flags & FIO_DISKLESSIO)) {
                        need_extend++;
-                       extend_size += f->io_size;
+                       extend_size += (f->io_size + f->file_offset);
                        f->flags |= FIO_FILE_EXTEND;
-               }
+               }       
        }
 
-       if (!td->o.size)
+       if (!td->o.size || td->o.size > total_size)
                td->o.size = total_size;
 
        /*
@@ -426,7 +440,7 @@ int setup_files(struct thread_data *td)
 
                        assert(f->filetype == FIO_TYPE_FILE);
                        f->flags &= ~FIO_FILE_EXTEND;
-                       f->real_file_size = f->io_size;
+                       f->real_file_size = (f->io_size + f->file_offset);
                        err = extend_file(td, f);
                        if (err)
                                break;
@@ -442,6 +456,9 @@ int setup_files(struct thread_data *td)
 
        td->total_io_size = td->o.size * td->o.loops;
        return 0;
+err_offset:
+       log_err("%s: you need to specify valid offset=\n", td->o.name);
+       return 1;
 }
 
 int init_random_map(struct thread_data *td)