Staticize pmemblk ioengine_ops

[fio.git] / engines / skeleton_external.c

diff --git a/engines/skeleton_external.c b/engines/skeleton_external.c
index 4c0c926c9cc347c6526cf290cb3be3ec3a0bb347..5d6a9ed815104590d5489be289378f1b4e31a2cb 100644 (file)
--- a/engines/skeleton_external.c
+++ b/engines/skeleton_external.c
@@ -13,7 +13,6 @@
 #include <assert.h>
 
 #include "../fio.h"
-#include "../os.h"
 
 /*
  * The core of the module is identical to the ones included with fio,
@@ -38,8 +37,8 @@ static struct io_u *fio_skeleton_event(struct thread_data *td, int event)
  * which may then be retrieved by calling the ->event() hook with the event
  * numbers. Required.
  */
-static int fio_skeleton_getevents(struct thread_data *td, int min, int max,
-                                 struct timespec *t)
+static int fio_skeleton_getevents(struct thread_data *td, unsigned int min,
+                                 unsigned int max, const struct timespec *t)
 {
        return 0;
 }
@@ -60,11 +59,16 @@ static int fio_skeleton_cancel(struct thread_data *td, struct io_u *io_u)
  *
  * The io engine must transfer in the direction noted by io_u->ddir
  * to the buffer pointed to by io_u->xfer_buf for as many bytes as
- * io_u->xfer_buflen. Residual data count may be set in io_u->residual
+ * io_u->xfer_buflen. Residual data count may be set in io_u->resid
  * for a short read/write.
  */
 static int fio_skeleton_queue(struct thread_data *td, struct io_u *io_u)
 {
+       /*
+        * Double sanity check to catch errant write on a readonly setup
+        */
+       fio_ro_check(td, io_u);
+
        /*
         * Could return FIO_Q_QUEUED for a queued request,
         * FIO_Q_COMPLETED for a completed request, and FIO_Q_BUSY
@@ -95,7 +99,7 @@ static int fio_skeleton_init(struct thread_data *td)
 }
 
 /*
- * This is paired with the ->init() funtion and is called when a thread is
+ * This is paired with the ->init() function and is called when a thread is
  * done doing io. Should tear down anything setup by the ->init() function.
  * Not required.
  */
@@ -122,7 +126,7 @@ static int fio_skeleton_close(struct thread_data *td, struct fio_file *f)
 
 /*
  * Note that the structure is exported, so that fio can get it via
- * dlsym(..., "ioengine");
+ * dlsym(..., "ioengine"); for (and only for) external engines.
  */
 struct ioengine_ops ioengine = {
        .name           = "engine_name",