remove redundant _fio_rbd_disconnect, which is already called in

[fio.git] / engines / rbd.c

diff --git a/engines/rbd.c b/engines/rbd.c
index ee2ce813b9ae2d6e3bb2ac3649a9e909573ea7f0..279b314a8c84c458544c0a915a1bb213bba75fdc 100644 (file)
--- a/engines/rbd.c
+++ b/engines/rbd.c
@@ -36,6 +36,7 @@ struct rbd_data {
        struct io_u **aio_events;
        struct io_u **sort_events;
        int fd; /* add for poll */
+       bool connected;
 };
 
 struct rbd_options {
@@ -111,6 +112,8 @@ static int _fio_setup_rbd_data(struct thread_data *td,
        if (!rbd)
                goto failed;
 
+       rbd->connected = false;
+
        /* add for poll, init fd: -1 */
        rbd->fd = -1;
 
@@ -529,6 +532,10 @@ failed:
 static int fio_rbd_init(struct thread_data *td)
 {
        int r;
+       struct rbd_data *rbd = td->io_ops_data;
+
+       if (rbd->connected)
+               return 0;
 
        r = _fio_rbd_connect(td);
        if (r) {
@@ -559,13 +566,8 @@ static int fio_rbd_setup(struct thread_data *td)
        rbd_image_info_t info;
        struct fio_file *f;
        struct rbd_data *rbd = NULL;
-       int major, minor, extra;
        int r;
 
-       /* log version of librbd. No cluster connection required. */
-       rbd_version(&major, &minor, &extra);
-       log_info("rbd engine: RBD version: %d.%d.%d\n", major, minor, extra);
-
        /* allocate engine specific structure to deal with librbd. */
        r = _fio_setup_rbd_data(td, &rbd);
        if (r) {
@@ -589,16 +591,17 @@ static int fio_rbd_setup(struct thread_data *td)
                log_err("fio_rbd_connect failed.\n");
                goto cleanup;
        }
+       rbd->connected = true;
 
        /* get size of the RADOS block device */
        r = rbd_stat(rbd->image, &info, sizeof(info));
        if (r < 0) {
                log_err("rbd_status failed.\n");
-               goto disconnect;
+               goto cleanup;
        } else if (info.size == 0) {
                log_err("image size should be larger than zero.\n");
                r = -EINVAL;
-               goto disconnect;
+               goto cleanup;
        }
 
        dprint(FD_IO, "rbd-engine: image size: %lu\n", info.size);
@@ -615,14 +618,8 @@ static int fio_rbd_setup(struct thread_data *td)
        f = td->files[0];
        f->real_file_size = info.size;
 
-       /* disconnect, then we were only connected to determine
-        * the size of the RBD.
-        */
-       _fio_rbd_disconnect(rbd);
        return 0;
 
-disconnect:
-       _fio_rbd_disconnect(rbd);
 cleanup:
        fio_rbd_cleanup(td);
        return r;