libaio: Add hint on libaio engine init failing

[fio.git] / engines / libaio.c

diff --git a/engines/libaio.c b/engines/libaio.c
index 5295eadfacc113f4a3f13fd0085b205a6a6fe572..7ef3ff8074d005be36a3ef5d90926dc1cc683a0e 100644 (file)
--- a/engines/libaio.c
+++ b/engines/libaio.c
@@ -1,5 +1,7 @@
 /*
- * native linux aio io engine
+ * libaio engine
+ *
+ * IO engine using the Linux native aio interface.
  *
  */
 #include <stdio.h>
@@ -9,7 +11,6 @@
 #include <assert.h>
 
 #include "../fio.h"
-#include "../os.h"
 
 #ifdef FIO_HAVE_LIBAIO
 
@@ -59,8 +60,8 @@ static struct io_u *fio_libaio_event(struct thread_data *td, int event)
        return io_u;
 }
 
-static int fio_libaio_getevents(struct thread_data *td, int min, int max,
-                               struct timespec *t)
+static int fio_libaio_getevents(struct thread_data *td, unsigned int min,
+                               unsigned int max, struct timespec *t)
 {
        struct libaio_data *ld = td->io_ops->data;
        long r;
@@ -85,7 +86,9 @@ static int fio_libaio_queue(struct thread_data *td, struct io_u *io_u)
 {
        struct libaio_data *ld = td->io_ops->data;
 
-       if (ld->iocbs_nr == (int) td->iodepth)
+       fio_ro_check(td, io_u);
+
+       if (ld->iocbs_nr == (int) td->o.iodepth)
                return FIO_Q_BUSY;
 
        /*
@@ -130,36 +133,26 @@ static int fio_libaio_commit(struct thread_data *td)
        struct libaio_data *ld = td->io_ops->data;
        struct iocb **iocbs;
        struct io_u **io_us;
-       int ret, iocbs_nr;
+       int ret;
 
        if (!ld->iocbs_nr)
                return 0;
 
-       iocbs_nr = ld->iocbs_nr;
        io_us = ld->io_us;
        iocbs = ld->iocbs;
        do {
-               ret = io_submit(ld->aio_ctx, iocbs_nr, iocbs);
-               if (ret == iocbs_nr) {
-                       fio_libaio_queued(td, io_us, ret);
-                       ret = 0;
-                       break;
-               } else if (ret > 0) {
+               ret = io_submit(ld->aio_ctx, ld->iocbs_nr, iocbs);
+               if (ret > 0) {
                        fio_libaio_queued(td, io_us, ret);
+                       ld->iocbs_nr -= ret;
                        io_us += ret;
                        iocbs += ret;
-                       iocbs_nr -= ret;
-                       continue;
-               } else if (ret == -EAGAIN || !ret)
-                       usleep(100);
-               else if (ret == -EINTR)
+                       ret = 0;
+               } else if (!ret || ret == -EAGAIN || ret == -EINTR)
                        continue;
                else
                        break;
-       } while (1);
-
-       if (!ret)
-               ld->iocbs_nr = 0;
+       } while (ld->iocbs_nr);
 
        return ret;
 }
@@ -188,20 +181,30 @@ static void fio_libaio_cleanup(struct thread_data *td)
 static int fio_libaio_init(struct thread_data *td)
 {
        struct libaio_data *ld = malloc(sizeof(*ld));
+       static int warn_print;
+       int err;
+
+       if (td->o.iodepth > 1 && !td->o.odirect && !warn_print) {
+               log_info("fio: libaio engine is only async for non-buffered IO\n");
+               warn_print = 1;
+       }
 
        memset(ld, 0, sizeof(*ld));
-       if (io_queue_init(td->iodepth, &ld->aio_ctx)) {
-               td_verror(td, errno, "io_queue_init");
+
+       err = io_queue_init(td->o.iodepth, &ld->aio_ctx);
+       if (err) {
+               td_verror(td, -err, "io_queue_init");
+               log_err("fio: check /proc/sys/fs/aio-max-nr\n");
                free(ld);
                return 1;
        }
 
-       ld->aio_events = malloc(td->iodepth * sizeof(struct io_event));
-       memset(ld->aio_events, 0, td->iodepth * sizeof(struct io_event));
-       ld->iocbs = malloc(td->iodepth * sizeof(struct iocb *));
+       ld->aio_events = malloc(td->o.iodepth * sizeof(struct io_event));
+       memset(ld->aio_events, 0, td->o.iodepth * sizeof(struct io_event));
+       ld->iocbs = malloc(td->o.iodepth * sizeof(struct iocb *));
        memset(ld->iocbs, 0, sizeof(struct iocb *));
-       ld->io_us = malloc(td->iodepth * sizeof(struct io_u *));
-       memset(ld->io_us, 0, td->iodepth * sizeof(struct io_u *));
+       ld->io_us = malloc(td->o.iodepth * sizeof(struct io_u *));
+       memset(ld->io_us, 0, td->o.iodepth * sizeof(struct io_u *));
        ld->iocbs_nr = 0;
 
        td->io_ops->data = ld;