client: replace duplicate code with read_data()
[fio.git] / client.c
index 678a62753021035568cec1fb54ac1f23e8d7bcca..52440f067aed33cd9b03876a385e0ebe0ca1b7e6 100644 (file)
--- a/client.c
+++ b/client.c
 #include <arpa/inet.h>
 #include <netdb.h>
 #include <signal.h>
+#ifdef CONFIG_ZLIB
 #include <zlib.h>
+#endif
 
 #include "fio.h"
 #include "client.h"
 #include "server.h"
 #include "flist.h"
 #include "hash.h"
+#include "verify.h"
 
 static void handle_du(struct fio_client *client, struct fio_net_cmd *cmd);
 static void handle_ts(struct fio_client *client, struct fio_net_cmd *cmd);
@@ -55,6 +58,9 @@ struct group_run_stats client_gs;
 int sum_stat_clients;
 
 static int sum_stat_nr;
+static struct json_object *root = NULL;
+static struct json_array *clients_array = NULL;
+static struct json_array *du_array = NULL;
 
 #define FIO_CLIENT_HASH_BITS   7
 #define FIO_CLIENT_HASH_SZ     (1 << FIO_CLIENT_HASH_BITS)
@@ -83,6 +89,54 @@ static void fio_init fio_client_hash_init(void)
                INIT_FLIST_HEAD(&client_hash[i]);
 }
 
+static int read_data(int fd, void *data, size_t size)
+{
+       ssize_t ret;
+
+       while (size) {
+               ret = read(fd, data, size);
+               if (ret < 0) {
+                       if (errno == EAGAIN || errno == EINTR)
+                               continue;
+                       break;
+               } else if (!ret)
+                       break;
+               else {
+                       data += ret;
+                       size -= ret;
+               }
+       }
+
+       if (size)
+               return EAGAIN;
+
+       return 0;
+}
+
+static void fio_client_json_init(void)
+{
+       if (output_format != FIO_OUTPUT_JSON)
+               return;
+       root = json_create_object();
+       json_object_add_value_string(root, "fio version", fio_version_string);
+       clients_array = json_create_array();
+       json_object_add_value_array(root, "client_stats", clients_array);
+       du_array = json_create_array();
+       json_object_add_value_array(root, "disk_util", du_array);
+}
+
+static void fio_client_json_fini(void)
+{
+       if (output_format != FIO_OUTPUT_JSON)
+               return;
+       json_print_object(root);
+       log_info("\n");
+       json_free_object(root);
+       root = NULL;
+       clients_array = NULL;
+       du_array = NULL;
+}
+
 static struct fio_client *find_client_by_fd(int fd)
 {
        int bucket = hash_long(fd, FIO_CLIENT_HASH_BITS) & FIO_CLIENT_HASH_MASK;
@@ -111,6 +165,16 @@ void fio_put_client(struct fio_client *client)
                free(client->argv);
        if (client->name)
                free(client->name);
+       while (client->nr_files) {
+               struct client_file *cf = &client->files[--client->nr_files];
+
+               free(cf->file);
+       }
+       if (client->files)
+               free(client->files);
+
+       if (!client->did_stat)
+               sum_stat_clients--;
 
        free(client);
 }
@@ -131,9 +195,13 @@ static void remove_client(struct fio_client *client)
                fio_client_dec_jobs_eta(client->eta_in_flight, client->ops->eta);
        }
 
-       nr_clients--;
-       sum_stat_clients--;
+       close(client->fd);
+       client->fd = -1;
 
+       if (client->ops->removed)
+               client->ops->removed(client);
+
+       nr_clients--;
        fio_put_client(client);
 }
 
@@ -197,7 +265,7 @@ struct fio_client *fio_client_add_explicit(struct client_ops *ops,
                int ipv6;
 
                ipv6 = type == Fio_client_ipv6;
-               if (fio_server_parse_host(hostname, &ipv6,
+               if (fio_server_parse_host(hostname, ipv6,
                                                &client->addr.sin_addr,
                                                &client->addr6.sin6_addr))
                        goto err;
@@ -221,6 +289,31 @@ err:
        return NULL;
 }
 
+int fio_client_add_ini_file(void *cookie, const char *ini_file, int remote)
+{
+       struct fio_client *client = cookie;
+       struct client_file *cf;
+       size_t new_size;
+       void *new_files;
+
+       if (!client)
+               return 1;
+
+       dprint(FD_NET, "client <%s>: add ini %s\n", client->hostname, ini_file);
+
+       new_size = (client->nr_files + 1) * sizeof(struct client_file);
+       new_files = realloc(client->files, new_size);
+       if (!new_files)
+               return 1;
+
+       client->files = new_files;
+       cf = &client->files[client->nr_files];
+       cf->file = strdup(ini_file);
+       cf->remote = remote;
+       client->nr_files++;
+       return 0;
+}
+
 int fio_client_add(struct client_ops *ops, const char *hostname, void **cookie)
 {
        struct fio_client *existing = *cookie;
@@ -269,17 +362,44 @@ int fio_client_add(struct client_ops *ops, const char *hostname, void **cookie)
        return 0;
 }
 
+static const char *server_name(struct fio_client *client, char *buf,
+                              size_t bufsize)
+{
+       const char *from;
+
+       if (client->ipv6)
+               from = inet_ntop(AF_INET6, (struct sockaddr *) &client->addr6.sin6_addr, buf, bufsize);
+       else if (client->is_sock)
+               from = "sock";
+       else
+               from = inet_ntop(AF_INET, (struct sockaddr *) &client->addr.sin_addr, buf, bufsize);
+
+       return from;
+}
+
 static void probe_client(struct fio_client *client)
 {
+       struct cmd_client_probe_pdu pdu;
+       uint64_t tag;
+       char buf[64];
+
        dprint(FD_NET, "client: send probe\n");
 
-       fio_net_send_simple_cmd(client->fd, FIO_NET_CMD_PROBE, 0, &client->cmd_list);
+#ifdef CONFIG_ZLIB
+       pdu.flags = __le64_to_cpu(FIO_PROBE_FLAG_ZLIB);
+#else
+       pdu.flags = 0;
+#endif
+
+       strcpy((char *) pdu.server, server_name(client, buf, sizeof(buf)));
+
+       fio_net_send_cmd(client->fd, FIO_NET_CMD_PROBE, &pdu, sizeof(pdu), &tag, &client->cmd_list);
 }
 
 static int fio_client_connect_ip(struct fio_client *client)
 {
        struct sockaddr *addr;
-       fio_socklen_t socklen;
+       socklen_t socklen;
        int fd, domain;
 
        if (client->ipv6) {
@@ -320,12 +440,12 @@ static int fio_client_connect_ip(struct fio_client *client)
 static int fio_client_connect_sock(struct fio_client *client)
 {
        struct sockaddr_un *addr = &client->addr_un;
-       fio_socklen_t len;
+       socklen_t len;
        int fd;
 
        memset(addr, 0, sizeof(*addr));
        addr->sun_family = AF_UNIX;
-       strcpy(addr->sun_path, client->hostname);
+       strncpy(addr->sun_path, client->hostname, sizeof(addr->sun_path) - 1);
 
        fd = socket(AF_UNIX, SOCK_STREAM, 0);
        if (fd < 0) {
@@ -371,9 +491,9 @@ int fio_client_connect(struct fio_client *client)
        return 0;
 }
 
-void fio_client_terminate(struct fio_client *client)
+int fio_client_terminate(struct fio_client *client)
 {
-       fio_net_send_simple_cmd(client->fd, FIO_NET_CMD_QUIT, 0, NULL);
+       return fio_net_send_quit(client->fd);
 }
 
 void fio_clients_terminate(void)
@@ -395,6 +515,11 @@ static void sig_int(int sig)
        fio_clients_terminate();
 }
 
+static void sig_show_status(int sig)
+{
+       show_running_run_stats();
+}
+
 static void client_signal_handler(void)
 {
        struct sigaction act;
@@ -408,6 +533,19 @@ static void client_signal_handler(void)
        act.sa_handler = sig_int;
        act.sa_flags = SA_RESTART;
        sigaction(SIGTERM, &act, NULL);
+
+/* Windows uses SIGBREAK as a quit signal from other applications */
+#ifdef WIN32
+       memset(&act, 0, sizeof(act));
+       act.sa_handler = sig_int;
+       act.sa_flags = SA_RESTART;
+       sigaction(SIGBREAK, &act, NULL);
+#endif
+
+       memset(&act, 0, sizeof(act));
+       act.sa_handler = sig_show_status;
+       act.sa_flags = SA_RESTART;
+       sigaction(SIGUSR1, &act, NULL);
 }
 
 static int send_client_cmd_line(struct fio_client *client)
@@ -453,7 +591,7 @@ static int send_client_cmd_line(struct fio_client *client)
        free(lens);
        clp->lines = cpu_to_le16(client->argc);
        clp->client_type = __cpu_to_le16(client->type);
-       ret = fio_net_send_cmd(client->fd, FIO_NET_CMD_JOBLINE, pdu, mem, 0);
+       ret = fio_net_send_cmd(client->fd, FIO_NET_CMD_JOBLINE, pdu, mem, NULL, NULL);
        free(pdu);
        return ret;
 }
@@ -466,7 +604,7 @@ int fio_clients_connect(void)
 
 #ifdef WIN32
        WSADATA wsd;
-       WSAStartup(MAKEWORD(2,2), &wsd);
+       WSAStartup(MAKEWORD(2, 2), &wsd);
 #endif
 
        dprint(FD_NET, "client: connect all\n");
@@ -503,6 +641,8 @@ int fio_start_all_clients(void)
 
        dprint(FD_NET, "client: start all\n");
 
+       fio_client_json_init();
+
        flist_for_each_safe(entry, tmp, &client_list) {
                client = flist_entry(entry, struct fio_client, list);
 
@@ -516,11 +656,34 @@ int fio_start_all_clients(void)
        return flist_empty(&client_list);
 }
 
+static int __fio_client_send_remote_ini(struct fio_client *client,
+                                       const char *filename)
+{
+       struct cmd_load_file_pdu *pdu;
+       size_t p_size;
+       int ret;
+
+       dprint(FD_NET, "send remote ini %s to %s\n", filename, client->hostname);
+
+       p_size = sizeof(*pdu) + strlen(filename) + 1;
+       pdu = malloc(p_size);
+       memset(pdu, 0, p_size);
+       pdu->name_len = strlen(filename);
+       strcpy((char *) pdu->file, filename);
+       pdu->client_type = cpu_to_le16((uint16_t) client->type);
+
+       client->sent_job = 1;
+       ret = fio_net_send_cmd(client->fd, FIO_NET_CMD_LOAD_FILE, pdu, p_size,NULL, NULL);
+       free(pdu);
+       return ret;
+}
+
 /*
  * Send file contents to server backend. We could use sendfile(), but to remain
  * more portable lets just read/write the darn thing.
  */
-static int __fio_client_send_ini(struct fio_client *client, const char *filename)
+static int __fio_client_send_local_ini(struct fio_client *client,
+                                      const char *filename)
 {
        struct cmd_job_pdu *pdu;
        size_t p_size;
@@ -534,15 +697,13 @@ static int __fio_client_send_ini(struct fio_client *client, const char *filename
 
        fd = open(filename, O_RDONLY);
        if (fd < 0) {
-               int ret = -errno;
-
+               ret = -errno;
                log_err("fio: job file <%s> open: %s\n", filename, strerror(errno));
                return ret;
        }
 
        if (fstat(fd, &sb) < 0) {
-               int ret = -errno;
-
+               ret = -errno;
                log_err("fio: job file stat: %s\n", strerror(errno));
                close(fd);
                return ret;
@@ -554,24 +715,10 @@ static int __fio_client_send_ini(struct fio_client *client, const char *filename
 
        len = sb.st_size;
        p = buf;
-       do {
-               ret = read(fd, p, len);
-               if (ret > 0) {
-                       len -= ret;
-                       if (!len)
-                               break;
-                       p += ret;
-                       continue;
-               } else if (!ret)
-                       break;
-               else if (errno == EAGAIN || errno == EINTR)
-                       continue;
-       } while (1);
-
-       if (len) {
+       if (read_data(fd, p, len)) {
                log_err("fio: failed reading job file %s\n", filename);
                close(fd);
-               free(buf);
+               free(pdu);
                return 1;
        }
 
@@ -579,23 +726,34 @@ static int __fio_client_send_ini(struct fio_client *client, const char *filename
        pdu->client_type = cpu_to_le32(client->type);
 
        client->sent_job = 1;
-       ret = fio_net_send_cmd(client->fd, FIO_NET_CMD_JOB, pdu, p_size, 0);
+       ret = fio_net_send_cmd(client->fd, FIO_NET_CMD_JOB, pdu, p_size, NULL, NULL);
        free(pdu);
        close(fd);
        return ret;
 }
 
-int fio_client_send_ini(struct fio_client *client, const char *filename)
+int fio_client_send_ini(struct fio_client *client, const char *filename,
+                       int remote)
 {
        int ret;
 
-       ret = __fio_client_send_ini(client, filename);
+       if (!remote)
+               ret = __fio_client_send_local_ini(client, filename);
+       else
+               ret = __fio_client_send_remote_ini(client, filename);
+
        if (!ret)
                client->sent_job = 1;
 
        return ret;
 }
 
+static int fio_client_send_cf(struct fio_client *client,
+                             struct client_file *cf)
+{
+       return fio_client_send_ini(client, cf->file, cf->remote);
+}
+
 int fio_clients_send_ini(const char *filename)
 {
        struct fio_client *client;
@@ -604,13 +762,41 @@ int fio_clients_send_ini(const char *filename)
        flist_for_each_safe(entry, tmp, &client_list) {
                client = flist_entry(entry, struct fio_client, list);
 
-               if (fio_client_send_ini(client, filename))
+               if (client->nr_files) {
+                       int i;
+
+                       for (i = 0; i < client->nr_files; i++) {
+                               struct client_file *cf;
+
+                               cf = &client->files[i];
+
+                               if (fio_client_send_cf(client, cf)) {
+                                       remove_client(client);
+                                       break;
+                               }
+                       }
+               }
+               if (client->sent_job)
+                       continue;
+               if (!filename || fio_client_send_ini(client, filename, 0))
                        remove_client(client);
        }
 
        return !nr_clients;
 }
 
+int fio_client_update_options(struct fio_client *client,
+                             struct thread_options *o, uint64_t *tag)
+{
+       struct cmd_add_job_pdu pdu;
+
+       pdu.thread_number = cpu_to_le32(client->thread_number);
+       pdu.groupid = cpu_to_le32(client->groupid);
+       convert_thread_options_to_net(&pdu.top, o);
+
+       return fio_net_send_cmd(client->fd, FIO_NET_CMD_UPDATE_JOB, &pdu, sizeof(pdu), tag, &client->cmd_list);
+}
+
 static void convert_io_stat(struct io_stat *dst, struct io_stat *src)
 {
        dst->max_val    = le64_to_cpu(src->max_val);
@@ -628,12 +814,14 @@ static void convert_ts(struct thread_stat *dst, struct thread_stat *src)
 {
        int i, j;
 
-       dst->error      = le32_to_cpu(src->error);
-       dst->groupid    = le32_to_cpu(src->groupid);
-       dst->pid        = le32_to_cpu(src->pid);
-       dst->members    = le32_to_cpu(src->members);
+       dst->error              = le32_to_cpu(src->error);
+       dst->thread_number      = le32_to_cpu(src->thread_number);
+       dst->groupid            = le32_to_cpu(src->groupid);
+       dst->pid                = le32_to_cpu(src->pid);
+       dst->members            = le32_to_cpu(src->members);
+       dst->unified_rw_rep     = le32_to_cpu(src->unified_rw_rep);
 
-       for (i = 0; i < 2; i++) {
+       for (i = 0; i < DDIR_RWDIR_CNT; i++) {
                convert_io_stat(&dst->clat_stat[i], &src->clat_stat[i]);
                convert_io_stat(&dst->slat_stat[i], &src->slat_stat[i]);
                convert_io_stat(&dst->lat_stat[i], &src->lat_stat[i]);
@@ -646,6 +834,7 @@ static void convert_ts(struct thread_stat *dst, struct thread_stat *src)
        dst->minf               = le64_to_cpu(src->minf);
        dst->majf               = le64_to_cpu(src->majf);
        dst->clat_percentiles   = le64_to_cpu(src->clat_percentiles);
+       dst->percentile_precision = le64_to_cpu(src->percentile_precision);
 
        for (i = 0; i < FIO_IO_U_LIST_MAX_LEN; i++) {
                fio_fp64_t *fps = &src->percentile_list[i];
@@ -665,19 +854,20 @@ static void convert_ts(struct thread_stat *dst, struct thread_stat *src)
                dst->io_u_lat_m[i]      = le32_to_cpu(src->io_u_lat_m[i]);
        }
 
-       for (i = 0; i < 2; i++)
+       for (i = 0; i < DDIR_RWDIR_CNT; i++)
                for (j = 0; j < FIO_IO_U_PLAT_NR; j++)
                        dst->io_u_plat[i][j] = le32_to_cpu(src->io_u_plat[i][j]);
 
-       for (i = 0; i < 3; i++) {
+       for (i = 0; i < DDIR_RWDIR_CNT; i++) {
                dst->total_io_u[i]      = le64_to_cpu(src->total_io_u[i]);
                dst->short_io_u[i]      = le64_to_cpu(src->short_io_u[i]);
+               dst->drop_io_u[i]       = le64_to_cpu(src->drop_io_u[i]);
        }
 
        dst->total_submit       = le64_to_cpu(src->total_submit);
        dst->total_complete     = le64_to_cpu(src->total_complete);
 
-       for (i = 0; i < 2; i++) {
+       for (i = 0; i < DDIR_RWDIR_CNT; i++) {
                dst->io_bytes[i]        = le64_to_cpu(src->io_bytes[i]);
                dst->runtime[i]         = le64_to_cpu(src->runtime[i]);
        }
@@ -687,13 +877,19 @@ static void convert_ts(struct thread_stat *dst, struct thread_stat *src)
        dst->total_err_count    = le64_to_cpu(src->total_err_count);
        dst->first_error        = le32_to_cpu(src->first_error);
        dst->kb_base            = le32_to_cpu(src->kb_base);
+       dst->unit_base          = le32_to_cpu(src->unit_base);
+
+       dst->latency_depth      = le32_to_cpu(src->latency_depth);
+       dst->latency_target     = le64_to_cpu(src->latency_target);
+       dst->latency_window     = le64_to_cpu(src->latency_window);
+       dst->latency_percentile.u.f = fio_uint64_to_double(le64_to_cpu(src->latency_percentile.u.i));
 }
 
 static void convert_gs(struct group_run_stats *dst, struct group_run_stats *src)
 {
        int i;
 
-       for (i = 0; i < 2; i++) {
+       for (i = 0; i < DDIR_RWDIR_CNT; i++) {
                dst->max_run[i]         = le64_to_cpu(src->max_run[i]);
                dst->min_run[i]         = le64_to_cpu(src->min_run[i]);
                dst->max_bw[i]          = le64_to_cpu(src->max_bw[i]);
@@ -703,27 +899,50 @@ static void convert_gs(struct group_run_stats *dst, struct group_run_stats *src)
        }
 
        dst->kb_base    = le32_to_cpu(src->kb_base);
+       dst->unit_base  = le32_to_cpu(src->unit_base);
        dst->groupid    = le32_to_cpu(src->groupid);
+       dst->unified_rw_rep     = le32_to_cpu(src->unified_rw_rep);
+}
+
+static void json_object_add_client_info(struct json_object *obj,
+                                       struct fio_client *client)
+{
+       const char *hostname = client->hostname ? client->hostname : "";
+
+       json_object_add_value_string(obj, "hostname", hostname);
+       json_object_add_value_int(obj, "port", client->port);
 }
 
 static void handle_ts(struct fio_client *client, struct fio_net_cmd *cmd)
 {
        struct cmd_ts_pdu *p = (struct cmd_ts_pdu *) cmd->payload;
+       struct json_object *tsobj;
 
-       show_thread_status(&p->ts, &p->rs);
+       tsobj = show_thread_status(&p->ts, &p->rs);
+       client->did_stat = 1;
+       if (tsobj) {
+               json_object_add_client_info(tsobj, client);
+               json_array_add_value_object(clients_array, tsobj);
+       }
 
-       if (sum_stat_clients == 1)
+       if (sum_stat_clients <= 1)
                return;
 
        sum_thread_stats(&client_ts, &p->ts, sum_stat_nr);
        sum_group_stats(&client_gs, &p->rs);
 
        client_ts.members++;
+       client_ts.thread_number = p->ts.thread_number;
        client_ts.groupid = p->ts.groupid;
+       client_ts.unified_rw_rep = p->ts.unified_rw_rep;
 
        if (++sum_stat_nr == sum_stat_clients) {
                strcpy(client_ts.name, "All clients");
-               show_thread_status(&client_ts, &client_gs);
+               tsobj = show_thread_status(&client_ts, &client_gs);
+               if (tsobj) {
+                       json_object_add_client_info(tsobj, client);
+                       json_array_add_value_object(clients_array, tsobj);
+               }
        }
 }
 
@@ -764,7 +983,7 @@ static void convert_agg(struct disk_util_agg *agg)
        agg->io_ticks           = le32_to_cpu(agg->io_ticks);
        agg->time_in_queue      = le32_to_cpu(agg->time_in_queue);
        agg->slavecount         = le32_to_cpu(agg->slavecount);
-       agg->max_util.u.f       = fio_uint64_to_double(__le64_to_cpu(agg->max_util.u.i));
+       agg->max_util.u.f       = fio_uint64_to_double(le64_to_cpu(agg->max_util.u.i));
 }
 
 static void convert_dus(struct disk_util_stat *dus)
@@ -772,15 +991,15 @@ static void convert_dus(struct disk_util_stat *dus)
        int i;
 
        for (i = 0; i < 2; i++) {
-               dus->ios[i]     = le32_to_cpu(dus->ios[i]);
-               dus->merges[i]  = le32_to_cpu(dus->merges[i]);
-               dus->sectors[i] = le64_to_cpu(dus->sectors[i]);
-               dus->ticks[i]   = le32_to_cpu(dus->ticks[i]);
+               dus->s.ios[i]           = le32_to_cpu(dus->s.ios[i]);
+               dus->s.merges[i]        = le32_to_cpu(dus->s.merges[i]);
+               dus->s.sectors[i]       = le64_to_cpu(dus->s.sectors[i]);
+               dus->s.ticks[i]         = le32_to_cpu(dus->s.ticks[i]);
        }
 
-       dus->io_ticks           = le32_to_cpu(dus->io_ticks);
-       dus->time_in_queue      = le32_to_cpu(dus->time_in_queue);
-       dus->msec               = le64_to_cpu(dus->msec);
+       dus->s.io_ticks         = le32_to_cpu(dus->s.io_ticks);
+       dus->s.time_in_queue    = le32_to_cpu(dus->s.time_in_queue);
+       dus->s.msec             = le64_to_cpu(dus->s.msec);
 }
 
 static void handle_du(struct fio_client *client, struct fio_net_cmd *cmd)
@@ -792,7 +1011,13 @@ static void handle_du(struct fio_client *client, struct fio_net_cmd *cmd)
                log_info("\nDisk stats (read/write):\n");
        }
 
-       print_disk_util(&du->dus, &du->agg, terse_output);
+       if (output_format == FIO_OUTPUT_JSON) {
+               struct json_object *duobj;
+               json_array_add_disk_util(&du->dus, &du->agg, du_array);
+               duobj = json_array_last_value_object(du_array);
+               json_object_add_client_info(duobj, client);
+       } else
+               print_disk_util(&du->dus, &du->agg, output_format == FIO_OUTPUT_TERSE);
 }
 
 static void convert_jobs_eta(struct jobs_eta *je)
@@ -802,13 +1027,14 @@ static void convert_jobs_eta(struct jobs_eta *je)
        je->nr_running          = le32_to_cpu(je->nr_running);
        je->nr_ramp             = le32_to_cpu(je->nr_ramp);
        je->nr_pending          = le32_to_cpu(je->nr_pending);
+       je->nr_setting_up       = le32_to_cpu(je->nr_setting_up);
        je->files_open          = le32_to_cpu(je->files_open);
 
-       for (i = 0; i < 2; i++) {
-               je->m_rate[i]           = le32_to_cpu(je->m_rate[i]);
-               je->t_rate[i]           = le32_to_cpu(je->t_rate[i]);
-               je->m_iops[i]           = le32_to_cpu(je->m_iops[i]);
-               je->t_iops[i]           = le32_to_cpu(je->t_iops[i]);
+       for (i = 0; i < DDIR_RWDIR_CNT; i++) {
+               je->m_rate[i]   = le32_to_cpu(je->m_rate[i]);
+               je->t_rate[i]   = le32_to_cpu(je->t_rate[i]);
+               je->m_iops[i]   = le32_to_cpu(je->m_iops[i]);
+               je->t_iops[i]   = le32_to_cpu(je->t_iops[i]);
                je->rate[i]     = le32_to_cpu(je->rate[i]);
                je->iops[i]     = le32_to_cpu(je->iops[i]);
        }
@@ -816,6 +1042,8 @@ static void convert_jobs_eta(struct jobs_eta *je)
        je->elapsed_sec         = le64_to_cpu(je->elapsed_sec);
        je->eta_sec             = le64_to_cpu(je->eta_sec);
        je->nr_threads          = le32_to_cpu(je->nr_threads);
+       je->is_pow2             = le32_to_cpu(je->is_pow2);
+       je->unit_base           = le32_to_cpu(je->unit_base);
 }
 
 void fio_client_sum_jobs_eta(struct jobs_eta *dst, struct jobs_eta *je)
@@ -825,9 +1053,10 @@ void fio_client_sum_jobs_eta(struct jobs_eta *dst, struct jobs_eta *je)
        dst->nr_running         += je->nr_running;
        dst->nr_ramp            += je->nr_ramp;
        dst->nr_pending         += je->nr_pending;
+       dst->nr_setting_up      += je->nr_setting_up;
        dst->files_open         += je->files_open;
 
-       for (i = 0; i < 2; i++) {
+       for (i = 0; i < DDIR_RWDIR_CNT; i++) {
                dst->m_rate[i]  += je->m_rate[i];
                dst->t_rate[i]  += je->t_rate[i];
                dst->m_iops[i]  += je->m_iops[i];
@@ -842,7 +1071,12 @@ void fio_client_sum_jobs_eta(struct jobs_eta *dst, struct jobs_eta *je)
                dst->eta_sec = je->eta_sec;
 
        dst->nr_threads         += je->nr_threads;
-       /* we need to handle je->run_str too ... */
+
+       /*
+        * This wont be correct for multiple strings, but at least it
+        * works for the basic cases.
+        */
+       strcpy((char *) dst->run_str, (char *) je->run_str);
 }
 
 void fio_client_dec_jobs_eta(struct client_eta *eta, client_eta_op eta_fn)
@@ -855,26 +1089,50 @@ void fio_client_dec_jobs_eta(struct client_eta *eta, client_eta_op eta_fn)
 
 static void remove_reply_cmd(struct fio_client *client, struct fio_net_cmd *cmd)
 {
-       struct fio_net_int_cmd *icmd = NULL;
+       struct fio_net_cmd_reply *reply = NULL;
        struct flist_head *entry;
 
        flist_for_each(entry, &client->cmd_list) {
-               icmd = flist_entry(entry, struct fio_net_int_cmd, list);
+               reply = flist_entry(entry, struct fio_net_cmd_reply, list);
 
-               if (cmd->tag == (uintptr_t) icmd)
+               if (cmd->tag == (uintptr_t) reply)
                        break;
 
-               icmd = NULL;
+               reply = NULL;
        }
 
-       if (!icmd) {
-               log_err("fio: client: unable to find matching tag\n");
+       if (!reply) {
+               log_err("fio: client: unable to find matching tag (%llx)\n", (unsigned long long) cmd->tag);
                return;
        }
 
-       flist_del(&icmd->list);
-       cmd->tag = icmd->saved_tag;
-       free(icmd);
+       flist_del(&reply->list);
+       cmd->tag = reply->saved_tag;
+       free(reply);
+}
+
+int fio_client_wait_for_reply(struct fio_client *client, uint64_t tag)
+{
+       do {
+               struct fio_net_cmd_reply *reply = NULL;
+               struct flist_head *entry;
+
+               flist_for_each(entry, &client->cmd_list) {
+                       reply = flist_entry(entry, struct fio_net_cmd_reply, list);
+
+                       if (tag == (uintptr_t) reply)
+                               break;
+
+                       reply = NULL;
+               }
+
+               if (!reply)
+                       break;
+
+               usleep(1000);
+       } while (1);
+
+       return 0;
 }
 
 static void handle_eta(struct fio_client *client, struct fio_net_cmd *cmd)
@@ -898,7 +1156,7 @@ static void handle_eta(struct fio_client *client, struct fio_net_cmd *cmd)
 
 static void handle_probe(struct fio_client *client, struct fio_net_cmd *cmd)
 {
-       struct cmd_probe_pdu *probe = (struct cmd_probe_pdu *) cmd->payload;
+       struct cmd_probe_reply_pdu *probe = (struct cmd_probe_reply_pdu *) cmd->payload;
        const char *os, *arch;
        char bit[16];
 
@@ -911,10 +1169,11 @@ static void handle_probe(struct fio_client *client, struct fio_net_cmd *cmd)
                os = "unknown";
 
        sprintf(bit, "%d-bit", probe->bpp * 8);
+       probe->flags = le64_to_cpu(probe->flags);
 
-       log_info("hostname=%s, be=%u, %s, os=%s, arch=%s, fio=%u.%u.%u\n",
+       log_info("hostname=%s, be=%u, %s, os=%s, arch=%s, fio=%s, flags=%lx\n",
                probe->hostname, probe->bigendian, bit, os, arch,
-               probe->fio_major, probe->fio_minor, probe->fio_patch);
+               probe->fio_version, (unsigned long) probe->flags);
 
        if (!client->name)
                client->name = strdup((char *) probe->hostname);
@@ -925,7 +1184,10 @@ static void handle_start(struct fio_client *client, struct fio_net_cmd *cmd)
        struct cmd_start_pdu *pdu = (struct cmd_start_pdu *) cmd->payload;
 
        client->state = Client_started;
-       client->jobs = pdu->jobs;
+       client->jobs = le32_to_cpu(pdu->jobs);
+       client->nr_stat = le32_to_cpu(pdu->stat_outputs);
+
+       sum_stat_clients += client->nr_stat;
 }
 
 static void handle_stop(struct fio_client *client, struct fio_net_cmd *cmd)
@@ -951,19 +1213,15 @@ static void convert_text(struct fio_net_cmd *cmd)
        pdu->log_usec   = le64_to_cpu(pdu->log_usec);
 }
 
-/*
- * This has been compressed on the server side, since it can be big.
- * Uncompress here.
- */
-static struct cmd_iolog_pdu *convert_iolog(struct fio_net_cmd *cmd)
+static struct cmd_iolog_pdu *convert_iolog_gz(struct fio_net_cmd *cmd,
+                                             struct cmd_iolog_pdu *pdu)
 {
-       struct cmd_iolog_pdu *pdu = (struct cmd_iolog_pdu *) cmd->payload;
+#ifdef CONFIG_ZLIB
        struct cmd_iolog_pdu *ret;
-       uint32_t nr_samples;
-       unsigned long total;
        z_stream stream;
+       uint32_t nr_samples;
+       size_t total;
        void *p;
-       int i;
 
        stream.zalloc = Z_NULL;
        stream.zfree = Z_NULL;
@@ -977,13 +1235,13 @@ static struct cmd_iolog_pdu *convert_iolog(struct fio_net_cmd *cmd)
        /*
         * Get header first, it's not compressed
         */
-       nr_samples = le32_to_cpu(pdu->nr_samples);
+       nr_samples = le64_to_cpu(pdu->nr_samples);
 
-       total = nr_samples * sizeof(struct io_sample);
+       total = nr_samples * __log_entry_sz(le32_to_cpu(pdu->log_offset));
        ret = malloc(total + sizeof(*pdu));
        ret->nr_samples = nr_samples;
-       ret->log_type = le32_to_cpu(pdu->log_type);
-       strcpy((char *) ret->name, (char *) pdu->name);
+
+       memcpy(ret, pdu, sizeof(*pdu));
 
        p = (void *) ret + sizeof(*pdu);
 
@@ -1005,7 +1263,7 @@ static struct cmd_iolog_pdu *convert_iolog(struct fio_net_cmd *cmd)
                        log_err("fio: inflate error %d\n", err);
                        free(ret);
                        ret = NULL;
-                       goto out;
+                       goto err;
                }
 
                this_len = this_chunk - stream.avail_out;
@@ -1013,20 +1271,109 @@ static struct cmd_iolog_pdu *convert_iolog(struct fio_net_cmd *cmd)
                total -= this_len;
        }
 
+err:
+       inflateEnd(&stream);
+       return ret;
+#else
+       return NULL;
+#endif
+}
+
+/*
+ * This has been compressed on the server side, since it can be big.
+ * Uncompress here.
+ */
+static struct cmd_iolog_pdu *convert_iolog(struct fio_net_cmd *cmd)
+{
+       struct cmd_iolog_pdu *pdu = (struct cmd_iolog_pdu *) cmd->payload;
+       struct cmd_iolog_pdu *ret;
+       uint64_t i;
+       void *samples;
+
+       /*
+        * Convert if compressed and we support it. If it's not
+        * compressed, we need not do anything.
+        */
+       if (le32_to_cpu(pdu->compressed)) {
+#ifndef CONFIG_ZLIB
+               log_err("fio: server sent compressed data by mistake\n");
+               return NULL;
+#endif
+               ret = convert_iolog_gz(cmd, pdu);
+               if (!ret) {
+                       log_err("fio: failed decompressing log\n");
+                       return NULL;
+               }
+       } else
+               ret = pdu;
+
+       ret->nr_samples         = le64_to_cpu(ret->nr_samples);
+       ret->thread_number      = le32_to_cpu(ret->thread_number);
+       ret->log_type           = le32_to_cpu(ret->log_type);
+       ret->compressed         = le32_to_cpu(ret->compressed);
+       ret->log_offset         = le32_to_cpu(ret->log_offset);
+
+       samples = &ret->samples[0];
        for (i = 0; i < ret->nr_samples; i++) {
-               struct io_sample *s = &ret->samples[i];
+               struct io_sample *s;
 
-               s->time = le64_to_cpu(s->time);
-               s->val  = le64_to_cpu(s->val);
-               s->ddir = le32_to_cpu(s->ddir);
-               s->bs   = le32_to_cpu(s->bs);
+               s = __get_sample(samples, ret->log_offset, i);
+               s->time         = le64_to_cpu(s->time);
+               s->val          = le64_to_cpu(s->val);
+               s->__ddir       = le32_to_cpu(s->__ddir);
+               s->bs           = le32_to_cpu(s->bs);
+
+               if (ret->log_offset) {
+                       struct io_sample_offset *so = (void *) s;
+
+                       so->offset = le64_to_cpu(so->offset);
+               }
        }
 
-out:
-       inflateEnd(&stream);
        return ret;
 }
 
+static void sendfile_reply(int fd, struct cmd_sendfile_reply *rep,
+                          size_t size, uint64_t tag)
+{
+       rep->error = cpu_to_le32(rep->error);
+       fio_net_send_cmd(fd, FIO_NET_CMD_SENDFILE, rep, size, &tag, NULL);
+}
+
+static int send_file(struct fio_client *client, struct cmd_sendfile *pdu,
+                    uint64_t tag)
+{
+       struct cmd_sendfile_reply *rep;
+       struct stat sb;
+       size_t size;
+       int fd;
+
+       size = sizeof(*rep);
+       rep = malloc(size);
+
+       if (stat((char *)pdu->path, &sb) < 0) {
+fail:
+               rep->error = errno;
+               sendfile_reply(client->fd, rep, size, tag);
+               free(rep);
+               return 1;
+       }
+
+       size += sb.st_size;
+       rep = realloc(rep, size);
+       rep->size = cpu_to_le32((uint32_t) sb.st_size);
+
+       fd = open((char *)pdu->path, O_RDONLY);
+       if (fd == -1 )
+               goto fail;
+
+       rep->error = read_data(fd, &rep->data, sb.st_size);
+       sendfile_reply(client->fd, rep, size, tag);
+       free(rep);
+       close(fd);
+       return 0;
+}
+
 int fio_handle_client(struct fio_client *client)
 {
        struct client_ops *ops = client->ops;
@@ -1046,12 +1393,10 @@ int fio_handle_client(struct fio_client *client)
                if (ops->quit)
                        ops->quit(client, cmd);
                remove_client(client);
-               free(cmd);
                break;
        case FIO_NET_CMD_TEXT:
                convert_text(cmd);
                ops->text(client, cmd);
-               free(cmd);
                break;
        case FIO_NET_CMD_DU: {
                struct cmd_du_pdu *du = (struct cmd_du_pdu *) cmd->payload;
@@ -1060,7 +1405,6 @@ int fio_handle_client(struct fio_client *client)
                convert_agg(&du->agg);
 
                ops->disk_util(client, cmd);
-               free(cmd);
                break;
                }
        case FIO_NET_CMD_TS: {
@@ -1070,7 +1414,6 @@ int fio_handle_client(struct fio_client *client)
                convert_gs(&p->rs, &p->rs);
 
                ops->thread_status(client, cmd);
-               free(cmd);
                break;
                }
        case FIO_NET_CMD_GS: {
@@ -1079,7 +1422,6 @@ int fio_handle_client(struct fio_client *client)
                convert_gs(gs, gs);
 
                ops->group_stats(client, cmd);
-               free(cmd);
                break;
                }
        case FIO_NET_CMD_ETA: {
@@ -1088,26 +1430,22 @@ int fio_handle_client(struct fio_client *client)
                remove_reply_cmd(client, cmd);
                convert_jobs_eta(je);
                handle_eta(client, cmd);
-               free(cmd);
                break;
                }
        case FIO_NET_CMD_PROBE:
                remove_reply_cmd(client, cmd);
                ops->probe(client, cmd);
-               free(cmd);
                break;
        case FIO_NET_CMD_SERVER_START:
                client->state = Client_running;
                if (ops->job_start)
                        ops->job_start(client, cmd);
-               free(cmd);
                break;
        case FIO_NET_CMD_START: {
                struct cmd_start_pdu *pdu = (struct cmd_start_pdu *) cmd->payload;
 
                pdu->jobs = le32_to_cpu(pdu->jobs);
                ops->start(client, cmd);
-               free(cmd);
                break;
                }
        case FIO_NET_CMD_STOP: {
@@ -1115,16 +1453,21 @@ int fio_handle_client(struct fio_client *client)
 
                convert_stop(cmd);
                client->state = Client_stopped;
-               client->error = pdu->error;
+               client->error = le32_to_cpu(pdu->error);
+               client->signal = le32_to_cpu(pdu->signal);
                ops->stop(client, cmd);
-               free(cmd);
                break;
                }
-       case FIO_NET_CMD_ADD_JOB:
+       case FIO_NET_CMD_ADD_JOB: {
+               struct cmd_add_job_pdu *pdu = (struct cmd_add_job_pdu *) cmd->payload;
+
+               client->thread_number = le32_to_cpu(pdu->thread_number);
+               client->groupid = le32_to_cpu(pdu->groupid);
+
                if (ops->add_job)
                        ops->add_job(client, cmd);
-               free(cmd);
                break;
+               }
        case FIO_NET_CMD_IOLOG:
                if (ops->iolog) {
                        struct cmd_iolog_pdu *pdu;
@@ -1132,17 +1475,62 @@ int fio_handle_client(struct fio_client *client)
                        pdu = convert_iolog(cmd);
                        ops->iolog(client, pdu);
                }
-               free(cmd);
                break;
+       case FIO_NET_CMD_UPDATE_JOB:
+               ops->update_job(client, cmd);
+               remove_reply_cmd(client, cmd);
+               break;
+       case FIO_NET_CMD_VTRIGGER: {
+               struct all_io_list *pdu = (struct all_io_list *) cmd->payload;
+               char buf[64];
+
+               __verify_save_state(pdu, server_name(client, buf, sizeof(buf)));
+               break;
+               }
+       case FIO_NET_CMD_SENDFILE: {
+               struct cmd_sendfile *pdu = (struct cmd_sendfile *) cmd->payload;
+               send_file(client, pdu, cmd->tag);
+               break;
+               }
        default:
                log_err("fio: unknown client op: %s\n", fio_server_op(cmd->opcode));
-               free(cmd);
                break;
        }
 
+       free(cmd);
        return 1;
 }
 
+int fio_clients_send_trigger(const char *cmd)
+{
+       struct flist_head *entry;
+       struct fio_client *client;
+       size_t slen;
+
+       dprint(FD_NET, "client: send vtrigger: %s\n", cmd);
+
+       if (!cmd)
+               slen = 0;
+       else
+               slen = strlen(cmd);
+
+       flist_for_each(entry, &client_list) {
+               struct cmd_vtrigger_pdu *pdu;
+
+               client = flist_entry(entry, struct fio_client, list);
+
+               pdu = malloc(sizeof(*pdu) + slen);
+               pdu->len = cpu_to_le16((uint16_t) slen);
+               if (slen)
+                       memcpy(pdu->cmd, cmd, slen);
+               fio_net_send_cmd(client->fd, FIO_NET_CMD_VTRIGGER, pdu,
+                                       sizeof(*pdu) + slen, NULL, NULL);
+               free(pdu);
+       }
+
+       return 0;
+}
+
 static void request_client_etas(struct client_ops *ops)
 {
        struct fio_client *client;
@@ -1152,8 +1540,7 @@ static void request_client_etas(struct client_ops *ops)
 
        dprint(FD_NET, "client: request eta (%d)\n", nr_clients);
 
-       eta = malloc(sizeof(*eta));
-       memset(&eta->eta, 0, sizeof(eta->eta));
+       eta = calloc(1, sizeof(*eta) + __THREAD_RUNSTR_SZ(REAL_MAX_JOBS));
        eta->pending = nr_clients;
 
        flist_for_each(entry, &client_list) {
@@ -1182,20 +1569,20 @@ static void request_client_etas(struct client_ops *ops)
 static int client_check_cmd_timeout(struct fio_client *client,
                                    struct timeval *now)
 {
-       struct fio_net_int_cmd *cmd;
+       struct fio_net_cmd_reply *reply;
        struct flist_head *entry, *tmp;
        int ret = 0;
 
        flist_for_each_safe(entry, tmp, &client->cmd_list) {
-               cmd = flist_entry(entry, struct fio_net_int_cmd, list);
+               reply = flist_entry(entry, struct fio_net_cmd_reply, list);
 
-               if (mtime_since(&cmd->tv, now) < FIO_NET_CLIENT_TIMEOUT)
+               if (mtime_since(&reply->tv, now) < FIO_NET_CLIENT_TIMEOUT)
                        continue;
 
                log_err("fio: client %s, timeout on cmd %s\n", client->hostname,
-                                               fio_server_op(cmd->cmd.opcode));
-               flist_del(&cmd->list);
-               free(cmd);
+                                               fio_server_op(reply->opcode));
+               flist_del(&reply->list);
+               free(reply);
                ret = 1;
        }
 
@@ -1209,7 +1596,7 @@ static int fio_check_clients_timed_out(void)
        struct timeval tv;
        int ret = 0;
 
-       gettimeofday(&tv, NULL);
+       fio_gettime(&tv, NULL);
 
        flist_for_each_safe(entry, tmp, &client_list) {
                client = flist_entry(entry, struct fio_client, list);
@@ -1237,11 +1624,10 @@ int fio_handle_clients(struct client_ops *ops)
        struct pollfd *pfds;
        int i, ret = 0, retval = 0;
 
-       gettimeofday(&eta_tv, NULL);
+       fio_gettime(&eta_tv, NULL);
 
        pfds = malloc(nr_clients * sizeof(struct pollfd));
 
-       sum_stat_clients = nr_clients;
        init_thread_stat(&client_ts);
        init_group_run_stat(&client_gs);
 
@@ -1271,9 +1657,10 @@ int fio_handle_clients(struct client_ops *ops)
 
                do {
                        struct timeval tv;
+                       int timeout;
 
-                       gettimeofday(&tv, NULL);
-                       if (mtime_since(&eta_tv, &tv) >= ops->eta_msec) {
+                       fio_gettime(&tv, NULL);
+                       if (mtime_since(&eta_tv, &tv) >= 900) {
                                request_client_etas(ops);
                                memcpy(&eta_tv, &tv, sizeof(tv));
 
@@ -1281,7 +1668,11 @@ int fio_handle_clients(struct client_ops *ops)
                                        break;
                        }
 
-                       ret = poll(pfds, nr_clients, 100);
+                       check_trigger_file();
+
+                       timeout = min(100u, ops->eta_msec);
+
+                       ret = poll(pfds, nr_clients, timeout);
                        if (ret < 0) {
                                if (errno == EINTR)
                                        continue;
@@ -1297,7 +1688,7 @@ int fio_handle_clients(struct client_ops *ops)
 
                        client = find_client_by_fd(pfds[i].fd);
                        if (!client) {
-                               log_err("fio: unknown client fd %d\n", pfds[i].fd);
+                               log_err("fio: unknown client fd %ld\n", (long) pfds[i].fd);
                                continue;
                        }
                        if (!fio_handle_client(client)) {
@@ -1311,6 +1702,8 @@ int fio_handle_clients(struct client_ops *ops)
                }
        }
 
+       fio_client_json_fini();
+
        free(pfds);
        return retval;
 }