From fdf5ff2934f4c5c6b483c906fea6e0288df36da2 Mon Sep 17 00:00:00 2001 From: Josh Poimboeuf Date: Fri, 14 Mar 2025 12:29:06 -0700 Subject: [PATCH] objtool: Upgrade "Linked object detected" warning to error Force the user to fix their cmdline if they forget the '--link' option. Signed-off-by: Josh Poimboeuf Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Brendan Jackman Link: https://lore.kernel.org/r/8380bbf3a0fa86e03fd63f60568ae06a48146bc1.1741975349.git.jpoimboe@kernel.org --- tools/objtool/builtin-check.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/objtool/builtin-check.c b/tools/objtool/builtin-check.c index 36d81a455b01..79843512a51b 100644 --- a/tools/objtool/builtin-check.c +++ b/tools/objtool/builtin-check.c @@ -198,8 +198,8 @@ int objtool_run(int argc, const char **argv) return 1; if (!opts.link && has_multiple_files(file->elf)) { - ERROR("Linked object detected, forcing --link"); - opts.link = true; + ERROR("Linked object requires --link"); + goto err; } ret = check(file); -- 2.25.1