From fbd4ab3846b65d0a2455a24ca5c1613d0ec3158a Mon Sep 17 00:00:00 2001 From: Vincent Fu Date: Tue, 12 Jul 2022 15:09:37 +0000 Subject: [PATCH] engines/nfs: remove commit hook The nfs ioengine does not need a commit hook because requests are already committed when the queue hook is called. The queue hook calls nfs_{pread/pwrite}_async and there is no separate commit step necessary for the IO to be fully submitted. This change also allows submission latencies to be reported because the commit hook was not setting the io_u's issue_time. Signed-off-by: Vincent Fu --- engines/nfs.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/engines/nfs.c b/engines/nfs.c index 21be8833..7031769d 100644 --- a/engines/nfs.c +++ b/engines/nfs.c @@ -279,14 +279,6 @@ static int fio_libnfs_close(struct thread_data *td, struct fio_file *f) return ret; } -/* - * Hook for writing out outstanding data. - */ -static int fio_libnfs_commit(struct thread_data *td) { - nfs_event_loop(td, true); - return 0; -} - struct ioengine_ops ioengine = { .name = "nfs", .version = FIO_IOOPS_VERSION, @@ -297,7 +289,6 @@ struct ioengine_ops ioengine = { .cleanup = fio_libnfs_cleanup, .open_file = fio_libnfs_open, .close_file = fio_libnfs_close, - .commit = fio_libnfs_commit, .flags = FIO_DISKLESSIO | FIO_NOEXTEND | FIO_NODISKUTIL, .options = options, .option_struct_size = sizeof(struct fio_libnfs_options), -- 2.25.1