From f79415207ea60109d34bed89b2f3ed303a18d24b Mon Sep 17 00:00:00 2001 From: Krzysztof Helt Date: Mon, 17 Sep 2007 12:52:43 +0200 Subject: [PATCH] [ALSA] ad1848_lib: waiting loops done after cs4231_lib This patch fixes ad1848_lib waiting loops to be the same as in the cs4231_lib. Acked-by: Rene Herman Signed-off-by: Krzysztof Helt Signed-off-by: Takashi Iwai Signed-off-by: Jaroslav Kysela --- sound/isa/ad1848/ad1848_lib.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sound/isa/ad1848/ad1848_lib.c b/sound/isa/ad1848/ad1848_lib.c index eee941be3b74..330b5ced01aa 100644 --- a/sound/isa/ad1848/ad1848_lib.c +++ b/sound/isa/ad1848/ad1848_lib.c @@ -205,7 +205,7 @@ static void snd_ad1848_mce_down(struct snd_ad1848 *chip) { unsigned long flags; int timeout; - signed long time; + unsigned long end_time; spin_lock_irqsave(&chip->reg_lock, flags); for (timeout = 5; timeout > 0; timeout--) @@ -240,27 +240,27 @@ static void snd_ad1848_mce_down(struct snd_ad1848 *chip) snd_printdd("(2) jiffies = %lu\n", jiffies); - time = msecs_to_jiffies(250); + end_time = jiffies + msecs_to_jiffies(250); while (snd_ad1848_in(chip, AD1848_TEST_INIT) & AD1848_CALIB_IN_PROGRESS) { spin_unlock_irqrestore(&chip->reg_lock, flags); - if (time <= 0) { + if (time_after(jiffies, end_time)) { snd_printk(KERN_ERR "mce_down - auto calibration time out (2)\n"); return; } - time = schedule_timeout(time); + msleep(1); spin_lock_irqsave(&chip->reg_lock, flags); } snd_printdd("(3) jiffies = %lu\n", jiffies); - time = msecs_to_jiffies(100); + end_time = jiffies + msecs_to_jiffies(100); while (inb(AD1848P(chip, REGSEL)) & AD1848_INIT) { spin_unlock_irqrestore(&chip->reg_lock, flags); - if (time <= 0) { + if (time_after(jiffies, end_time)) { snd_printk(KERN_ERR "mce_down - auto calibration time out (3)\n"); return; } - time = schedule_timeout(time); + msleep(1); spin_lock_irqsave(&chip->reg_lock, flags); } spin_unlock_irqrestore(&chip->reg_lock, flags); -- 2.25.1