From f2a0e45f36b0a210ff2388ed5fa89f81019c07a1 Mon Sep 17 00:00:00 2001 From: Leon Romanovsky Date: Mon, 18 Feb 2019 22:25:52 +0200 Subject: [PATCH] RDMA/nldev: Don't expose number of not-visible entries Netlink dumpit handshake exchanges the index from which kernel should start to return its value, in current code, this index included not-visible in this PID items too and indirectly revealed the number of entries. Signed-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe --- drivers/infiniband/core/nldev.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c index 8b4f86ce50ce..e7350d9d60e9 100644 --- a/drivers/infiniband/core/nldev.c +++ b/drivers/infiniband/core/nldev.c @@ -1123,13 +1123,10 @@ static int res_get_common_dumpit(struct sk_buff *skb, * objects. */ xa_for_each(&rt->xa, id, res) { - if (idx < start) - goto next; - if (!is_visible_in_pid_ns(res)) - goto next; + continue; - if (!rdma_restrack_get(res)) + if (idx < start || !rdma_restrack_get(res)) goto next; xa_unlock(&rt->xa); -- 2.25.1