From e7b44887cb0ee99d9b62b0177d17efcafbb93dc1 Mon Sep 17 00:00:00 2001 From: Shin'ichiro Kawasaki Date: Mon, 14 Nov 2022 11:13:00 +0900 Subject: [PATCH] zbd: allow block size not divisor of zone size Current implementation checks that block size is divisor of zone size when verify work load is specified. After the recent fix of block size unaligned to zone, this check is no longer valid. Remove the check. The check had been valid since such block size left unwritten area at each zone end and keeps the zones in open/active status until verify read is done. It easily hit max open/active zones limitation. After the fix, the zones with unwritten area are finished then they do not hit the limitation. Signed-off-by: Shin'ichiro Kawasaki Tested-by: Dmitry Fomichev Reviewed-by: Dmitry Fomichev Signed-off-by: Vincent Fu --- zbd.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/zbd.c b/zbd.c index 9ab78e2e..6f4e5ab2 100644 --- a/zbd.c +++ b/zbd.c @@ -652,7 +652,7 @@ static bool zbd_verify_bs(void) { struct thread_data *td; struct fio_file *f; - int i, j, k; + int i, j; for_each_td(td, i) { if (td_trim(td) && @@ -674,15 +674,6 @@ static bool zbd_verify_bs(void) zone_size); return false; } - for (k = 0; k < FIO_ARRAY_SIZE(td->o.bs); k++) { - if (td->o.verify != VERIFY_NONE && - zone_size % td->o.bs[k] != 0) { - log_info("%s: block size %llu is not a divisor of the zone size %"PRIu64"\n", - f->file_name, td->o.bs[k], - zone_size); - return false; - } - } } } return true; -- 2.25.1