From d6fe216caf15d196e1bf76591440f8f17d58e7ee Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Wed, 16 Apr 2025 14:09:20 +0300 Subject: [PATCH] drm/udl: Set error code in udl_init() Return -ENOMEM if udl_alloc_urb_list() fails. Don't return success. Fixes: fb10144ba426 ("drm/udl: Support adapters without firmware descriptor") Signed-off-by: Dan Carpenter Reviewed-by: Thomas Zimmermann Signed-off-by: Thomas Zimmermann Link: https://lore.kernel.org/r/Z_-P4N4_U-xTC9-O@stanley.mountain --- drivers/gpu/drm/udl/udl_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c index 3dfeb88cf918..bc58991a6f14 100644 --- a/drivers/gpu/drm/udl/udl_main.c +++ b/drivers/gpu/drm/udl/udl_main.c @@ -361,6 +361,7 @@ int udl_init(struct udl_device *udl) if (!udl_alloc_urb_list(udl, WRITES_IN_FLIGHT, MAX_TRANSFER)) { DRM_ERROR("udl_alloc_urb_list failed\n"); + ret = -ENOMEM; goto err; } -- 2.25.1