From c0c1840adae820efa96fb0ff797b8bc60a672d63 Mon Sep 17 00:00:00 2001 From: "Aneesh Kumar K.V" Date: Mon, 29 Oct 2007 20:47:28 +0100 Subject: [PATCH 1/1] blktrace segfault Core was generated by `blktrace -d /dev/hdc'. Program terminated with signal 11, Segmentation fault. #0 0xb7e4cdec in ?? () (gdb) where #0 0xb7e4cdec in ?? () #1 0xb7dbf000 in ?? () #2 0x00021000 in ?? () #3 0xb7dee6e8 in ?? () #4 0x0804ecf0 in ?? () #5 0x00000001 in ?? () #6 0x6c616367 in ?? () #7 0xbfee3f68 in ?? () #8 0xb7f51300 in ?? () #9 0x00000168 in ?? () #10 0x0804ecf0 in ?? () #11 0x00000001 in ?? () #12 0xbfee3f88 in ?? () #13 0xbfee3f68 in ?? () #14 0x080499dc in close_thread (tip=0xb7f1eff4) at blktrace.c:637 Backtrace stopped: frame did not save the PC (gdb) the below diff fix the same. Signed-off-by: Jens Axboe --- blktrace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/blktrace.c b/blktrace.c index 42613a7..4f4fcde 100644 --- a/blktrace.c +++ b/blktrace.c @@ -1220,6 +1220,7 @@ static int start_devices(void) size = ncpus * sizeof(struct thread_information); thread_information = malloc(size * ndevs); + memset(thread_information, 0, size*ndevs); if (!thread_information) { fprintf(stderr, "Out of memory, threads (%d)\n", size * ndevs); return 1; -- 2.25.1