From bab8551e33f7f5e8743ccb49be41fe3228178e8a Mon Sep 17 00:00:00 2001 From: Karan Tilak Kumar Date: Mon, 6 Jan 2025 14:44:51 -0800 Subject: [PATCH] scsi: fnic: Remove unnecessary else to fix warning in FDLS FIP Implement review comments from Martin: Remove unnecessary else from fip.c to fix a warning. Reviewed-by: Sesidhar Baddela Reviewed-by: Arulprabhu Ponnusamy Reviewed-by: Gian Carlo Boffa Reviewed-by: Arun Easi Signed-off-by: Karan Tilak Kumar Link: https://lore.kernel.org/r/20250106224451.3597-3-kartilak@cisco.com Signed-off-by: Martin K. Petersen --- drivers/scsi/fnic/fip.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/fnic/fip.c b/drivers/scsi/fnic/fip.c index aaf5f768a9bd..7bb85949033f 100644 --- a/drivers/scsi/fnic/fip.c +++ b/drivers/scsi/fnic/fip.c @@ -154,16 +154,15 @@ void fnic_fcoe_process_vlan_resp(struct fnic *fnic, struct fip_header *fiph) vlan->state = FIP_VLAN_AVAIL; list_add_tail(&vlan->list, &fnic->vlan_list); break; - } else { - FNIC_FIP_DBG(KERN_INFO, fnic->host, - fnic->fnic_num, - "Invalid descriptor type(%x) in VLan response\n", - vlan_desc->fd_desc.fip_dtype); - /* - * Note : received a type=2 descriptor here i.e. FIP - * MAC Address Descriptor - */ } + FNIC_FIP_DBG(KERN_INFO, fnic->host, + fnic->fnic_num, + "Invalid descriptor type(%x) in VLan response\n", + vlan_desc->fd_desc.fip_dtype); + /* + * Note : received a type=2 descriptor here i.e. FIP + * MAC Address Descriptor + */ cur_desc += vlan_desc->fd_desc.fip_dlen; desc_len -= vlan_desc->fd_desc.fip_dlen; } -- 2.25.1