From ba342e585aa512edbd37cf736850fcb3cb5ca76d Mon Sep 17 00:00:00 2001 From: Ankit Kumar Date: Mon, 11 Sep 2023 21:54:59 +0530 Subject: [PATCH] engines:io_uring_cmd: disallow verify for e2e pi with extended blocks For extended logical block sizes we cannot use verify when end to end data protection checks are enabled. The CRC field in PI section of data buffer creates conflict during verify phase. The verify check is also redundant as end to end data protection already ensures data integrity. So disallow use of verify for this case. Signed-off-by: Ankit Kumar Signed-off-by: Jens Axboe --- engines/io_uring.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/engines/io_uring.c b/engines/io_uring.c index 6cdf1b4f..05703df8 100644 --- a/engines/io_uring.c +++ b/engines/io_uring.c @@ -18,6 +18,7 @@ #include "../lib/memalign.h" #include "../lib/fls.h" #include "../lib/roundup.h" +#include "../verify.h" #ifdef ARCH_HAVE_IOURING @@ -1299,6 +1300,19 @@ static int fio_ioring_cmd_open_file(struct thread_data *td, struct fio_file *f) return 1; } } + + /* + * For extended logical block sizes we cannot use verify when + * end to end data protection checks are enabled, as the PI + * section of data buffer conflicts with verify. + */ + if (data->ms && data->pi_type && data->lba_ext && + td->o.verify != VERIFY_NONE) { + log_err("%s: for extended LBA, verify cannot be used when E2E data protection is enabled\n", + f->file_name); + td_verror(td, EINVAL, "fio_ioring_cmd_open_file"); + return 1; + } } if (!ld || !o->registerfiles) return generic_open_file(td, f); -- 2.25.1