From b612a9762b20be3c30a16625adb292e9f1ff25a6 Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Sat, 11 Mar 2017 19:32:05 +0000 Subject: [PATCH] staging: atomisp: clean up return logic, remove redunant code There is no need to check if ret is non-zero, remove this redundant check and just return the error status from the call to mt9m114_write_reg_array. Detected by CoverityScan, CID#1416577 ("Identical code for different branches") Signed-off-by: Colin Ian King Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/atomisp/i2c/mt9m114.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/mt9m114.c b/drivers/staging/media/atomisp/i2c/mt9m114.c index 1b79cdb27ce6..f9a00228765f 100644 --- a/drivers/staging/media/atomisp/i2c/mt9m114.c +++ b/drivers/staging/media/atomisp/i2c/mt9m114.c @@ -444,12 +444,8 @@ static int mt9m114_set_suspend(struct v4l2_subdev *sd) static int mt9m114_init_common(struct v4l2_subdev *sd) { struct i2c_client *client = v4l2_get_subdevdata(sd); - int ret; - ret = mt9m114_write_reg_array(client, mt9m114_common, PRE_POLLING); - if (ret) - return ret; - return ret; + return mt9m114_write_reg_array(client, mt9m114_common, PRE_POLLING); } static int power_ctrl(struct v4l2_subdev *sd, bool flag) -- 2.25.1